From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jiaxin.wu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 6492D20958BC2
 for <edk2-devel@lists.01.org>; Thu, 31 Aug 2017 17:48:12 -0700 (PDT)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga105.jf.intel.com with ESMTP; 31 Aug 2017 17:50:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,456,1498546800"; d="scan'208";a="146925250"
Received: from jiaxinwu-mobl2.ccr.corp.intel.com ([10.239.196.85])
 by fmsmga006.fm.intel.com with ESMTP; 31 Aug 2017 17:50:54 -0700
From: Jiaxin Wu <jiaxin.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Ye Ting <ting.ye@intel.com>, Fu Siyuan <siyuan.fu@intel.com>,
 Wu Jiaxin <jiaxin.wu@intel.com>
Date: Fri,  1 Sep 2017 08:50:52 +0800
Message-Id: <1504227052-64748-1-git-send-email-jiaxin.wu@intel.com>
X-Mailer: git-send-email 1.9.5.msysgit.1
Subject: [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS.
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Sep 2017 00:48:12 -0000

When creating the ISCSI string OpCode for IP_ADDRESS, the max length
should be IP(4)_STR_MAX_SIZE instead of IP(4)_MAX_SIZE.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c
index e20fe91..efd05cf 100644
--- a/NetworkPkg/IScsiDxe/IScsiMisc.c
+++ b/NetworkPkg/IScsiDxe/IScsiMisc.c
@@ -1007,11 +1007,11 @@ IScsiCreateKeywords (
       StringToken,
       StringToken,
       0,
       0,
       IP4_MIN_SIZE,
-      IP4_MAX_SIZE,
+      IP4_STR_MAX_SIZE,
       NULL
       );
 
     //
     // Create iSCSIInitiatorNetmask Keyword.
@@ -1033,11 +1033,11 @@ IScsiCreateKeywords (
       StringToken,
       StringToken,
       0,
       0,
       IP4_MIN_SIZE,
-      IP4_MAX_SIZE,
+      IP4_STR_MAX_SIZE,
       NULL
       );
 
     //
     // Create iSCSIInitiatorGateway Keyword.
@@ -1059,11 +1059,11 @@ IScsiCreateKeywords (
       StringToken,
       StringToken,
       0,
       0,
       IP4_MIN_SIZE,
-      IP4_MAX_SIZE,
+      IP4_STR_MAX_SIZE,
       NULL
       );
 
     //
     // Create iSCSITargetInfoViaDHCP Keyword.
@@ -1165,11 +1165,11 @@ IScsiCreateKeywords (
       StringToken,
       StringToken,
       0,
       0,
       IP_MIN_SIZE,
-      IP_MAX_SIZE,
+      IP_STR_MAX_SIZE,
       NULL
       );
 
     //
     // Create iSCSILUN Keyword.
-- 
1.9.5.msysgit.1