From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 82AEE21E3EA79 for ; Mon, 4 Sep 2017 06:31:44 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 06:34:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,474,1498546800"; d="scan'208";a="307765698" Received: from luisamar-mobl3.amr.corp.intel.com (HELO localhost) ([10.254.181.154]) by fmsmga004.fm.intel.com with ESMTP; 04 Sep 2017 06:34:31 -0700 MIME-Version: 1.0 To: Ge Song , Laszlo Ersek , edk2-devel@lists.01.org Message-ID: <150453207055.10722.7097788282280420028@jljusten-skl> From: Jordan Justen In-Reply-To: Cc: Ard Biesheuvel References: <20170903021214.11516-1-ge.song@hxt-semitech.com> <20170903021214.11516-2-ge.song@hxt-semitech.com> User-Agent: alot/0.6 Date: Mon, 04 Sep 2017 09:34:31 -0400 Subject: Re: [PATCH v1 1/1] OvmfPkg/SecMain: Fix stack switching to permanent memory fail X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 13:31:44 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-09-03 16:55:36, Laszlo Ersek wrote: > On 09/03/17 04:12, Ge Song wrote: > > In earlier PEI stage, temporary memory(Cache As Ram) is employed as sta= ck > > and heap. We move them to the new room and do some relocation fixup when > > permanent memory becomes available. TemporaryRamMigration() > > is responsible for switching the stack. > = > [...] > = > > Cc: Jordan Justen > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ge Song > > --- > > OvmfPkg/Sec/SecMain.c | 2 ++ > > 1 file changed, 2 insertions(+) > = > (No more separate emails, I promise.) > = > Before you send v2, can you please amend the patch like this: > = > git commit --amend --author=3D'Ge Song ' > = > It's OK if you mail it out from another email address, but IMO the git > authorship should match the first Signed-off-by. I disagree with this. Unless the individual is well known to the EDK II community as the owner of both email addresses, I think the author needs to send it from their author email. I suppose they can send it from another email, and then reply from their other email saying they contributed it under the Tianocore Contribution Agreement, but that sounds like a stretch... -Jordan > The commit message body currently does not start with "From: Ge Song > ", which means that the git authorship and the > first S-o-b disagree at the moment. > = > ... If I'm wrong about this, I can be convinced, of course. > = > Thanks > Laszlo