From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5D9132095BB6A for ; Tue, 5 Sep 2017 10:43:09 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2017 10:45:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,480,1498546800"; d="scan'208";a="1191805046" Received: from jljusten-skl.jf.intel.com (HELO localhost) ([10.54.75.24]) by fmsmga001.fm.intel.com with ESMTP; 05 Sep 2017 10:45:57 -0700 MIME-Version: 1.0 To: Ge Song , Laszlo Ersek , edk2-devel@lists.01.org Message-ID: <150463355735.10253.17993674709751476963@jljusten-skl.jf.intel.com> From: Jordan Justen In-Reply-To: <711fe92e-7b15-e349-b853-65b07315053e@redhat.com> Cc: Ard Biesheuvel , "Kinney, Michael D" , Andrew Fish , Leif Lindholm References: <20170903021214.11516-1-ge.song@hxt-semitech.com> <20170903021214.11516-2-ge.song@hxt-semitech.com> <150453207055.10722.7097788282280420028@jljusten-skl> <7db5728c-a901-012e-0584-99c4b10d988e@gmail.com> <711fe92e-7b15-e349-b853-65b07315053e@redhat.com> User-Agent: alot/0.6 Date: Tue, 05 Sep 2017 10:45:57 -0700 Subject: Re: [PATCH v1 1/1] OvmfPkg/SecMain: Fix stack switching to permanent memory fail X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 17:43:09 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-09-04 14:25:48, Laszlo Ersek wrote: > On 09/04/17 17:11, Ge Song wrote: > > On 09/04/2017 09:34 PM, Jordan Justen wrote: > > = > >> On 2017-09-03 16:55:36, Laszlo Ersek wrote: > >>> On 09/03/17 04:12, Ge Song wrote: > >>>> In earlier PEI stage, temporary memory(Cache As Ram) is employed as > >>>> stack > >>>> and heap. We move them to the new room and do some relocation fixup > >>>> when > >>>> permanent memory becomes available. TemporaryRamMigration() > >>>> is responsible for switching the stack. > >>> [...] > >>> > >>>> Cc: Jordan Justen > >>>> Cc: Laszlo Ersek > >>>> Cc: Ard Biesheuvel > >>>> Contributed-under: TianoCore Contribution Agreement 1.1 > >>>> Signed-off-by: Ge Song > >>>> --- > >>>> =C2=A0 OvmfPkg/Sec/SecMain.c | 2 ++ > >>>> =C2=A0 1 file changed, 2 insertions(+) > >>> (No more separate emails, I promise.) > >>> > >>> Before you send v2, can you please amend the patch like this: > >>> > >>> =C2=A0=C2=A0 git commit --amend --author=3D'Ge Song ' > >>> > >>> It's OK if you mail it out from another email address, but IMO the git > >>> authorship should match the first Signed-off-by. > >> I disagree with this. Unless the individual is well known to the EDK > >> II community as the owner of both email addresses, I think the author > >> needs to send it from their author email. > >> > >> I suppose they can send it from another email, and then reply from > >> their other email saying they contributed it under the Tianocore > >> Contribution Agreement, but that sounds like a stretch... > = > I'm fine either way, as long as we can establish some kind of agreement > between (two of?) the three email addresses (sender, git author, S-o-b). We've generally said they need to match. If it is a one-time contribution, then I think it is acceptable for the contributor to reply to the patch from the author's email saying: "This is me. I contributed it under the Tiancore Contribution Agreement" I think any change from this policy should be decided by the stewards. Regarding Ge Song's contribution, I think things are now even more complicated. It sounds like the contribution is being made by ge.song@hxt-semitech.com, but due to "IT issues" v2 is now being authored/sent from songgebird@gmail.com. Does hxt-semitech.com agree to this contribution? I think given that we know ge.song@hxt-semitech.com is the intended author, the patch should have ge.song@hxt-semitech.com as the author with ge.song@hxt-semitech.com in the Signed-off-by. Ideally it should be sent from ge.song@hxt-semitech.com, but if that is not possible, then ge.song@hxt-semitech.com should reply to the patch sent by songgebird@gmail.com re-iterating the Signed-off-by/Contributed-under is from ge.song@hxt-semitech.com. Ge Song, Can you send a v3 with the author reset to ge.song@hxt-semitech.com (see lersek's git commit command above) and the Signed-off-by using ge.song@hxt-semitech.com, and then reply to the patch posting from ge.song@hxt-semitech.com to re-iterate the Signed-off-by and Contributed-under? > > OK, I'll try to send it from the same email address next time, the reas= on > > that using two different mail addresses is because the author email is = an > > exchange account and it's hard to find the mail server preferences for > > git-send-email... Sorry for the hassle, but maybe if you are able to work with your IT department to setup git send-email then you'll be able to contribute to other open source project's easier from your ge.song@hxt-semitech.com email address. -Jordan