From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4FCDC21D492F4 for ; Wed, 13 Sep 2017 23:30:49 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2017 23:33:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,391,1500966000"; d="scan'208";a="311521496" Received: from cwbutler-mobl.amr.corp.intel.com (HELO localhost) ([10.254.13.190]) by fmsmga004.fm.intel.com with ESMTP; 13 Sep 2017 23:33:47 -0700 MIME-Version: 1.0 To: "Wang, Jian J" , "edk2-devel@lists.01.org" Message-ID: <150537082712.13282.5148509677492264196@jljusten-skl> From: Jordan Justen In-Reply-To: Cc: "Yao, Jiewen" , "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , "Kinney, Michael D" , "Wolman, Ayellet" References: <20170913092507.12504-1-jian.j.wang@intel.com> <20170913092507.12504-2-jian.j.wang@intel.com> <150532368984.21662.15999032054940467421@jljusten-skl> User-Agent: alot/0.6 Date: Wed, 13 Sep 2017 23:33:47 -0700 Subject: Re: [PATCH 1/4] MdeModulePkg/Core: Implement NULL pointer detection in EDK-II Core. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 06:30:49 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-09-13 18:25:22, Wang, Jian J wrote: > See my comments start with [Jian] below. > = > -----Original Message----- > From: Justen, Jordan L = > Sent: Thursday, September 14, 2017 1:28 AM > = > > diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/= DxeMain.inf > > index 30d5984f7c..273b8b7c0e 100644 > > --- a/MdeModulePkg/Core/Dxe/DxeMain.inf > > +++ b/MdeModulePkg/Core/Dxe/DxeMain.inf > > @@ -179,7 +179,7 @@ > > gEfiWatchdogTimerArchProtocolGuid ## CONSUMES > > = > > [FeaturePcd] > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport = ## CONSUMES > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport = ## CONSUMES > = > Why is this line changed? > [Jian] Just align the comment followed because the new one added I was looking in the patch, and it didn't look like it was now aligned with the comments above or below. (It is 1 column less than the section below, right?) My opinion is to not change the line since it is in a separate section of the inf file. -Jordan > = > > = > > [Pcd] > > gEfiMdeModulePkgTokenSpaceGuid.PcdLoadFixAddressBootTimeCodePageNumb= er ## SOMETIMES_CONSUMES > > @@ -192,6 +192,7 @@ > > gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable = ## CONSUMES > > gEfiMdeModulePkgTokenSpaceGuid.PcdImageProtectionPolicy = ## CONSUMES > > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeNxMemoryProtectionPolicy = ## CONSUMES > > + gEfiMdeModulePkgTokenSpaceGuid.PcdNullPointerDetectionPropertyMask = ## CONSUMES