* Re: [PATCH] TFTP : tftp fix for full volume case
2017-09-25 14:37 [PATCH] TFTP : tftp fix for full volume case Meenakshi Aggarwal
@ 2017-09-25 9:00 ` Ni, Ruiyu
2017-09-25 15:06 ` [PATCH v2] " Meenakshi Aggarwal
1 sibling, 0 replies; 9+ messages in thread
From: Ni, Ruiyu @ 2017-09-25 9:00 UTC (permalink / raw)
To: Meenakshi Aggarwal, edk2-devel@lists.01.org, Carsey, Jaben
Cc: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org, Fu, Siyuan,
Ye, Ting
+ Siyuan and Ting.
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Meenakshi Aggarwal
Sent: Monday, September 25, 2017 10:37 PM
To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
Cc: leif.lindholm@linaro.org; ard.biesheuvel@linaro.org
Subject: [edk2] [PATCH] TFTP : tftp fix for full volume case
Issue :
When storage media is full, tftp was resulting in ASSERT MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages was zero.
Reason:
While doing tftp, function call ShellWriteFile was modifying FileSize variable. In case of full disk it was coming out to be Zero.
Fix:
Storage the original filesize in local variable, and use this variable while freeing the pages.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
---
ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
index 5c50797..fae8a69 100755
--- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
+++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
@@ -284,6 +284,7 @@ ShellCommandRunTftp (
EFI_HANDLE Mtftp4ChildHandle;
EFI_MTFTP4_PROTOCOL *Mtftp4;
UINTN FileSize;
+ UINTN DataSize;
VOID *Data;
SHELL_FILE_HANDLE FileHandle;
UINT16 BlockSize;
@@ -537,6 +538,7 @@ ShellCommandRunTftp (
goto NextHandle;
}
+ DataSize = FileSize;
Status = ShellWriteFile (FileHandle, &FileSize, Data);
if (!EFI_ERROR (Status)) {
ShellStatus = SHELL_SUCCESS;
@@ -551,7 +553,7 @@ ShellCommandRunTftp (
NextHandle:
if (Data != NULL) {
- gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data, EFI_SIZE_TO_PAGES (FileSize));
+ gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
+ EFI_SIZE_TO_PAGES (DataSize));
}
CloseProtocolAndDestroyServiceChild (
--
1.9.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] TFTP : tftp fix for full volume case
@ 2017-09-25 14:37 Meenakshi Aggarwal
2017-09-25 9:00 ` Ni, Ruiyu
2017-09-25 15:06 ` [PATCH v2] " Meenakshi Aggarwal
0 siblings, 2 replies; 9+ messages in thread
From: Meenakshi Aggarwal @ 2017-09-25 14:37 UTC (permalink / raw)
To: edk2-devel, ruiyu.ni, jaben.carsey
Cc: ard.biesheuvel, leif.lindholm, Meenakshi Aggarwal, Udit Kumar,
Vabhav Sharma
Issue :
When storage media is full, tftp was resulting in ASSERT
MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages
was zero.
Reason:
While doing tftp, function call ShellWriteFile was modifying
FileSize variable. In case of full disk it was coming out to be
Zero.
Fix:
Storage the original filesize in local variable, and use this
variable while freeing the pages.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
---
ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
index 5c50797..fae8a69 100755
--- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
+++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
@@ -284,6 +284,7 @@ ShellCommandRunTftp (
EFI_HANDLE Mtftp4ChildHandle;
EFI_MTFTP4_PROTOCOL *Mtftp4;
UINTN FileSize;
+ UINTN DataSize;
VOID *Data;
SHELL_FILE_HANDLE FileHandle;
UINT16 BlockSize;
@@ -537,6 +538,7 @@ ShellCommandRunTftp (
goto NextHandle;
}
+ DataSize = FileSize;
Status = ShellWriteFile (FileHandle, &FileSize, Data);
if (!EFI_ERROR (Status)) {
ShellStatus = SHELL_SUCCESS;
@@ -551,7 +553,7 @@ ShellCommandRunTftp (
NextHandle:
if (Data != NULL) {
- gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data, EFI_SIZE_TO_PAGES (FileSize));
+ gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data, EFI_SIZE_TO_PAGES (DataSize));
}
CloseProtocolAndDestroyServiceChild (
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2] TFTP : tftp fix for full volume case
2017-09-25 14:37 [PATCH] TFTP : tftp fix for full volume case Meenakshi Aggarwal
2017-09-25 9:00 ` Ni, Ruiyu
@ 2017-09-25 15:06 ` Meenakshi Aggarwal
2017-09-26 0:42 ` Fu, Siyuan
1 sibling, 1 reply; 9+ messages in thread
From: Meenakshi Aggarwal @ 2017-09-25 15:06 UTC (permalink / raw)
To: edk2-devel, ruiyu.ni, jaben.carsey
Cc: ard.biesheuvel, leif.lindholm, siyuan.fu, ting.ye,
Meenakshi Aggarwal, Udit Kumar, Vabhav Sharma
Issue :
When storage media is full, tftp was resulting in ASSERT
MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages
was zero.
Reason:
While doing tftp, function call ShellWriteFile was modifying
FileSize variable. In case of full disk it was coming out to be
Zero.
Fix:
Storage the original filesize in local variable, and use this
variable while freeing the pages.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
---
ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
index 5c50797..fbde3bf 100755
--- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
+++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
@@ -284,6 +284,7 @@ ShellCommandRunTftp (
EFI_HANDLE Mtftp4ChildHandle;
EFI_MTFTP4_PROTOCOL *Mtftp4;
UINTN FileSize;
+ UINTN DataSize;
VOID *Data;
SHELL_FILE_HANDLE FileHandle;
UINT16 BlockSize;
@@ -294,6 +295,7 @@ ShellCommandRunTftp (
AsciiRemoteFilePath = NULL;
Handles = NULL;
FileSize = 0;
+ DataSize = 0;
BlockSize = MTFTP_DEFAULT_BLKSIZE;
//
@@ -537,6 +539,7 @@ ShellCommandRunTftp (
goto NextHandle;
}
+ DataSize = FileSize;
Status = ShellWriteFile (FileHandle, &FileSize, Data);
if (!EFI_ERROR (Status)) {
ShellStatus = SHELL_SUCCESS;
@@ -551,7 +554,7 @@ ShellCommandRunTftp (
NextHandle:
if (Data != NULL) {
- gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data, EFI_SIZE_TO_PAGES (FileSize));
+ gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data, EFI_SIZE_TO_PAGES (DataSize));
}
CloseProtocolAndDestroyServiceChild (
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] TFTP : tftp fix for full volume case
2017-09-25 15:06 ` [PATCH v2] " Meenakshi Aggarwal
@ 2017-09-26 0:42 ` Fu, Siyuan
2017-09-27 3:31 ` Meenakshi Aggarwal
0 siblings, 1 reply; 9+ messages in thread
From: Fu, Siyuan @ 2017-09-26 0:42 UTC (permalink / raw)
To: Meenakshi Aggarwal, edk2-devel@lists.01.org, Ni, Ruiyu,
Carsey, Jaben
Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, Ye, Ting,
Udit Kumar, Vabhav Sharma
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
-----Original Message-----
From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
Sent: Monday, September 25, 2017 11:06 PM
To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Fu, Siyuan <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>; Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Udit Kumar <udit.kumar@nxp.com>; Vabhav Sharma <vabhav.sharma@nxp.com>
Subject: [PATCH v2] TFTP : tftp fix for full volume case
Issue :
When storage media is full, tftp was resulting in ASSERT
MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages
was zero.
Reason:
While doing tftp, function call ShellWriteFile was modifying
FileSize variable. In case of full disk it was coming out to be
Zero.
Fix:
Storage the original filesize in local variable, and use this
variable while freeing the pages.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
---
ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
index 5c50797..fbde3bf 100755
--- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
+++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
@@ -284,6 +284,7 @@ ShellCommandRunTftp (
EFI_HANDLE Mtftp4ChildHandle;
EFI_MTFTP4_PROTOCOL *Mtftp4;
UINTN FileSize;
+ UINTN DataSize;
VOID *Data;
SHELL_FILE_HANDLE FileHandle;
UINT16 BlockSize;
@@ -294,6 +295,7 @@ ShellCommandRunTftp (
AsciiRemoteFilePath = NULL;
Handles = NULL;
FileSize = 0;
+ DataSize = 0;
BlockSize = MTFTP_DEFAULT_BLKSIZE;
//
@@ -537,6 +539,7 @@ ShellCommandRunTftp (
goto NextHandle;
}
+ DataSize = FileSize;
Status = ShellWriteFile (FileHandle, &FileSize, Data);
if (!EFI_ERROR (Status)) {
ShellStatus = SHELL_SUCCESS;
@@ -551,7 +554,7 @@ ShellCommandRunTftp (
NextHandle:
if (Data != NULL) {
- gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data, EFI_SIZE_TO_PAGES (FileSize));
+ gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data, EFI_SIZE_TO_PAGES (DataSize));
}
CloseProtocolAndDestroyServiceChild (
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] TFTP : tftp fix for full volume case
2017-09-26 0:42 ` Fu, Siyuan
@ 2017-09-27 3:31 ` Meenakshi Aggarwal
2017-10-09 6:28 ` Meenakshi Aggarwal
0 siblings, 1 reply; 9+ messages in thread
From: Meenakshi Aggarwal @ 2017-09-27 3:31 UTC (permalink / raw)
To: Fu, Siyuan, edk2-devel@lists.01.org, Ni, Ruiyu, Carsey, Jaben,
Ye, Ting
Hi,
Thanks for the review Siyuan.
Ting,
Any comment from your side?
Thanks,
Meenakshi
> -----Original Message-----
> From: Fu, Siyuan [mailto:siyuan.fu@intel.com]
> Sent: Tuesday, September 26, 2017 6:12 AM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>
> Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Ye, Ting
> <ting.ye@intel.com>; Udit Kumar <udit.kumar@nxp.com>; Vabhav Sharma
> <vabhav.sharma@nxp.com>
> Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
>
> Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
>
> -----Original Message-----
> From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
> Sent: Monday, September 25, 2017 11:06 PM
> To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>
> Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Fu, Siyuan
> <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; Udit Kumar <udit.kumar@nxp.com>;
> Vabhav Sharma <vabhav.sharma@nxp.com>
> Subject: [PATCH v2] TFTP : tftp fix for full volume case
>
> Issue :
> When storage media is full, tftp was resulting in ASSERT
> MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages was
> zero.
>
> Reason:
> While doing tftp, function call ShellWriteFile was modifying FileSize variable.
> In case of full disk it was coming out to be Zero.
>
> Fix:
> Storage the original filesize in local variable, and use this variable while
> freeing the pages.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
> ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> index 5c50797..fbde3bf 100755
> --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> @@ -284,6 +284,7 @@ ShellCommandRunTftp (
> EFI_HANDLE Mtftp4ChildHandle;
> EFI_MTFTP4_PROTOCOL *Mtftp4;
> UINTN FileSize;
> + UINTN DataSize;
> VOID *Data;
> SHELL_FILE_HANDLE FileHandle;
> UINT16 BlockSize;
> @@ -294,6 +295,7 @@ ShellCommandRunTftp (
> AsciiRemoteFilePath = NULL;
> Handles = NULL;
> FileSize = 0;
> + DataSize = 0;
> BlockSize = MTFTP_DEFAULT_BLKSIZE;
>
> //
> @@ -537,6 +539,7 @@ ShellCommandRunTftp (
> goto NextHandle;
> }
>
> + DataSize = FileSize;
> Status = ShellWriteFile (FileHandle, &FileSize, Data);
> if (!EFI_ERROR (Status)) {
> ShellStatus = SHELL_SUCCESS;
> @@ -551,7 +554,7 @@ ShellCommandRunTftp (
> NextHandle:
>
> if (Data != NULL) {
> - gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> EFI_SIZE_TO_PAGES (FileSize));
> + gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> + EFI_SIZE_TO_PAGES (DataSize));
> }
>
> CloseProtocolAndDestroyServiceChild (
> --
> 1.9.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] TFTP : tftp fix for full volume case
2017-09-27 3:31 ` Meenakshi Aggarwal
@ 2017-10-09 6:28 ` Meenakshi Aggarwal
2017-10-09 14:13 ` Carsey, Jaben
0 siblings, 1 reply; 9+ messages in thread
From: Meenakshi Aggarwal @ 2017-10-09 6:28 UTC (permalink / raw)
To: Fu, Siyuan, edk2-devel@lists.01.org, Ni, Ruiyu, Carsey, Jaben,
Ye, Ting
Hi Team,
Any further comments on this patch?
Or is it ready to merge in edk2?
Thanks,
Meenakshi
> -----Original Message-----
> From: Meenakshi Aggarwal
> Sent: Wednesday, September 27, 2017 9:01 AM
> To: 'Fu, Siyuan' <siyuan.fu@intel.com>; edk2-devel@lists.01.org; Ni, Ruiyu
> <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; Ye, Ting
> <ting.ye@intel.com>
> Cc: Udit Kumar <udit.kumar@nxp.com>; Vabhav Sharma
> <vabhav.sharma@nxp.com>
> Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
>
> Hi,
>
> Thanks for the review Siyuan.
>
>
> Ting,
>
> Any comment from your side?
>
> Thanks,
> Meenakshi
>
> > -----Original Message-----
> > From: Fu, Siyuan [mailto:siyuan.fu@intel.com]
> > Sent: Tuesday, September 26, 2017 6:12 AM
> > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> > devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> > <jaben.carsey@intel.com>
> > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Ye, Ting
> > <ting.ye@intel.com>; Udit Kumar <udit.kumar@nxp.com>; Vabhav Sharma
> > <vabhav.sharma@nxp.com>
> > Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
> >
> > Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> >
> > -----Original Message-----
> > From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
> > Sent: Monday, September 25, 2017 11:06 PM
> > To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey,
> > Jaben <jaben.carsey@intel.com>
> > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Fu, Siyuan
> > <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>; Meenakshi
> > Aggarwal <meenakshi.aggarwal@nxp.com>; Udit Kumar
> > <udit.kumar@nxp.com>; Vabhav Sharma <vabhav.sharma@nxp.com>
> > Subject: [PATCH v2] TFTP : tftp fix for full volume case
> >
> > Issue :
> > When storage media is full, tftp was resulting in ASSERT
> > MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages was
> zero.
> >
> > Reason:
> > While doing tftp, function call ShellWriteFile was modifying FileSize variable.
> > In case of full disk it was coming out to be Zero.
> >
> > Fix:
> > Storage the original filesize in local variable, and use this variable
> > while freeing the pages.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
> > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > ---
> > ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > index 5c50797..fbde3bf 100755
> > --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > @@ -284,6 +284,7 @@ ShellCommandRunTftp (
> > EFI_HANDLE Mtftp4ChildHandle;
> > EFI_MTFTP4_PROTOCOL *Mtftp4;
> > UINTN FileSize;
> > + UINTN DataSize;
> > VOID *Data;
> > SHELL_FILE_HANDLE FileHandle;
> > UINT16 BlockSize;
> > @@ -294,6 +295,7 @@ ShellCommandRunTftp (
> > AsciiRemoteFilePath = NULL;
> > Handles = NULL;
> > FileSize = 0;
> > + DataSize = 0;
> > BlockSize = MTFTP_DEFAULT_BLKSIZE;
> >
> > //
> > @@ -537,6 +539,7 @@ ShellCommandRunTftp (
> > goto NextHandle;
> > }
> >
> > + DataSize = FileSize;
> > Status = ShellWriteFile (FileHandle, &FileSize, Data);
> > if (!EFI_ERROR (Status)) {
> > ShellStatus = SHELL_SUCCESS;
> > @@ -551,7 +554,7 @@ ShellCommandRunTftp (
> > NextHandle:
> >
> > if (Data != NULL) {
> > - gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> > EFI_SIZE_TO_PAGES (FileSize));
> > + gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> > + EFI_SIZE_TO_PAGES (DataSize));
> > }
> >
> > CloseProtocolAndDestroyServiceChild (
> > --
> > 1.9.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] TFTP : tftp fix for full volume case
2017-10-09 6:28 ` Meenakshi Aggarwal
@ 2017-10-09 14:13 ` Carsey, Jaben
2017-10-10 5:22 ` Ni, Ruiyu
0 siblings, 1 reply; 9+ messages in thread
From: Carsey, Jaben @ 2017-10-09 14:13 UTC (permalink / raw)
To: Meenakshi Aggarwal, Fu, Siyuan, edk2-devel@lists.01.org,
Ni, Ruiyu, Ye, Ting
I am fine. Ray?
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Meenakshi Aggarwal
> Sent: Sunday, October 08, 2017 11:28 PM
> To: Fu, Siyuan <siyuan.fu@intel.com>; edk2-devel@lists.01.org; Ni, Ruiyu
> <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; Ye, Ting
> <ting.ye@intel.com>
> Subject: Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case
> Importance: High
>
> Hi Team,
>
>
> Any further comments on this patch?
>
> Or is it ready to merge in edk2?
>
>
> Thanks,
> Meenakshi
>
> > -----Original Message-----
> > From: Meenakshi Aggarwal
> > Sent: Wednesday, September 27, 2017 9:01 AM
> > To: 'Fu, Siyuan' <siyuan.fu@intel.com>; edk2-devel@lists.01.org; Ni, Ruiyu
> > <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; Ye, Ting
> > <ting.ye@intel.com>
> > Cc: Udit Kumar <udit.kumar@nxp.com>; Vabhav Sharma
> > <vabhav.sharma@nxp.com>
> > Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
> >
> > Hi,
> >
> > Thanks for the review Siyuan.
> >
> >
> > Ting,
> >
> > Any comment from your side?
> >
> > Thanks,
> > Meenakshi
> >
> > > -----Original Message-----
> > > From: Fu, Siyuan [mailto:siyuan.fu@intel.com]
> > > Sent: Tuesday, September 26, 2017 6:12 AM
> > > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> > > devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> > > <jaben.carsey@intel.com>
> > > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Ye, Ting
> > > <ting.ye@intel.com>; Udit Kumar <udit.kumar@nxp.com>; Vabhav
> Sharma
> > > <vabhav.sharma@nxp.com>
> > > Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
> > >
> > > Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> > >
> > > -----Original Message-----
> > > From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
> > > Sent: Monday, September 25, 2017 11:06 PM
> > > To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey,
> > > Jaben <jaben.carsey@intel.com>
> > > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Fu, Siyuan
> > > <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>; Meenakshi
> > > Aggarwal <meenakshi.aggarwal@nxp.com>; Udit Kumar
> > > <udit.kumar@nxp.com>; Vabhav Sharma <vabhav.sharma@nxp.com>
> > > Subject: [PATCH v2] TFTP : tftp fix for full volume case
> > >
> > > Issue :
> > > When storage media is full, tftp was resulting in ASSERT
> > > MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages was
> > zero.
> > >
> > > Reason:
> > > While doing tftp, function call ShellWriteFile was modifying FileSize
> variable.
> > > In case of full disk it was coming out to be Zero.
> > >
> > > Fix:
> > > Storage the original filesize in local variable, and use this variable
> > > while freeing the pages.
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
> > > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> > > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > > ---
> > > ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > index 5c50797..fbde3bf 100755
> > > --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > @@ -284,6 +284,7 @@ ShellCommandRunTftp (
> > > EFI_HANDLE Mtftp4ChildHandle;
> > > EFI_MTFTP4_PROTOCOL *Mtftp4;
> > > UINTN FileSize;
> > > + UINTN DataSize;
> > > VOID *Data;
> > > SHELL_FILE_HANDLE FileHandle;
> > > UINT16 BlockSize;
> > > @@ -294,6 +295,7 @@ ShellCommandRunTftp (
> > > AsciiRemoteFilePath = NULL;
> > > Handles = NULL;
> > > FileSize = 0;
> > > + DataSize = 0;
> > > BlockSize = MTFTP_DEFAULT_BLKSIZE;
> > >
> > > //
> > > @@ -537,6 +539,7 @@ ShellCommandRunTftp (
> > > goto NextHandle;
> > > }
> > >
> > > + DataSize = FileSize;
> > > Status = ShellWriteFile (FileHandle, &FileSize, Data);
> > > if (!EFI_ERROR (Status)) {
> > > ShellStatus = SHELL_SUCCESS;
> > > @@ -551,7 +554,7 @@ ShellCommandRunTftp (
> > > NextHandle:
> > >
> > > if (Data != NULL) {
> > > - gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> > > EFI_SIZE_TO_PAGES (FileSize));
> > > + gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> > > + EFI_SIZE_TO_PAGES (DataSize));
> > > }
> > >
> > > CloseProtocolAndDestroyServiceChild (
> > > --
> > > 1.9.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] TFTP : tftp fix for full volume case
2017-10-09 14:13 ` Carsey, Jaben
@ 2017-10-10 5:22 ` Ni, Ruiyu
2017-10-10 13:54 ` Meenakshi Aggarwal
0 siblings, 1 reply; 9+ messages in thread
From: Ni, Ruiyu @ 2017-10-10 5:22 UTC (permalink / raw)
To: Carsey, Jaben, Meenakshi Aggarwal, Fu, Siyuan,
edk2-devel@lists.01.org, Ye, Ting
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: Carsey, Jaben
> Sent: Monday, October 9, 2017 10:13 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Fu, Siyuan
> <siyuan.fu@intel.com>; edk2-devel@lists.01.org; Ni, Ruiyu
> <ruiyu.ni@intel.com>; Ye, Ting <ting.ye@intel.com>
> Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
>
> I am fine. Ray?
>
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Meenakshi Aggarwal
> > Sent: Sunday, October 08, 2017 11:28 PM
> > To: Fu, Siyuan <siyuan.fu@intel.com>; edk2-devel@lists.01.org; Ni,
> > Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>;
> > Ye, Ting <ting.ye@intel.com>
> > Subject: Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case
> > Importance: High
> >
> > Hi Team,
> >
> >
> > Any further comments on this patch?
> >
> > Or is it ready to merge in edk2?
> >
> >
> > Thanks,
> > Meenakshi
> >
> > > -----Original Message-----
> > > From: Meenakshi Aggarwal
> > > Sent: Wednesday, September 27, 2017 9:01 AM
> > > To: 'Fu, Siyuan' <siyuan.fu@intel.com>; edk2-devel@lists.01.org; Ni,
> > > Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>;
> > > Ye, Ting <ting.ye@intel.com>
> > > Cc: Udit Kumar <udit.kumar@nxp.com>; Vabhav Sharma
> > > <vabhav.sharma@nxp.com>
> > > Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
> > >
> > > Hi,
> > >
> > > Thanks for the review Siyuan.
> > >
> > >
> > > Ting,
> > >
> > > Any comment from your side?
> > >
> > > Thanks,
> > > Meenakshi
> > >
> > > > -----Original Message-----
> > > > From: Fu, Siyuan [mailto:siyuan.fu@intel.com]
> > > > Sent: Tuesday, September 26, 2017 6:12 AM
> > > > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> > > > devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> > > > <jaben.carsey@intel.com>
> > > > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Ye, Ting
> > > > <ting.ye@intel.com>; Udit Kumar <udit.kumar@nxp.com>; Vabhav
> > Sharma
> > > > <vabhav.sharma@nxp.com>
> > > > Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
> > > >
> > > > Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> > > >
> > > > -----Original Message-----
> > > > From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
> > > > Sent: Monday, September 25, 2017 11:06 PM
> > > > To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>;
> > > > Carsey, Jaben <jaben.carsey@intel.com>
> > > > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Fu,
> > > > Siyuan <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>;
> > > > Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Udit Kumar
> > > > <udit.kumar@nxp.com>; Vabhav Sharma <vabhav.sharma@nxp.com>
> > > > Subject: [PATCH v2] TFTP : tftp fix for full volume case
> > > >
> > > > Issue :
> > > > When storage media is full, tftp was resulting in ASSERT
> > > > MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages was
> > > zero.
> > > >
> > > > Reason:
> > > > While doing tftp, function call ShellWriteFile was modifying
> > > > FileSize
> > variable.
> > > > In case of full disk it was coming out to be Zero.
> > > >
> > > > Fix:
> > > > Storage the original filesize in local variable, and use this
> > > > variable while freeing the pages.
> > > >
> > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
> > > > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > > > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> > > > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > > > ---
> > > > ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 5 ++++-
> > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > index 5c50797..fbde3bf 100755
> > > > --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > @@ -284,6 +284,7 @@ ShellCommandRunTftp (
> > > > EFI_HANDLE Mtftp4ChildHandle;
> > > > EFI_MTFTP4_PROTOCOL *Mtftp4;
> > > > UINTN FileSize;
> > > > + UINTN DataSize;
> > > > VOID *Data;
> > > > SHELL_FILE_HANDLE FileHandle;
> > > > UINT16 BlockSize;
> > > > @@ -294,6 +295,7 @@ ShellCommandRunTftp (
> > > > AsciiRemoteFilePath = NULL;
> > > > Handles = NULL;
> > > > FileSize = 0;
> > > > + DataSize = 0;
> > > > BlockSize = MTFTP_DEFAULT_BLKSIZE;
> > > >
> > > > //
> > > > @@ -537,6 +539,7 @@ ShellCommandRunTftp (
> > > > goto NextHandle;
> > > > }
> > > >
> > > > + DataSize = FileSize;
> > > > Status = ShellWriteFile (FileHandle, &FileSize, Data);
> > > > if (!EFI_ERROR (Status)) {
> > > > ShellStatus = SHELL_SUCCESS; @@ -551,7 +554,7 @@
> > > > ShellCommandRunTftp (
> > > > NextHandle:
> > > >
> > > > if (Data != NULL) {
> > > > - gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> > > > EFI_SIZE_TO_PAGES (FileSize));
> > > > + gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> > > > + EFI_SIZE_TO_PAGES (DataSize));
> > > > }
> > > >
> > > > CloseProtocolAndDestroyServiceChild (
> > > > --
> > > > 1.9.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] TFTP : tftp fix for full volume case
2017-10-10 5:22 ` Ni, Ruiyu
@ 2017-10-10 13:54 ` Meenakshi Aggarwal
0 siblings, 0 replies; 9+ messages in thread
From: Meenakshi Aggarwal @ 2017-10-10 13:54 UTC (permalink / raw)
To: Ni, Ruiyu, Carsey, Jaben, Fu, Siyuan, edk2-devel@lists.01.org,
Ye, Ting
Hi,
Kindly apply this patch on edk2 if all reviews are done.
Thanks & Regards,
Meenakshi
> -----Original Message-----
> From: Ni, Ruiyu [mailto:ruiyu.ni@intel.com]
> Sent: Tuesday, October 10, 2017 10:52 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; Fu, Siyuan <siyuan.fu@intel.com>; edk2-
> devel@lists.01.org; Ye, Ting <ting.ye@intel.com>
> Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>
> Thanks/Ray
>
> > -----Original Message-----
> > From: Carsey, Jaben
> > Sent: Monday, October 9, 2017 10:13 PM
> > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Fu, Siyuan
> > <siyuan.fu@intel.com>; edk2-devel@lists.01.org; Ni, Ruiyu
> > <ruiyu.ni@intel.com>; Ye, Ting <ting.ye@intel.com>
> > Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
> >
> > I am fine. Ray?
> >
> > Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> > > Of Meenakshi Aggarwal
> > > Sent: Sunday, October 08, 2017 11:28 PM
> > > To: Fu, Siyuan <siyuan.fu@intel.com>; edk2-devel@lists.01.org; Ni,
> > > Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>;
> > > Ye, Ting <ting.ye@intel.com>
> > > Subject: Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case
> > > Importance: High
> > >
> > > Hi Team,
> > >
> > >
> > > Any further comments on this patch?
> > >
> > > Or is it ready to merge in edk2?
> > >
> > >
> > > Thanks,
> > > Meenakshi
> > >
> > > > -----Original Message-----
> > > > From: Meenakshi Aggarwal
> > > > Sent: Wednesday, September 27, 2017 9:01 AM
> > > > To: 'Fu, Siyuan' <siyuan.fu@intel.com>; edk2-devel@lists.01.org;
> > > > Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> > > > <jaben.carsey@intel.com>; Ye, Ting <ting.ye@intel.com>
> > > > Cc: Udit Kumar <udit.kumar@nxp.com>; Vabhav Sharma
> > > > <vabhav.sharma@nxp.com>
> > > > Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
> > > >
> > > > Hi,
> > > >
> > > > Thanks for the review Siyuan.
> > > >
> > > >
> > > > Ting,
> > > >
> > > > Any comment from your side?
> > > >
> > > > Thanks,
> > > > Meenakshi
> > > >
> > > > > -----Original Message-----
> > > > > From: Fu, Siyuan [mailto:siyuan.fu@intel.com]
> > > > > Sent: Tuesday, September 26, 2017 6:12 AM
> > > > > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> > > > > devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey,
> > > > > Jaben <jaben.carsey@intel.com>
> > > > > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Ye,
> > > > > Ting <ting.ye@intel.com>; Udit Kumar <udit.kumar@nxp.com>;
> > > > > Vabhav
> > > Sharma
> > > > > <vabhav.sharma@nxp.com>
> > > > > Subject: RE: [PATCH v2] TFTP : tftp fix for full volume case
> > > > >
> > > > > Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> > > > >
> > > > > -----Original Message-----
> > > > > From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
> > > > > Sent: Monday, September 25, 2017 11:06 PM
> > > > > To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>;
> > > > > Carsey, Jaben <jaben.carsey@intel.com>
> > > > > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Fu,
> > > > > Siyuan <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>;
> > > > > Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Udit Kumar
> > > > > <udit.kumar@nxp.com>; Vabhav Sharma
> <vabhav.sharma@nxp.com>
> > > > > Subject: [PATCH v2] TFTP : tftp fix for full volume case
> > > > >
> > > > > Issue :
> > > > > When storage media is full, tftp was resulting in ASSERT
> > > > > MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages
> was
> > > > zero.
> > > > >
> > > > > Reason:
> > > > > While doing tftp, function call ShellWriteFile was modifying
> > > > > FileSize
> > > variable.
> > > > > In case of full disk it was coming out to be Zero.
> > > > >
> > > > > Fix:
> > > > > Storage the original filesize in local variable, and use this
> > > > > variable while freeing the pages.
> > > > >
> > > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > > Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
> > > > > Signed-off-by: Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>
> > > > > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> > > > > Signed-off-by: Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>
> > > > > ---
> > > > > ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 5 ++++-
> > > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > > b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > > index 5c50797..fbde3bf 100755
> > > > > --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > > +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> > > > > @@ -284,6 +284,7 @@ ShellCommandRunTftp (
> > > > > EFI_HANDLE Mtftp4ChildHandle;
> > > > > EFI_MTFTP4_PROTOCOL *Mtftp4;
> > > > > UINTN FileSize;
> > > > > + UINTN DataSize;
> > > > > VOID *Data;
> > > > > SHELL_FILE_HANDLE FileHandle;
> > > > > UINT16 BlockSize;
> > > > > @@ -294,6 +295,7 @@ ShellCommandRunTftp (
> > > > > AsciiRemoteFilePath = NULL;
> > > > > Handles = NULL;
> > > > > FileSize = 0;
> > > > > + DataSize = 0;
> > > > > BlockSize = MTFTP_DEFAULT_BLKSIZE;
> > > > >
> > > > > //
> > > > > @@ -537,6 +539,7 @@ ShellCommandRunTftp (
> > > > > goto NextHandle;
> > > > > }
> > > > >
> > > > > + DataSize = FileSize;
> > > > > Status = ShellWriteFile (FileHandle, &FileSize, Data);
> > > > > if (!EFI_ERROR (Status)) {
> > > > > ShellStatus = SHELL_SUCCESS; @@ -551,7 +554,7 @@
> > > > > ShellCommandRunTftp (
> > > > > NextHandle:
> > > > >
> > > > > if (Data != NULL) {
> > > > > - gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> > > > > EFI_SIZE_TO_PAGES (FileSize));
> > > > > + gBS->FreePages ((EFI_PHYSICAL_ADDRESS)(UINTN)Data,
> > > > > + EFI_SIZE_TO_PAGES (DataSize));
> > > > > }
> > > > >
> > > > > CloseProtocolAndDestroyServiceChild (
> > > > > --
> > > > > 1.9.1
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-10-10 13:50 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-25 14:37 [PATCH] TFTP : tftp fix for full volume case Meenakshi Aggarwal
2017-09-25 9:00 ` Ni, Ruiyu
2017-09-25 15:06 ` [PATCH v2] " Meenakshi Aggarwal
2017-09-26 0:42 ` Fu, Siyuan
2017-09-27 3:31 ` Meenakshi Aggarwal
2017-10-09 6:28 ` Meenakshi Aggarwal
2017-10-09 14:13 ` Carsey, Jaben
2017-10-10 5:22 ` Ni, Ruiyu
2017-10-10 13:54 ` Meenakshi Aggarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox