* [PATCH] MdeModulePkg PeiCore: More debug messages for pre-memory allocations
@ 2017-09-29 6:43 Star Zeng
2017-09-29 6:53 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Star Zeng @ 2017-09-29 6:43 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Liming Gao, Qing Huang
The debug messages can help developer to know the pre-memory
allocation usage.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Qing Huang <qing.huang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
index 04ece9a627d5..38299c5d98c6 100644
--- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
+++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
@@ -675,7 +675,8 @@ PeiCheckAndSwitchStack (
// usage in temporary memory for debugging.
//
DEBUG_CODE_BEGIN ();
- UINT32 *StackPointer;
+ UINT32 *StackPointer;
+ EFI_PEI_HOB_POINTERS Hob;
for (StackPointer = (UINT32*)SecCoreData->StackBase;
(StackPointer < (UINT32*)((UINTN)SecCoreData->StackBase + SecCoreData->StackSize)) \
@@ -691,6 +692,17 @@ PeiCheckAndSwitchStack (
DEBUG ((DEBUG_INFO, " temporary memory heap used for HobList: %d bytes.\n",
(UINT32)((UINTN)Private->HobList.HandoffInformationTable->EfiFreeMemoryBottom - (UINTN)Private->HobList.Raw)
));
+ DEBUG ((DEBUG_INFO, " temporary memory heap occupied by memory pages: %d bytes.\n",
+ (UINT32)(UINTN)(Private->HobList.HandoffInformationTable->EfiMemoryTop - Private->HobList.HandoffInformationTable->EfiFreeMemoryTop)
+ ));
+ for (Hob.Raw = Private->HobList.Raw; !END_OF_HOB_LIST(Hob); Hob.Raw = GET_NEXT_HOB(Hob)) {
+ if (GET_HOB_TYPE (Hob) == EFI_HOB_TYPE_MEMORY_ALLOCATION) {
+ DEBUG ((DEBUG_INFO, "Memory Allocation 0x%08x 0x%0lx - 0x%0lx\n", \
+ Hob.MemoryAllocation->AllocDescriptor.MemoryType, \
+ Hob.MemoryAllocation->AllocDescriptor.MemoryBaseAddress, \
+ Hob.MemoryAllocation->AllocDescriptor.MemoryBaseAddress + Hob.MemoryAllocation->AllocDescriptor.MemoryLength - 1));
+ }
+ }
DEBUG_CODE_END ();
if (PcdGet64(PcdLoadModuleAtFixAddressEnable) != 0 && (Private->HobList.HandoffInformationTable->BootMode != BOOT_ON_S3_RESUME)) {
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] MdeModulePkg PeiCore: More debug messages for pre-memory allocations
2017-09-29 6:43 [PATCH] MdeModulePkg PeiCore: More debug messages for pre-memory allocations Star Zeng
@ 2017-09-29 6:53 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2017-09-29 6:53 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Zeng, Star
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star
>Zeng
>Sent: Friday, September 29, 2017 2:44 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [PATCH] MdeModulePkg PeiCore: More debug messages for
>pre-memory allocations
>
>The debug messages can help developer to know the pre-memory
>allocation usage.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Qing Huang <qing.huang@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
>diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
>b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
>index 04ece9a627d5..38299c5d98c6 100644
>--- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
>+++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
>@@ -675,7 +675,8 @@ PeiCheckAndSwitchStack (
> // usage in temporary memory for debugging.
> //
> DEBUG_CODE_BEGIN ();
>- UINT32 *StackPointer;
>+ UINT32 *StackPointer;
>+ EFI_PEI_HOB_POINTERS Hob;
>
> for (StackPointer = (UINT32*)SecCoreData->StackBase;
> (StackPointer < (UINT32*)((UINTN)SecCoreData->StackBase +
>SecCoreData->StackSize)) \
>@@ -691,6 +692,17 @@ PeiCheckAndSwitchStack (
> DEBUG ((DEBUG_INFO, " temporary memory heap used for HobList: %d
>bytes.\n",
> (UINT32)((UINTN)Private->HobList.HandoffInformationTable-
>>EfiFreeMemoryBottom - (UINTN)Private->HobList.Raw)
> ));
>+ DEBUG ((DEBUG_INFO, " temporary memory heap occupied by memory
>pages: %d bytes.\n",
>+ (UINT32)(UINTN)(Private->HobList.HandoffInformationTable-
>>EfiMemoryTop - Private->HobList.HandoffInformationTable-
>>EfiFreeMemoryTop)
>+ ));
>+ for (Hob.Raw = Private->HobList.Raw; !END_OF_HOB_LIST(Hob);
>Hob.Raw = GET_NEXT_HOB(Hob)) {
>+ if (GET_HOB_TYPE (Hob) == EFI_HOB_TYPE_MEMORY_ALLOCATION) {
>+ DEBUG ((DEBUG_INFO, "Memory Allocation 0x%08x 0x%0lx - 0x%0lx\n",
>\
>+ Hob.MemoryAllocation->AllocDescriptor.MemoryType, \
>+ Hob.MemoryAllocation->AllocDescriptor.MemoryBaseAddress, \
>+ Hob.MemoryAllocation->AllocDescriptor.MemoryBaseAddress +
>Hob.MemoryAllocation->AllocDescriptor.MemoryLength - 1));
>+ }
>+ }
> DEBUG_CODE_END ();
>
> if (PcdGet64(PcdLoadModuleAtFixAddressEnable) != 0 && (Private-
>>HobList.HandoffInformationTable->BootMode != BOOT_ON_S3_RESUME)) {
>--
>2.7.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-29 6:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-29 6:43 [PATCH] MdeModulePkg PeiCore: More debug messages for pre-memory allocations Star Zeng
2017-09-29 6:53 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox