public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
To: <edk2-devel@lists.01.org>, <jiaxin.wu@intel.com>,
	<jaben.carsey@intel.com>, <ruiyu.ni@intel.com>
Subject: [PATCH v2] Ifconfig : Fixed False information about Media State.
Date: Fri, 6 Oct 2017 10:10:09 +0530	[thread overview]
Message-ID: <1507264809-19123-1-git-send-email-meenakshi.aggarwal@nxp.com> (raw)
In-Reply-To: <1507185391-6076-1-git-send-email-meenakshi.aggarwal@nxp.com>

Issue : We were setting MediaPresent as TRUE (default), so
even if NetLibDetectMedia() did not set MediaPresent Flag as TRUE,
ifconfig always display Media State as 'Media Present'

Fix : Set MediaPresent as FALSE before calling NetLibDetectMedia()

Contributed-under: TianoCore Contribution Agreement 1.1

Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
---
 ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
index 4db07b2..90ca724 100644
--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
@@ -576,11 +576,14 @@ IfConfigShowInterfaceInfo (
     //
     // Get Media State.
     //
-    NetLibDetectMedia (IfCb->NicHandle, &MediaPresent);
-    if (!MediaPresent) {
-      ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG_INFO_MEDIA_STATE), gShellNetwork1HiiHandle, L"Media disconnected");
+    if (EFI_SUCCESS == NetLibDetectMedia (IfCb->NicHandle, &MediaPresent)) {
+      if (!MediaPresent) {
+        ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG_INFO_MEDIA_STATE), gShellNetwork1HiiHandle, L"Media disconnected");
+      } else {
+        ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG_INFO_MEDIA_STATE), gShellNetwork1HiiHandle, L"Media present");
+      }
     } else {
-      ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG_INFO_MEDIA_STATE), gShellNetwork1HiiHandle, L"Media present");
+      ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG_INFO_MEDIA_STATE), gShellNetwork1HiiHandle, L"Media disconnected");
     }
 
     //
-- 
2.7.4



  parent reply	other threads:[~2017-10-06  4:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05  6:36 [PATCH] Ifconfig : Fixed False information about Media State Meenakshi Aggarwal
2017-10-05 15:01 ` Carsey, Jaben
2017-10-05 17:10   ` Meenakshi Aggarwal
2017-10-05 20:26     ` Carsey, Jaben
2017-10-06  4:21       ` Meenakshi Aggarwal
2017-10-06  4:40 ` Meenakshi Aggarwal [this message]
2017-10-06  4:48   ` [PATCH v3] *** Ifconfig : Fixed False information about Media State *** Meenakshi Aggarwal
2017-10-06  4:48     ` [PATCH v3] Ifconfig : Fixed False information about Media State Meenakshi Aggarwal
2017-10-06 14:01       ` Carsey, Jaben
2017-10-08  8:49         ` Meenakshi Aggarwal
2017-10-09  1:29           ` Wu, Jiaxin
2017-10-09  2:09             ` Ni, Ruiyu
2017-10-09  3:21               ` Wu, Jiaxin
2017-10-10 14:07       ` [PATCH v4] " Meenakshi Aggarwal
2017-10-11  0:47         ` Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507264809-19123-1-git-send-email-meenakshi.aggarwal@nxp.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox