From: Dandan Bi <dandan.bi@intel.com>
To: edk2-devel@lists.01.org
Cc: Jian J Wang <jian.j.wang@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: [patch 2/4] IntelFrameworkModule/LegacyBios: Avoid explicit comparison for BOOLEAN
Date: Fri, 20 Oct 2017 08:59:51 +0800 [thread overview]
Message-ID: <1508461193-5204-3-git-send-email-dandan.bi@intel.com> (raw)
In-Reply-To: <1508461193-5204-1-git-send-email-dandan.bi@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c
index e009999..c6461f5 100644
--- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c
+++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c
@@ -804,11 +804,11 @@ EnableNullDetection (
EFI_STATUS Status;
EFI_GCD_MEMORY_SPACE_DESCRIPTOR Desc;
if (((PcdGet8 (PcdNullPointerDetectionPropertyMask) & BIT0) == 0)
||
- ((mEndOfDxe == TRUE) &&
+ ((mEndOfDxe) &&
((PcdGet8 (PcdNullPointerDetectionPropertyMask) & (BIT7|BIT0))
== (BIT7|BIT0)))
) {
return;
}
@@ -854,11 +854,11 @@ DisableNullDetection (
EFI_STATUS Status;
EFI_GCD_MEMORY_SPACE_DESCRIPTOR Desc;
if (((PcdGet8 (PcdNullPointerDetectionPropertyMask) & BIT0) == 0)
||
- ((mEndOfDxe == TRUE) &&
+ ((mEndOfDxe) &&
((PcdGet8 (PcdNullPointerDetectionPropertyMask) & (BIT7|BIT0))
== (BIT7|BIT0)))
) {
return;
}
--
1.9.5.msysgit.1
next prev parent reply other threads:[~2017-10-20 0:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 0:59 [patch 0/4] Fix coding style issue Dandan Bi
2017-10-20 0:59 ` [patch 1/4] IntelFrameworkModulePkg/Csm: Refine coding style in comments Dandan Bi
2017-10-23 1:19 ` Wang, Jian J
2017-10-20 0:59 ` Dandan Bi [this message]
2017-10-23 1:19 ` [patch 2/4] IntelFrameworkModule/LegacyBios: Avoid explicit comparison for BOOLEAN Wang, Jian J
2017-10-20 0:59 ` [patch 3/4] MdeModulePkg/DxeIplPeim: Refine coding style in function comments Dandan Bi
2017-10-23 1:20 ` Wang, Jian J
2017-10-20 0:59 ` [patch 4/4] UefiCpuPkg/MtrrLib: Make comments align with function Dandan Bi
2017-10-20 2:08 ` Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508461193-5204-3-git-send-email-dandan.bi@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox