public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] IntelSiliconPkg/VtdInfoSample: Fix IGD RMRR memory.
@ 2017-10-20  8:51 Jiewen Yao
  2017-10-20  9:06 ` Yao, Jiewen
  0 siblings, 1 reply; 3+ messages in thread
From: Jiewen Yao @ 2017-10-20  8:51 UTC (permalink / raw)
  To: edk2-devel; +Cc: Zeng Star

Fix a calculation problem in IGD RMRR memory.

Cc: Zeng Star <zeng.star@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
 IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c b/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c
index 08a4db3..6267da7 100644
--- a/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c
+++ b/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c
@@ -159,7 +159,7 @@ PatchDmar (
   /// Calculate GTT mem size
   ///
   GttMemSize = 0;
-  GttMode = PciRead16 (PCI_LIB_ADDRESS(0, 0, 0, R_SA_GGC) & B_SKL_SA_GGC_GGMS_MASK) >> N_SKL_SA_GGC_GGMS_OFFSET;
+  GttMode = (PciRead16 (PCI_LIB_ADDRESS(0, 0, 0, R_SA_GGC)) & B_SKL_SA_GGC_GGMS_MASK) >> N_SKL_SA_GGC_GGMS_OFFSET;
   if (GttMode <= V_SKL_SA_GGC_GGMS_8MB) {
     GttMemSize = (1 << GttMode) * (1024) * (1024);
   }
-- 
2.7.4.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] IntelSiliconPkg/VtdInfoSample: Fix IGD RMRR memory.
  2017-10-20  8:51 [PATCH] IntelSiliconPkg/VtdInfoSample: Fix IGD RMRR memory Jiewen Yao
@ 2017-10-20  9:06 ` Yao, Jiewen
  2017-10-24  2:22   ` Zeng, Star
  0 siblings, 1 reply; 3+ messages in thread
From: Yao, Jiewen @ 2017-10-20  9:06 UTC (permalink / raw)
  To: edk2-devel@lists.01.org, Zeng, Star

Correct email address

thank you!
Yao, Jiewen


> 在 2017年10月20日，下午4:51，Jiewen Yao <jiewen.yao@intel.com> 写道：
> 
> Fix a calculation problem in IGD RMRR memory.
> 
> Cc: Zeng Star <zeng.star@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
> IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c b/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c
> index 08a4db3..6267da7 100644
> --- a/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c
> +++ b/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c
> @@ -159,7 +159,7 @@ PatchDmar (
>   /// Calculate GTT mem size
>   ///
>   GttMemSize = 0;
> -  GttMode = PciRead16 (PCI_LIB_ADDRESS(0, 0, 0, R_SA_GGC) & B_SKL_SA_GGC_GGMS_MASK) >> N_SKL_SA_GGC_GGMS_OFFSET;
> +  GttMode = (PciRead16 (PCI_LIB_ADDRESS(0, 0, 0, R_SA_GGC)) & B_SKL_SA_GGC_GGMS_MASK) >> N_SKL_SA_GGC_GGMS_OFFSET;
>   if (GttMode <= V_SKL_SA_GGC_GGMS_8MB) {
>     GttMemSize = (1 << GttMode) * (1024) * (1024);
>   }
> -- 
> 2.7.4.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] IntelSiliconPkg/VtdInfoSample: Fix IGD RMRR memory.
  2017-10-20  9:06 ` Yao, Jiewen
@ 2017-10-24  2:22   ` Zeng, Star
  0 siblings, 0 replies; 3+ messages in thread
From: Zeng, Star @ 2017-10-24  2:22 UTC (permalink / raw)
  To: Yao, Jiewen, edk2-devel@lists.01.org; +Cc: Zeng, Star

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: Yao, Jiewen 
Sent: Friday, October 20, 2017 5:07 PM
To: edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>
Subject: Re: [edk2] [PATCH] IntelSiliconPkg/VtdInfoSample: Fix IGD RMRR memory.

Correct email address

thank you!
Yao, Jiewen


> 在 2017年10月20日，下午4:51，Jiewen Yao <jiewen.yao@intel.com> 写道：
> 
> Fix a calculation problem in IGD RMRR memory.
> 
> Cc: Zeng Star <zeng.star@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
> IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c b/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c
> index 08a4db3..6267da7 100644
> --- a/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c
> +++ b/IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c
> @@ -159,7 +159,7 @@ PatchDmar (
>   /// Calculate GTT mem size
>   ///
>   GttMemSize = 0;
> -  GttMode = PciRead16 (PCI_LIB_ADDRESS(0, 0, 0, R_SA_GGC) & B_SKL_SA_GGC_GGMS_MASK) >> N_SKL_SA_GGC_GGMS_OFFSET;
> +  GttMode = (PciRead16 (PCI_LIB_ADDRESS(0, 0, 0, R_SA_GGC)) & B_SKL_SA_GGC_GGMS_MASK) >> N_SKL_SA_GGC_GGMS_OFFSET;
>   if (GttMode <= V_SKL_SA_GGC_GGMS_8MB) {
>     GttMemSize = (1 << GttMode) * (1024) * (1024);
>   }
> -- 
> 2.7.4.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-24  2:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-20  8:51 [PATCH] IntelSiliconPkg/VtdInfoSample: Fix IGD RMRR memory Jiewen Yao
2017-10-20  9:06 ` Yao, Jiewen
2017-10-24  2:22   ` Zeng, Star

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox