* [PATCH] IntelSiliconPkg IntelVTdDxe: use gEfiAcpi10TableGuid for ACPI 1.0
@ 2017-10-25 8:59 Star Zeng
2017-10-25 9:58 ` Yao, Jiewen
0 siblings, 1 reply; 2+ messages in thread
From: Star Zeng @ 2017-10-25 8:59 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Jiewen Yao
According to definition (Acpi.h and MdePkg.dec),
gEfiAcpiTableGuid = gEfiAcpi20TableGuid, and the code is trying
to parse ACPI 2.0 first and then ACPI 1.0, but it uses
gEfiAcpiTableGuid wrongly for ACPI 1.0, this patch is to fix it.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c | 2 +-
IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
index 2456b0c48ff1..39b70a134e1e 100644
--- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
+++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
@@ -996,7 +996,7 @@ GetDmarAcpiTable (
);
if (EFI_ERROR (Status)) {
Status = EfiGetSystemConfigurationTable (
- &gEfiAcpiTableGuid,
+ &gEfiAcpi10TableGuid,
&AcpiTable
);
}
diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf
index d45fd67964c9..fde33bb224ca 100644
--- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf
+++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf
@@ -64,7 +64,7 @@ [LibraryClasses]
[Guids]
gEfiEventExitBootServicesGuid ## CONSUMES ## Event
gEfiAcpi20TableGuid ## CONSUMES ## SystemTable
- gEfiAcpiTableGuid ## CONSUMES ## SystemTable
+ gEfiAcpi10TableGuid ## CONSUMES ## SystemTable
[Protocols]
gEdkiiIoMmuProtocolGuid ## PRODUCES
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] IntelSiliconPkg IntelVTdDxe: use gEfiAcpi10TableGuid for ACPI 1.0
2017-10-25 8:59 [PATCH] IntelSiliconPkg IntelVTdDxe: use gEfiAcpi10TableGuid for ACPI 1.0 Star Zeng
@ 2017-10-25 9:58 ` Yao, Jiewen
0 siblings, 0 replies; 2+ messages in thread
From: Yao, Jiewen @ 2017-10-25 9:58 UTC (permalink / raw)
To: Zeng, Star; +Cc: edk2-devel@lists.01.org
reviewed by: jiewen.yao@intel.com
thank you!
Yao, Jiewen
> 在 2017年10月25日，下午4:59，Star Zeng <star.zeng@intel.com> 写道：
>
> According to definition (Acpi.h and MdePkg.dec),
> gEfiAcpiTableGuid = gEfiAcpi20TableGuid, and the code is trying
> to parse ACPI 2.0 first and then ACPI 1.0, but it uses
> gEfiAcpiTableGuid wrongly for ACPI 1.0, this patch is to fix it.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c | 2 +-
> IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
> index 2456b0c48ff1..39b70a134e1e 100644
> --- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
> +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
> @@ -996,7 +996,7 @@ GetDmarAcpiTable (
> );
> if (EFI_ERROR (Status)) {
> Status = EfiGetSystemConfigurationTable (
> - &gEfiAcpiTableGuid,
> + &gEfiAcpi10TableGuid,
> &AcpiTable
> );
> }
> diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf
> index d45fd67964c9..fde33bb224ca 100644
> --- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf
> +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf
> @@ -64,7 +64,7 @@ [LibraryClasses]
> [Guids]
> gEfiEventExitBootServicesGuid ## CONSUMES ## Event
> gEfiAcpi20TableGuid ## CONSUMES ## SystemTable
> - gEfiAcpiTableGuid ## CONSUMES ## SystemTable
> + gEfiAcpi10TableGuid ## CONSUMES ## SystemTable
>
> [Protocols]
> gEdkiiIoMmuProtocolGuid ## PRODUCES
> --
> 2.7.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-25 9:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-25 8:59 [PATCH] IntelSiliconPkg IntelVTdDxe: use gEfiAcpi10TableGuid for ACPI 1.0 Star Zeng
2017-10-25 9:58 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox