From: Marcin Wojtas <mw@semihalf.com>
To: edk2-devel@lists.01.org
Cc: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org,
nadavh@marvell.com, neta@marvell.com, kostap@marvell.com,
jinghua@marvell.com, mw@semihalf.com, jsd@semihalf.com
Subject: [platforms: PATCH 10/10] Marvell/Drivers: XenonDxe: Do not modify FIFO default values
Date: Thu, 26 Oct 2017 03:19:37 +0200 [thread overview]
Message-ID: <1508980777-29006-11-git-send-email-mw@semihalf.com> (raw)
In-Reply-To: <1508980777-29006-1-git-send-email-mw@semihalf.com>
Changing controller's FIFO default values is not necessary and
possibly can cause instabilities, when using some devices.
Disable the modification and rely on initial settings.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
Platform/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/Platform/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c b/Platform/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c
index 31f207e..6bbe5bc 100755
--- a/Platform/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c
+++ b/Platform/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c
@@ -44,20 +44,6 @@ XenonReadVersion (
SdMmcHcRwMmio (PciIo, SD_BAR_INDEX, SD_MMC_HC_CTRL_VER, TRUE, SDHC_REG_SIZE_2B, ControllerVersion);
}
-STATIC
-VOID
-XenonSetFifo (
- IN EFI_PCI_IO_PROTOCOL *PciIo
- )
-{
- UINTN Data;
-
- // Set FIFO_RTC, FIFO_WTC, FIFO_CS and FIFO_PDLVMC
- Data = SDHC_SLOT_FIFO_DEFAULT_CONFIG;
-
- SdMmcHcRwMmio (PciIo, SD_BAR_INDEX, SDHC_SLOT_FIFO_CTRL, FALSE, SDHC_REG_SIZE_4B, &Data);
-}
-
// Auto Clock Gating
STATIC
VOID
@@ -634,8 +620,6 @@ XenonInit (
// Read XENON version
XenonReadVersion (PciIo, &Private->ControllerVersion);
- XenonSetFifo (PciIo);
-
// Disable auto clock generator
XenonSetAcg (PciIo, FALSE);
--
2.7.4
next prev parent reply other threads:[~2017-10-26 1:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 1:19 [platforms: PATCH 00/10] Armada 7k/8k - misc improvements pt.2 Marcin Wojtas
2017-10-26 1:19 ` [platforms: PATCH 01/10] Marvell/Drivers: MvI2cDxe: Abort transaction immediately upon fail Marcin Wojtas
2017-10-26 12:51 ` Leif Lindholm
2017-10-26 13:19 ` Marcin Wojtas
2017-10-26 13:54 ` Leif Lindholm
2017-10-26 13:55 ` Marcin Wojtas
2017-10-26 1:19 ` [platforms: PATCH 02/10] Marvell/Drivers: MvI2cDxe: Fix returning status in MvI2cStartRequest Marcin Wojtas
2017-10-26 13:11 ` Leif Lindholm
2017-10-26 13:22 ` Marcin Wojtas
2017-10-26 13:55 ` Leif Lindholm
2017-10-26 1:19 ` [platforms: PATCH 03/10] Marvell/Drivers: MvI2cDxe: Reduce bus occupation time Marcin Wojtas
2017-10-26 13:13 ` Leif Lindholm
2017-10-26 1:19 ` [platforms: PATCH 04/10] Marvell/Library: MppLib: Prevent overwriting PCD values Marcin Wojtas
2017-10-26 13:15 ` Leif Lindholm
2017-10-26 1:19 ` [platforms: PATCH 05/10] Marvell/Library: MppLib: Disable the stack protector Marcin Wojtas
2017-10-26 13:26 ` Leif Lindholm
2017-10-26 13:29 ` Ard Biesheuvel
2017-10-26 13:57 ` Leif Lindholm
2017-10-26 1:19 ` [platforms: PATCH 06/10] Marvell/Library: MppLib: Take 0xFF placeholders into account Marcin Wojtas
2017-10-26 13:30 ` Leif Lindholm
2017-10-26 1:19 ` [platforms: PATCH 07/10] Marvell/Drivers: Pp2Dxe: Change settings for the always-up link Marcin Wojtas
2017-10-26 13:38 ` Leif Lindholm
2017-10-26 1:19 ` [platforms: PATCH 08/10] Marvell/Drivers: XenonDxe: Fix UHS signalling mode setting Marcin Wojtas
2017-10-26 13:41 ` Leif Lindholm
2017-10-26 1:19 ` [platforms: PATCH 09/10] Marvell/Drivers: XenonDxe: Fix base clock frequency Marcin Wojtas
2017-10-26 13:46 ` Leif Lindholm
2017-10-26 13:54 ` Marcin Wojtas
2017-10-26 13:55 ` Ard Biesheuvel
2017-10-26 13:59 ` Marcin Wojtas
2017-10-26 14:02 ` Leif Lindholm
2017-10-26 14:29 ` Marcin Wojtas
2017-10-26 14:52 ` Leif Lindholm
2017-10-26 15:07 ` Marcin Wojtas
2017-10-26 1:19 ` Marcin Wojtas [this message]
2017-10-26 13:47 ` [platforms: PATCH 10/10] Marvell/Drivers: XenonDxe: Do not modify FIFO default values Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508980777-29006-11-git-send-email-mw@semihalf.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox