public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ming Huang <heyi.guo@linaro.org>
To: leif.lindholm@linaro.org, linaro-uefi@lists.linaro.org,
	edk2-devel@lists.01.org, graeme.gregory@linaro.org
Cc: ard.biesheuvel@linaro.org, guoheyi@huawei.com,
	wanghuiqiang@huawei.com, huangming23@huawei.com,
	zhangjinsong2@huawei.com, mengfanrong@huawei.com, waip23@126.com,
	Liu Yi <liuyi86@huawei.com>, Heyi Guo <heyi.guo@linaro.org>
Subject: [PATCH edk2-non-osi v2] Hisilicon D0x: Remove uncacheable attribute from memory resource HOB
Date: Fri, 10 Nov 2017 15:31:32 +0800	[thread overview]
Message-ID: <1510299092-38746-2-git-send-email-huangming23@huawei.com> (raw)
In-Reply-To: <1510299092-38746-1-git-send-email-huangming23@huawei.com>

If uncacheable attribute is included in memory resource HOB,
GCD spaces will also have EFI_MEMORY_UC capability,
then NonCoherentPciIoAllocateBuffer of NonDiscoverablePciDeviceDxe
module will allocate DMA buffer of EFI_MEMORY_UC type, which will
cause alignment fault exception with BaseMemoryLibOptDxe.

This not only affects NonDiscoverablePciDeviceDxe, it removes the
UC attribute from all DRAM regions in the UEFI memory map,
which makes much more sense on ARM

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liu Yi <liuyi86@huawei.com>
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
---
 Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi | Bin 90272 -> 90336 bytes
 Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi | Bin 152576 -> 152480 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi
index 354abcc..31e2903 100644
Binary files a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi differ
diff --git a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi
index b94e0cb..eb71c44 100644
Binary files a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi differ
-- 
1.9.1



  reply	other threads:[~2017-11-10  7:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10  7:31 [PATCH edk2-non-osi v2] Update D03/D05 MemoryInit.efi binary for bug 3419 Ming Huang
2017-11-10  7:31 ` Ming Huang [this message]
2017-11-13 10:15   ` [PATCH edk2-non-osi v2] Hisilicon D0x: Remove uncacheable attribute from memory resource HOB Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510299092-38746-2-git-send-email-huangming23@huawei.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox