Re: [PATCH 2/4] OvmfPkg/Sec/Ia32: seed the temporary RAM with PcdInitValueInTempStack

[Jordan Justen <jordan.l.justen@intel.com>]

On 2017-11-13 10:36:45, Laszlo Ersek wrote:
> On 11/13/17 19:25, Jordan Justen wrote:
> > On 2017-11-10 07:49:06, Laszlo Ersek wrote:
> >> diff --git a/OvmfPkg/Sec/Ia32/SecEntry.nasm b/OvmfPkg/Sec/Ia32/SecEntry.nasm
> >> index 54d074e621f6..1d426fafa888 100644
> >> --- a/OvmfPkg/Sec/Ia32/SecEntry.nasm
> >> +++ b/OvmfPkg/Sec/Ia32/SecEntry.nasm
> >> @@ -29,6 +29,7 @@ extern ASM_PFX(SecCoreStartupWithStack)
> >>  ; @param[in]  EAX   Initial value of the EAX register (BIST: Built-in Self Test)
> >>  ; @param[in]  DI    'BP': boot-strap processor, or 'AP': application processor
> >>  ; @param[in]  EBP   Pointer to the start of the Boot Firmware Volume
> >> +; @param[in]  ES    Set to LINEAR_SEL in TransitionFromReal16To32BitFlat
> > 
> > Can you document all the segment registers, and also document them in
> > UefiCpuPkg/ResetVector/Vtf0/Main.asm?
> 
> Do you mean the above format (i.e., @param[in]...), just repeated for
> the other segment registers too?
> 
> Regarding "UefiCpuPkg/ResetVector/Vtf0/Main.asm", what format do you
> suggest? The @param[in]... format wouldn't be right, because the segment
> registers are set up in TransitionFromReal16To32BitFlat. Should I write
> a free-form comment / list above
> 
>     OneTimeCall TransitionFromReal16To32BitFlat

How does something like this sound?

; @param[out] DS    Selector allowing flat access to all addresses

It seems to cover 32/64 bit and get the point across.

-Jordan