From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jordan.l.justen@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7857120349D9B for ; Mon, 13 Nov 2017 10:57:56 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2017 11:02:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,389,1505804400"; d="scan'208";a="149133710" Received: from sacolema-mobl2.amr.corp.intel.com (HELO localhost) ([10.254.117.1]) by orsmga004.jf.intel.com with ESMTP; 13 Nov 2017 11:02:02 -0800 MIME-Version: 1.0 To: Laszlo Ersek , edk2-devel-01 Message-ID: <151059972180.21629.7697117494773049469@jljusten-skl> From: Jordan Justen In-Reply-To: <13cae797-05c1-7ea0-0763-707cc1985320@redhat.com> Cc: Ard Biesheuvel , Ruiyu Ni References: <20171110154908.306-1-lersek@redhat.com> <20171110154908.306-3-lersek@redhat.com> <151059752091.21010.2353399254871736446@jljusten-skl> <13cae797-05c1-7ea0-0763-707cc1985320@redhat.com> User-Agent: alot/0.6 Date: Mon, 13 Nov 2017 11:02:02 -0800 Subject: Re: [PATCH 2/4] OvmfPkg/Sec/Ia32: seed the temporary RAM with PcdInitValueInTempStack X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2017 18:57:56 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-11-13 10:36:45, Laszlo Ersek wrote: > On 11/13/17 19:25, Jordan Justen wrote: > > On 2017-11-10 07:49:06, Laszlo Ersek wrote: > >> diff --git a/OvmfPkg/Sec/Ia32/SecEntry.nasm b/OvmfPkg/Sec/Ia32/SecEntr= y.nasm > >> index 54d074e621f6..1d426fafa888 100644 > >> --- a/OvmfPkg/Sec/Ia32/SecEntry.nasm > >> +++ b/OvmfPkg/Sec/Ia32/SecEntry.nasm > >> @@ -29,6 +29,7 @@ extern ASM_PFX(SecCoreStartupWithStack) > >> ; @param[in] EAX Initial value of the EAX register (BIST: Built-in= Self Test) > >> ; @param[in] DI 'BP': boot-strap processor, or 'AP': application = processor > >> ; @param[in] EBP Pointer to the start of the Boot Firmware Volume > >> +; @param[in] ES Set to LINEAR_SEL in TransitionFromReal16To32BitF= lat > > = > > Can you document all the segment registers, and also document them in > > UefiCpuPkg/ResetVector/Vtf0/Main.asm? > = > Do you mean the above format (i.e., @param[in]...), just repeated for > the other segment registers too? > = > Regarding "UefiCpuPkg/ResetVector/Vtf0/Main.asm", what format do you > suggest? The @param[in]... format wouldn't be right, because the segment > registers are set up in TransitionFromReal16To32BitFlat. Should I write > a free-form comment / list above > = > OneTimeCall TransitionFromReal16To32BitFlat How does something like this sound? ; @param[out] DS Selector allowing flat access to all addresses It seems to cover 32/64 bit and get the point across. -Jordan