* [Patch] BaseTools: Fix a bug for single module build with GenC/GenMake option
@ 2017-11-17 4:02 Yonghong Zhu
2017-11-20 9:25 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Yonghong Zhu @ 2017-11-17 4:02 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao
when build a single module with GenC/GenMake option, currently it will
direct return after create Autogen code files, then it cause MaList is
empty, which cause an incorrect error message is reported.
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
BaseTools/Source/Python/build/build.py | 5 -----
1 file changed, 5 deletions(-)
diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index 4f73bba..53f1245 100644
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -1835,17 +1835,12 @@ class Build():
# Not to auto-gen for targets 'clean', 'cleanlib', 'cleanall', 'run', 'fds'
if self.Target not in ['clean', 'cleanlib', 'cleanall', 'run', 'fds']:
# for target which must generate AutoGen code and makefile
if not self.SkipAutoGen or self.Target == 'genc':
Ma.CreateCodeFile(True)
- if self.Target == "genc":
- continue
-
if not self.SkipAutoGen or self.Target == 'genmake':
Ma.CreateMakeFile(True)
- if self.Target == "genmake":
- continue
MaList.append(Ma)
self.BuildModules.append(Ma)
self.AutoGenTime += int(round((time.time() - AutoGenStart)))
MakeStart = time.time()
for Ma in self.BuildModules:
--
2.6.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] BaseTools: Fix a bug for single module build with GenC/GenMake option
2017-11-17 4:02 [Patch] BaseTools: Fix a bug for single module build with GenC/GenMake option Yonghong Zhu
@ 2017-11-20 9:25 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2017-11-20 9:25 UTC (permalink / raw)
To: Zhu, Yonghong, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Friday, November 17, 2017 12:03 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [edk2] [Patch] BaseTools: Fix a bug for single module build with
>GenC/GenMake option
>
>when build a single module with GenC/GenMake option, currently it will
>direct return after create Autogen code files, then it cause MaList is
>empty, which cause an incorrect error message is reported.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 5 -----
> 1 file changed, 5 deletions(-)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 4f73bba..53f1245 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -1835,17 +1835,12 @@ class Build():
> # Not to auto-gen for targets 'clean', 'cleanlib', 'cleanall', 'run',
>'fds'
> if self.Target not in ['clean', 'cleanlib', 'cleanall', 'run', 'fds']:
> # for target which must generate AutoGen code and makefile
> if not self.SkipAutoGen or self.Target == 'genc':
> Ma.CreateCodeFile(True)
>- if self.Target == "genc":
>- continue
>-
> if not self.SkipAutoGen or self.Target == 'genmake':
> Ma.CreateMakeFile(True)
>- if self.Target == "genmake":
>- continue
> MaList.append(Ma)
> self.BuildModules.append(Ma)
> self.AutoGenTime += int(round((time.time() - AutoGenStart)))
> MakeStart = time.time()
> for Ma in self.BuildModules:
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-20 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-17 4:02 [Patch] BaseTools: Fix a bug for single module build with GenC/GenMake option Yonghong Zhu
2017-11-20 9:25 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox