[PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg
@ 2017-11-29  4:58 Star Zeng
  2017-11-29  4:58 ` [PATCH 1/2] IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg Star Zeng
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Star Zeng @ 2017-11-29  4:58 UTC (permalink / raw)
  To: edk2-devel
  Cc: Star Zeng, Jiewen Yao, Michael D Kinney, Eric Dong, Laszlo Ersek

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=540

To consume FIT table for Microcode update,
UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe
needs to be updated to consume
IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h,
but UefiCpuPkg could not depend on IntelSiliconPkg.

Since the Microcode update feature is specific to Intel,
we can first move the Microcode update feature code from
UefiCpuPkg to IntelSiliconPkg [first step], then update
the code to consume FIT table [second step].

This patch series is for the first step.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Regression-tested-by: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>

Star Zeng (2):
  IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg
  IntelSiliconPkg: Update MicrocodeUpdate to build with the package

 .../MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c  |  0
 .../MicrocodeFlashAccessLibNull.inf                            |  6 +++---
 .../MicrocodeFlashAccessLibNull.uni                            |  0
 .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc        |  0
 .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf        |  0
 .../Feature/Capsule/MicrocodeCapsulePdb/Readme.md              |  0
 .../Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf        |  0
 .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc        |  0
 .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf        |  0
 .../Feature/Capsule/MicrocodeCapsuleTxt/Readme.md              |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c          |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c       |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h       |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf  |  3 ++-
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni  |  0
 .../Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni     |  0
 {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h    |  0
 .../Include/Library/MicrocodeFlashAccessLib.h                  |  0
 IntelSiliconPkg/IntelSiliconPkg.dec                            | 10 +++++++++-
 IntelSiliconPkg/IntelSiliconPkg.dsc                            |  2 ++
 UefiCpuPkg/UefiCpuPkg.dec                                      |  7 -------
 UefiCpuPkg/UefiCpuPkg.dsc                                      |  2 --
 22 files changed, 16 insertions(+), 14 deletions(-)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf (85%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.uni (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/Readme.md (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Readme.md (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf (91%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Include/Library/MicrocodeFlashAccessLib.h (100%)

-- 
2.7.0.windows.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg
  2017-11-29  4:58 [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg Star Zeng
@ 2017-11-29  4:58 ` Star Zeng
  2017-11-29  4:58 ` [PATCH 2/2] IntelSiliconPkg: Update MicrocodeUpdate to build with the package Star Zeng
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Star Zeng @ 2017-11-29  4:58 UTC (permalink / raw)
  To: edk2-devel
  Cc: Star Zeng, Jiewen Yao, Michael D Kinney, Eric Dong, Laszlo Ersek

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=540

To consume FIT table for Microcode update,
UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe
needs to be updated to consume
IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h,
but UefiCpuPkg could not depend on IntelSiliconPkg.

Since the Microcode update feature is specific to Intel,
we can first move the Microcode update feature code from
UefiCpuPkg to IntelSiliconPkg [first step], then update
the code to consume FIT table [second step].

This patch series is for the first step.

Note: No any code change in this patch, just move.
Next patch will update MicrocodeUpdate to build with the package.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Regression-tested-by: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 .../MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c  |  0
 .../MicrocodeFlashAccessLibNull.inf                            |  0
 .../MicrocodeFlashAccessLibNull.uni                            |  0
 .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc        |  0
 .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf        |  0
 .../Feature/Capsule/MicrocodeCapsulePdb/Readme.md              |  0
 .../Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf        |  0
 .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc        |  0
 .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf        |  0
 .../Feature/Capsule/MicrocodeCapsuleTxt/Readme.md              |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c          |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c       |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h       |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf  |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni  |  0
 .../Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni     |  0
 {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h    |  0
 .../Include/Library/MicrocodeFlashAccessLib.h                  |  0
 IntelSiliconPkg/IntelSiliconPkg.dec                            | 10 +++++++++-
 UefiCpuPkg/UefiCpuPkg.dec                                      |  7 -------
 UefiCpuPkg/UefiCpuPkg.dsc                                      |  2 --
 21 files changed, 9 insertions(+), 10 deletions(-)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.uni (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/Readme.md (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Readme.md (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h (100%)
 rename {UefiCpuPkg => IntelSiliconPkg}/Include/Library/MicrocodeFlashAccessLib.h (100%)

diff --git a/UefiCpuPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c b/IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c
rename to IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c
diff --git a/UefiCpuPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf b/IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf
rename to IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf
diff --git a/UefiCpuPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.uni b/IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.uni
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.uni
rename to IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.uni
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc b/IntelSiliconPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf b/IntelSiliconPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/Readme.md b/IntelSiliconPkg/Feature/Capsule/MicrocodeCapsulePdb/Readme.md
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/Readme.md
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeCapsulePdb/Readme.md
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf b/IntelSiliconPkg/Feature/Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc b/IntelSiliconPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf b/IntelSiliconPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/Readme.md b/IntelSiliconPkg/Feature/Capsule/MicrocodeCapsuleTxt/Readme.md
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/Readme.md
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeCapsuleTxt/Readme.md
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c b/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c b/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h b/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf b/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni b/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni b/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni
similarity index 100%
rename from UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni
rename to IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni
diff --git a/UefiCpuPkg/Include/Guid/MicrocodeFmp.h b/IntelSiliconPkg/Include/Guid/MicrocodeFmp.h
similarity index 100%
rename from UefiCpuPkg/Include/Guid/MicrocodeFmp.h
rename to IntelSiliconPkg/Include/Guid/MicrocodeFmp.h
diff --git a/UefiCpuPkg/Include/Library/MicrocodeFlashAccessLib.h b/IntelSiliconPkg/Include/Library/MicrocodeFlashAccessLib.h
similarity index 100%
rename from UefiCpuPkg/Include/Library/MicrocodeFlashAccessLib.h
rename to IntelSiliconPkg/Include/Library/MicrocodeFlashAccessLib.h
diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec b/IntelSiliconPkg/IntelSiliconPkg.dec
index b88630d13835..a15d3dee392c 100644
--- a/IntelSiliconPkg/IntelSiliconPkg.dec
+++ b/IntelSiliconPkg/IntelSiliconPkg.dec
@@ -3,7 +3,7 @@
 #
 # This package provides common open source Intel silicon modules.
 #
-# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials are licensed and made available under
 # the terms and conditions of the BSD License that accompanies this distribution.
 # The full text of the license may be found at
@@ -23,6 +23,11 @@ [Defines]
 [Includes]
   Include
 
+[LibraryClasses.IA32, LibraryClasses.X64]
+  ## @libraryclass  Provides services to access Microcode region on flash device.
+  #
+  MicrocodeFlashAccessLib|Include/Library/MicrocodeFlashAccessLib.h
+
 [Guids]
   ## GUID for Package token space
   # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}
@@ -33,6 +38,9 @@ [Guids]
   # Generic DXE Library / Driver can locate HOB(s) and add SMBIOS records into SMBIOS table
   gIntelSmbiosDataHobGuid         = { 0x798e722e, 0x15b2, 0x4e13, { 0x8a, 0xe9, 0x6b, 0xa3, 0x0f, 0xf7, 0xf1, 0x67 }}
 
+  ## Include/Guid/MicrocodeFmp.h
+  gMicrocodeFmpImageTypeIdGuid      = { 0x96d4fdcd, 0x1502, 0x424d, { 0x9d, 0x4c, 0x9b, 0x12, 0xd2, 0xdc, 0xae, 0x5c } }
+
 [Ppis]
   gEdkiiVTdInfoPpiGuid = { 0x8a59fcb3, 0xf191, 0x400c, { 0x97, 0x67, 0x67, 0xaf, 0x2b, 0x25, 0x68, 0x4a } }
 
diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec
index 3bd8740c987f..d2965ba14c2d 100644
--- a/UefiCpuPkg/UefiCpuPkg.dec
+++ b/UefiCpuPkg/UefiCpuPkg.dec
@@ -59,17 +59,10 @@ [LibraryClasses.IA32, LibraryClasses.X64]
   ##
   MpInitLib|Include/Library/MpInitLib.h
 
-  ## @libraryclass  Provides services to access Microcode region on flash device.
-  #
-  MicrocodeFlashAccessLib|Include/Library/MicrocodeFlashAccessLib.h
-
 [Guids]
   gUefiCpuPkgTokenSpaceGuid      = { 0xac05bf33, 0x995a, 0x4ed4, { 0xaa, 0xb8, 0xef, 0x7a, 0xe8, 0xf, 0x5c, 0xb0 }}
   gMsegSmramGuid                 = { 0x5802bce4, 0xeeee, 0x4e33, { 0xa1, 0x30, 0xeb, 0xad, 0x27, 0xf0, 0xe4, 0x39 }}
 
-  ## Include/Guid/MicrocodeFmp.h
-  gMicrocodeFmpImageTypeIdGuid      = { 0x96d4fdcd, 0x1502, 0x424d, { 0x9d, 0x4c, 0x9b, 0x12, 0xd2, 0xdc, 0xae, 0x5c } }
-
   ## Include/Guid/CpuFeaturesSetDone.h
   gEdkiiCpuFeaturesSetDoneGuid   = { 0xa82485ce, 0xad6b, 0x4101, { 0x99, 0xd3, 0xe1, 0x35, 0x8c, 0x9e, 0x7e, 0x37 }}
 
diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc
index 41cf809559ca..d9a3d2d65470 100644
--- a/UefiCpuPkg/UefiCpuPkg.dsc
+++ b/UefiCpuPkg/UefiCpuPkg.dsc
@@ -61,7 +61,6 @@ [LibraryClasses]
   SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf
   PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
   PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf
-  MicrocodeFlashAccessLib|UefiCpuPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
 
 [LibraryClasses.common.SEC]
@@ -152,7 +151,6 @@ [Components.IA32, Components.X64]
       SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf
   }
   UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf
-  UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
 
 [BuildOptions]
   *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
-- 
2.7.0.windows.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] IntelSiliconPkg: Update MicrocodeUpdate to build with the package
  2017-11-29  4:58 [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg Star Zeng
  2017-11-29  4:58 ` [PATCH 1/2] IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg Star Zeng
@ 2017-11-29  4:58 ` Star Zeng
  2017-11-29  6:52 ` [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg Yao, Jiewen
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Star Zeng @ 2017-11-29  4:58 UTC (permalink / raw)
  To: edk2-devel; +Cc: Star Zeng, Jiewen Yao, Michael D Kinney

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=540

This is after patch
"IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg".

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Regression-tested-by: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 .../MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf     | 6 +++---
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf       | 3 ++-
 IntelSiliconPkg/IntelSiliconPkg.dsc                                 | 2 ++
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf b/IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf
index a4a47e073720..3b2532f7a09d 100644
--- a/IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf
+++ b/IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf
@@ -3,7 +3,7 @@
 #
 #  Microcode flash device access library NULL instance.
 #
-#  Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+#  Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
 #  which accompanies this distribution.  The full text of the license may be found at
@@ -26,7 +26,7 @@ [Defines]
 #
 # The following information is for reference only and not required by the build tools.
 #
-#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
+#  VALID_ARCHITECTURES           = IA32 X64
 #
 
 [Sources]
@@ -34,7 +34,7 @@ [Sources]
 
 [Packages]
   MdePkg/MdePkg.dec
-  UefiCpuPkg/UefiCpuPkg.dec
+  IntelSiliconPkg/IntelSiliconPkg.dec
 
 [LibraryClasses]
   BaseMemoryLib
diff --git a/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf b/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
index 55797cf132b1..dbc90857a0a5 100644
--- a/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
+++ b/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
@@ -3,7 +3,7 @@
 #
 # Produce FMP instance to update Microcode.
 #
-#  Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+#  Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
 #  which accompanies this distribution.  The full text of the license may be found at
@@ -36,6 +36,7 @@ [Sources]
 
 [Packages]
   MdePkg/MdePkg.dec
+  IntelSiliconPkg/IntelSiliconPkg.dec
   UefiCpuPkg/UefiCpuPkg.dec
 
 [LibraryClasses]
diff --git a/IntelSiliconPkg/IntelSiliconPkg.dsc b/IntelSiliconPkg/IntelSiliconPkg.dsc
index 57173411b373..e3043f82228e 100644
--- a/IntelSiliconPkg/IntelSiliconPkg.dsc
+++ b/IntelSiliconPkg/IntelSiliconPkg.dsc
@@ -39,6 +39,7 @@ [LibraryClasses]
   PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
   SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
   CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
+  MicrocodeFlashAccessLib|UefiCpuPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf
 
 [LibraryClasses.common.PEIM]
   PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
@@ -83,6 +84,7 @@ [Components]
   IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.inf
   IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.inf
   IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.inf
+  UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
 
 [BuildOptions]
   *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
-- 
2.7.0.windows.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg
  2017-11-29  4:58 [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg Star Zeng
  2017-11-29  4:58 ` [PATCH 1/2] IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg Star Zeng
  2017-11-29  4:58 ` [PATCH 2/2] IntelSiliconPkg: Update MicrocodeUpdate to build with the package Star Zeng
@ 2017-11-29  6:52 ` Yao, Jiewen
  2017-11-29 12:34 ` Laszlo Ersek
  2017-11-29 12:41 ` Dong, Eric
  4 siblings, 0 replies; 6+ messages in thread
From: Yao, Jiewen @ 2017-11-29  6:52 UTC (permalink / raw)
  To: Zeng, Star, edk2-devel@lists.01.org
  Cc: Kinney, Michael D, Dong, Eric, Laszlo Ersek

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, November 29, 2017 12:59 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to
> IntelSiliconPkg
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=540
> 
> To consume FIT table for Microcode update,
> UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe
> needs to be updated to consume
> IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h,
> but UefiCpuPkg could not depend on IntelSiliconPkg.
> 
> Since the Microcode update feature is specific to Intel,
> we can first move the Microcode update feature code from
> UefiCpuPkg to IntelSiliconPkg [first step], then update
> the code to consume FIT table [second step].
> 
> This patch series is for the first step.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Regression-tested-by: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> 
> Star Zeng (2):
>   IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg
>   IntelSiliconPkg: Update MicrocodeUpdate to build with the package
> 
>  .../MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c  |  0
>  .../MicrocodeFlashAccessLibNull.inf                            |  6
> +++---
>  .../MicrocodeFlashAccessLibNull.uni                            |  0
>  .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc        |  0
>  .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf        |  0
>  .../Feature/Capsule/MicrocodeCapsulePdb/Readme.md              |  0
>  .../Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf        |  0
>  .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc        |  0
>  .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf        |  0
>  .../Feature/Capsule/MicrocodeCapsuleTxt/Readme.md              |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c          |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c       |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h       |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf  |  3 ++-
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni  |  0
>  .../Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni     |  0
>  {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h    |  0
>  .../Include/Library/MicrocodeFlashAccessLib.h                  |  0
>  IntelSiliconPkg/IntelSiliconPkg.dec                            | 10
> +++++++++-
>  IntelSiliconPkg/IntelSiliconPkg.dsc                            |  2 ++
>  UefiCpuPkg/UefiCpuPkg.dec                                      |  7
> -------
>  UefiCpuPkg/UefiCpuPkg.dsc                                      |  2
> --
>  22 files changed, 16 insertions(+), 14 deletions(-)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/Microco
> deFlashAccessLibNull.c (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/Microco
> deFlashAccessLibNull.inf (85%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/Microco
> deFlashAccessLibNull.uni (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.
> dsc (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.f
> df (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/Readme.md (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.in
> f (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.ds
> c (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf
> (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Readme.md (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c
> (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c
> (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h
> (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in
> f (91%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.u
> ni (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeEx
> tra.uni (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h (100%)
>  rename {UefiCpuPkg =>
> IntelSiliconPkg}/Include/Library/MicrocodeFlashAccessLib.h (100%)
> 
> --
> 2.7.0.windows.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg
  2017-11-29  4:58 [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg Star Zeng
                   ` (2 preceding siblings ...)
  2017-11-29  6:52 ` [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg Yao, Jiewen
@ 2017-11-29 12:34 ` Laszlo Ersek
  2017-11-29 12:41 ` Dong, Eric
  4 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2017-11-29 12:34 UTC (permalink / raw)
  To: Star Zeng, edk2-devel; +Cc: Michael D Kinney, Jiewen Yao, Eric Dong

On 11/29/17 05:58, Star Zeng wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=540
> 
> To consume FIT table for Microcode update,
> UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe
> needs to be updated to consume
> IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h,
> but UefiCpuPkg could not depend on IntelSiliconPkg.
> 
> Since the Microcode update feature is specific to Intel,
> we can first move the Microcode update feature code from
> UefiCpuPkg to IntelSiliconPkg [first step], then update
> the code to consume FIT table [second step].
> 
> This patch series is for the first step.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Regression-tested-by: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> 
> Star Zeng (2):
>   IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg
>   IntelSiliconPkg: Update MicrocodeUpdate to build with the package
> 
>  .../MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c  |  0
>  .../MicrocodeFlashAccessLibNull.inf                            |  6 +++---
>  .../MicrocodeFlashAccessLibNull.uni                            |  0
>  .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc        |  0
>  .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf        |  0
>  .../Feature/Capsule/MicrocodeCapsulePdb/Readme.md              |  0
>  .../Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf        |  0
>  .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc        |  0
>  .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf        |  0
>  .../Feature/Capsule/MicrocodeCapsuleTxt/Readme.md              |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c          |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c       |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h       |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf  |  3 ++-
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni  |  0
>  .../Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni     |  0
>  {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h    |  0
>  .../Include/Library/MicrocodeFlashAccessLib.h                  |  0
>  IntelSiliconPkg/IntelSiliconPkg.dec                            | 10 +++++++++-
>  IntelSiliconPkg/IntelSiliconPkg.dsc                            |  2 ++
>  UefiCpuPkg/UefiCpuPkg.dec                                      |  7 -------
>  UefiCpuPkg/UefiCpuPkg.dsc                                      |  2 --
>  22 files changed, 16 insertions(+), 14 deletions(-)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf (85%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.uni (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/Readme.md (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Readme.md (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf (91%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Include/Library/MicrocodeFlashAccessLib.h (100%)
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg
  2017-11-29  4:58 [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg Star Zeng
                   ` (3 preceding siblings ...)
  2017-11-29 12:34 ` Laszlo Ersek
@ 2017-11-29 12:41 ` Dong, Eric
  4 siblings, 0 replies; 6+ messages in thread
From: Dong, Eric @ 2017-11-29 12:41 UTC (permalink / raw)
  To: Zeng, Star, edk2-devel@lists.01.org
  Cc: Yao, Jiewen, Kinney, Michael D, Laszlo Ersek

Reviewed-by: Eric Dong <eric.dong@intel.com>

-----Original Message-----
From: Zeng, Star 
Sent: Wednesday, November 29, 2017 12:59 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star; Yao, Jiewen; Kinney, Michael D; Dong, Eric; Laszlo Ersek
Subject: [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=540

To consume FIT table for Microcode update, UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe
needs to be updated to consume
IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h,
but UefiCpuPkg could not depend on IntelSiliconPkg.

Since the Microcode update feature is specific to Intel, we can first move the Microcode update feature code from UefiCpuPkg to IntelSiliconPkg [first step], then update the code to consume FIT table [second step].

This patch series is for the first step.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Regression-tested-by: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>

Star Zeng (2):
  IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg
  IntelSiliconPkg: Update MicrocodeUpdate to build with the package

 .../MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c  |  0
 .../MicrocodeFlashAccessLibNull.inf                            |  6 +++---
 .../MicrocodeFlashAccessLibNull.uni                            |  0
 .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc        |  0
 .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf        |  0
 .../Feature/Capsule/MicrocodeCapsulePdb/Readme.md              |  0
 .../Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf        |  0
 .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc        |  0
 .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf        |  0
 .../Feature/Capsule/MicrocodeCapsuleTxt/Readme.md              |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c          |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c       |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h       |  0
 .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf  |  3 ++-  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni  |  0
 .../Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni     |  0
 {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h    |  0
 .../Include/Library/MicrocodeFlashAccessLib.h                  |  0
 IntelSiliconPkg/IntelSiliconPkg.dec                            | 10 +++++++++-
 IntelSiliconPkg/IntelSiliconPkg.dsc                            |  2 ++
 UefiCpuPkg/UefiCpuPkg.dec                                      |  7 -------
 UefiCpuPkg/UefiCpuPkg.dsc                                      |  2 --
 22 files changed, 16 insertions(+), 14 deletions(-)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf (85%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.uni (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/Readme.md (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Readme.md (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf (91%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h (100%)  rename {UefiCpuPkg => IntelSiliconPkg}/Include/Library/MicrocodeFlashAccessLib.h (100%)

--
2.7.0.windows.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-11-29 12:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-29  4:58 [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg Star Zeng
2017-11-29  4:58 ` [PATCH 1/2] IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg Star Zeng
2017-11-29  4:58 ` [PATCH 2/2] IntelSiliconPkg: Update MicrocodeUpdate to build with the package Star Zeng
2017-11-29  6:52 ` [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg Yao, Jiewen
2017-11-29 12:34 ` Laszlo Ersek
2017-11-29 12:41 ` Dong, Eric

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox