public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] UefiCpuPkg: SmmCpuFeaturesLib Add the missing ASM_PFX in nasm code
@ 2017-12-07  3:42 Liming Gao
  2017-12-07  4:10 ` Yao, Jiewen
  0 siblings, 1 reply; 2+ messages in thread
From: Liming Gao @ 2017-12-07  3:42 UTC (permalink / raw)
  To: edk2-devel; +Cc: Eric Dong

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
---
 UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
index bcac643..ea2d297 100644
--- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
+++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
@@ -188,15 +188,15 @@ CommonHandler:
     add     rsp, -0x20
 
     mov     rcx, rbx
-    mov     rax, CpuSmmDebugEntry
+    mov     rax, ASM_PFX(CpuSmmDebugEntry)
     call    rax
 
     mov     rcx, rbx
-    mov     rax, SmiRendezvous          ; rax <- absolute addr of SmiRedezvous
+    mov     rax, ASM_PFX(SmiRendezvous)          ; rax <- absolute addr of SmiRedezvous
     call    rax
 
     mov     rcx, rbx
-    mov     rax, CpuSmmDebugExit
+    mov     rax, ASM_PFX(CpuSmmDebugExit)
     call    rax
 
     add     rsp, 0x20
-- 
2.8.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] UefiCpuPkg: SmmCpuFeaturesLib Add the missing ASM_PFX in nasm code
  2017-12-07  3:42 [Patch] UefiCpuPkg: SmmCpuFeaturesLib Add the missing ASM_PFX in nasm code Liming Gao
@ 2017-12-07  4:10 ` Yao, Jiewen
  0 siblings, 0 replies; 2+ messages in thread
From: Yao, Jiewen @ 2017-12-07  4:10 UTC (permalink / raw)
  To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Dong, Eric

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming
> Gao
> Sent: Thursday, December 7, 2017 11:43 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>
> Subject: [edk2] [Patch] UefiCpuPkg: SmmCpuFeaturesLib Add the missing
> ASM_PFX in nasm code
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> index bcac643..ea2d297 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> @@ -188,15 +188,15 @@ CommonHandler:
>      add     rsp, -0x20
> 
>      mov     rcx, rbx
> -    mov     rax, CpuSmmDebugEntry
> +    mov     rax, ASM_PFX(CpuSmmDebugEntry)
>      call    rax
> 
>      mov     rcx, rbx
> -    mov     rax, SmiRendezvous          ; rax <- absolute addr of
> SmiRedezvous
> +    mov     rax, ASM_PFX(SmiRendezvous)          ; rax <- absolute addr
> of SmiRedezvous
>      call    rax
> 
>      mov     rcx, rbx
> -    mov     rax, CpuSmmDebugExit
> +    mov     rax, ASM_PFX(CpuSmmDebugExit)
>      call    rax
> 
>      add     rsp, 0x20
> --
> 2.8.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-07  4:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-07  3:42 [Patch] UefiCpuPkg: SmmCpuFeaturesLib Add the missing ASM_PFX in nasm code Liming Gao
2017-12-07  4:10 ` Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox