* [PATCH 1/3] MdePkg PciIo.h: Correct function description for ALLOCATE_BUFFER
2017-12-11 6:53 [PATCH 0/3] Correct function description for ALLOCATE_BUFFER Star Zeng
@ 2017-12-11 6:53 ` Star Zeng
2017-12-11 6:53 ` [PATCH 2/3] MdeModulePkg: Correct function description for AllocateBuffer Star Zeng
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Star Zeng @ 2017-12-11 6:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Jiewen Yao, Ruiyu Ni, Liming Gao, Michael D Kinney
DUAL_ADDRESS_CYCLE is missing in the EFI_UNSUPPORTED
return status description.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdePkg/Include/Protocol/PciIo.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/Protocol/PciIo.h b/MdePkg/Include/Protocol/PciIo.h
index 42bcc8183077..d6492fcf0436 100644
--- a/MdePkg/Include/Protocol/PciIo.h
+++ b/MdePkg/Include/Protocol/PciIo.h
@@ -331,7 +331,7 @@ EFI_STATUS
/**
Allocates pages that are suitable for an EfiPciIoOperationBusMasterCommonBuffer
- mapping.
+ or EfiPciOperationBusMasterCommonBuffer64 mapping.
@param This A pointer to the EFI_PCI_IO_PROTOCOL instance.
@param Type This parameter is not used and must be ignored.
@@ -344,7 +344,7 @@ EFI_STATUS
@retval EFI_SUCCESS The requested memory pages were allocated.
@retval EFI_UNSUPPORTED Attributes is unsupported. The only legal attribute bits are
- MEMORY_WRITE_COMBINE and MEMORY_CACHED.
+ MEMORY_WRITE_COMBINE, MEMORY_CACHED and DUAL_ADDRESS_CYCLE.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_OUT_OF_RESOURCES The memory pages could not be allocated.
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] MdeModulePkg: Correct function description for AllocateBuffer
2017-12-11 6:53 [PATCH 0/3] Correct function description for ALLOCATE_BUFFER Star Zeng
2017-12-11 6:53 ` [PATCH 1/3] MdePkg PciIo.h: " Star Zeng
@ 2017-12-11 6:53 ` Star Zeng
2017-12-11 6:53 ` [PATCH 3/3] IntelSilicon: " Star Zeng
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Star Zeng @ 2017-12-11 6:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Jiewen Yao, Ruiyu Ni
DUAL_ADDRESS_CYCLE is missing in the EFI_UNSUPPORTED
return status description.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 4 ++--
MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h | 4 ++--
MdeModulePkg/Include/Ppi/IoMmu.h | 2 +-
MdeModulePkg/Include/Protocol/IoMmu.h | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
index cc7125e4fc3c..190f4b0dc7ed 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
@@ -1081,7 +1081,7 @@ PciIoUnmap (
/**
Allocates pages that are suitable for an EfiPciIoOperationBusMasterCommonBuffer
- mapping.
+ or EfiPciOperationBusMasterCommonBuffer64 mapping.
@param This A pointer to the EFI_PCI_IO_PROTOCOL instance.
@param Type This parameter is not used and must be ignored.
@@ -1094,7 +1094,7 @@ PciIoUnmap (
@retval EFI_SUCCESS The requested memory pages were allocated.
@retval EFI_UNSUPPORTED Attributes is unsupported. The only legal attribute bits are
- MEMORY_WRITE_COMBINE and MEMORY_CACHED.
+ MEMORY_WRITE_COMBINE, MEMORY_CACHED and DUAL_ADDRESS_CYCLE.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_OUT_OF_RESOURCES The memory pages could not be allocated.
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h
index da3de3938e4b..b7e38ded3fa4 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h
@@ -411,7 +411,7 @@ PciIoUnmap (
/**
Allocates pages that are suitable for an EfiPciIoOperationBusMasterCommonBuffer
- mapping.
+ or EfiPciOperationBusMasterCommonBuffer64 mapping.
@param This A pointer to the EFI_PCI_IO_PROTOCOL instance.
@param Type This parameter is not used and must be ignored.
@@ -424,7 +424,7 @@ PciIoUnmap (
@retval EFI_SUCCESS The requested memory pages were allocated.
@retval EFI_UNSUPPORTED Attributes is unsupported. The only legal attribute bits are
- MEMORY_WRITE_COMBINE and MEMORY_CACHED.
+ MEMORY_WRITE_COMBINE, MEMORY_CACHED and DUAL_ADDRESS_CYCLE.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_OUT_OF_RESOURCES The memory pages could not be allocated.
diff --git a/MdeModulePkg/Include/Ppi/IoMmu.h b/MdeModulePkg/Include/Ppi/IoMmu.h
index 5303d68b0774..ed8cd540a21f 100644
--- a/MdeModulePkg/Include/Ppi/IoMmu.h
+++ b/MdeModulePkg/Include/Ppi/IoMmu.h
@@ -141,7 +141,7 @@ EFI_STATUS
@retval EFI_SUCCESS The requested memory pages were allocated.
@retval EFI_UNSUPPORTED Attributes is unsupported. The only legal attribute bits are
- MEMORY_WRITE_COMBINE and MEMORY_CACHED.
+ MEMORY_WRITE_COMBINE, MEMORY_CACHED and DUAL_ADDRESS_CYCLE.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_OUT_OF_RESOURCES The memory pages could not be allocated.
diff --git a/MdeModulePkg/Include/Protocol/IoMmu.h b/MdeModulePkg/Include/Protocol/IoMmu.h
index 9d25c17a5e94..1e06efeb6ae8 100644
--- a/MdeModulePkg/Include/Protocol/IoMmu.h
+++ b/MdeModulePkg/Include/Protocol/IoMmu.h
@@ -203,7 +203,7 @@ EFI_STATUS
@retval EFI_SUCCESS The requested memory pages were allocated.
@retval EFI_UNSUPPORTED Attributes is unsupported. The only legal attribute bits are
- MEMORY_WRITE_COMBINE and MEMORY_CACHED.
+ MEMORY_WRITE_COMBINE, MEMORY_CACHED and DUAL_ADDRESS_CYCLE.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_OUT_OF_RESOURCES The memory pages could not be allocated.
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/3] IntelSilicon: Correct function description for AllocateBuffer
2017-12-11 6:53 [PATCH 0/3] Correct function description for ALLOCATE_BUFFER Star Zeng
2017-12-11 6:53 ` [PATCH 1/3] MdePkg PciIo.h: " Star Zeng
2017-12-11 6:53 ` [PATCH 2/3] MdeModulePkg: Correct function description for AllocateBuffer Star Zeng
@ 2017-12-11 6:53 ` Star Zeng
2017-12-11 6:56 ` [PATCH 0/3] Correct function description for ALLOCATE_BUFFER Ni, Ruiyu
2017-12-11 7:10 ` Yao, Jiewen
4 siblings, 0 replies; 6+ messages in thread
From: Star Zeng @ 2017-12-11 6:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Jiewen Yao
DUAL_ADDRESS_CYCLE is missing in the EFI_UNSUPPORTED
return status description.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
IntelSiliconPkg/Feature/VTd/IntelVTdDxe/BmDma.c | 2 +-
IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c | 2 +-
IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/BmDma.c b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/BmDma.c
index 7a5f3619a47d..e8685666e79a 100644
--- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/BmDma.c
+++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/BmDma.c
@@ -300,7 +300,7 @@ IoMmuUnmap (
@retval EFI_SUCCESS The requested memory pages were allocated.
@retval EFI_UNSUPPORTED Attributes is unsupported. The only legal attribute bits are
- MEMORY_WRITE_COMBINE and MEMORY_CACHED.
+ MEMORY_WRITE_COMBINE, MEMORY_CACHED and DUAL_ADDRESS_CYCLE.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_OUT_OF_RESOURCES The memory pages could not be allocated.
diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c
index 64693a8c6ec3..89d9bea3fc0f 100644
--- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c
+++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c
@@ -87,7 +87,7 @@ IoMmuUnmap (
@retval EFI_SUCCESS The requested memory pages were allocated.
@retval EFI_UNSUPPORTED Attributes is unsupported. The only legal attribute bits are
- MEMORY_WRITE_COMBINE and MEMORY_CACHED.
+ MEMORY_WRITE_COMBINE, MEMORY_CACHED and DUAL_ADDRESS_CYCLE.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_OUT_OF_RESOURCES The memory pages could not be allocated.
diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c b/IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c
index 240a6d281737..7147a19f538a 100644
--- a/IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c
+++ b/IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c
@@ -284,7 +284,7 @@ PeiIoMmuUnmap (
@retval EFI_SUCCESS The requested memory pages were allocated.
@retval EFI_UNSUPPORTED Attributes is unsupported. The only legal attribute bits are
- MEMORY_WRITE_COMBINE and MEMORY_CACHED.
+ MEMORY_WRITE_COMBINE, MEMORY_CACHED and DUAL_ADDRESS_CYCLE.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_OUT_OF_RESOURCES The memory pages could not be allocated.
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] Correct function description for ALLOCATE_BUFFER
2017-12-11 6:53 [PATCH 0/3] Correct function description for ALLOCATE_BUFFER Star Zeng
` (2 preceding siblings ...)
2017-12-11 6:53 ` [PATCH 3/3] IntelSilicon: " Star Zeng
@ 2017-12-11 6:56 ` Ni, Ruiyu
2017-12-11 7:10 ` Yao, Jiewen
4 siblings, 0 replies; 6+ messages in thread
From: Ni, Ruiyu @ 2017-12-11 6:56 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org
Cc: Yao, Jiewen, Gao, Liming, Kinney, Michael D
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: Zeng, Star
> Sent: Monday, December 11, 2017 2:54 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Ni, Ruiyu <ruiyu.ni@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: [PATCH 0/3] Correct function description for ALLOCATE_BUFFER
>
> According to UEFI spec, DUAL_ADDRESS_CYCLE is missing in the
> EFI_UNSUPPORTED return status description for ALLOCATE_BUFFER
> interface.
> Same issue is also in IOMMU interface.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
> Star Zeng (3):
> MdePkg PciIo.h: Correct function description for ALLOCATE_BUFFER
> MdeModulePkg: Correct function description for AllocateBuffer
> IntelSilicon: Correct function description for AllocateBuffer
>
> IntelSiliconPkg/Feature/VTd/IntelVTdDxe/BmDma.c | 2 +-
> IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c | 2 +-
> IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c | 2 +-
> MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 4 ++--
> MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h | 4 ++--
> MdeModulePkg/Include/Ppi/IoMmu.h | 2 +-
> MdeModulePkg/Include/Protocol/IoMmu.h | 2 +-
> MdePkg/Include/Protocol/PciIo.h | 4 ++--
> 8 files changed, 11 insertions(+), 11 deletions(-)
>
> --
> 2.7.0.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/3] Correct function description for ALLOCATE_BUFFER
2017-12-11 6:53 [PATCH 0/3] Correct function description for ALLOCATE_BUFFER Star Zeng
` (3 preceding siblings ...)
2017-12-11 6:56 ` [PATCH 0/3] Correct function description for ALLOCATE_BUFFER Ni, Ruiyu
@ 2017-12-11 7:10 ` Yao, Jiewen
4 siblings, 0 replies; 6+ messages in thread
From: Yao, Jiewen @ 2017-12-11 7:10 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org
Cc: Ni, Ruiyu, Gao, Liming, Kinney, Michael D
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Zeng, Star
> Sent: Monday, December 11, 2017 2:54 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Ni,
> Ruiyu <ruiyu.ni@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: [PATCH 0/3] Correct function description for ALLOCATE_BUFFER
>
> According to UEFI spec, DUAL_ADDRESS_CYCLE is missing in the
> EFI_UNSUPPORTED return status description for ALLOCATE_BUFFER interface.
> Same issue is also in IOMMU interface.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
> Star Zeng (3):
> MdePkg PciIo.h: Correct function description for ALLOCATE_BUFFER
> MdeModulePkg: Correct function description for AllocateBuffer
> IntelSilicon: Correct function description for AllocateBuffer
>
> IntelSiliconPkg/Feature/VTd/IntelVTdDxe/BmDma.c | 2 +-
> IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c | 2 +-
> IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c | 2 +-
> MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 4 ++--
> MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h | 4 ++--
> MdeModulePkg/Include/Ppi/IoMmu.h | 2 +-
> MdeModulePkg/Include/Protocol/IoMmu.h | 2 +-
> MdePkg/Include/Protocol/PciIo.h | 4 ++--
> 8 files changed, 11 insertions(+), 11 deletions(-)
>
> --
> 2.7.0.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread