public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] BaseTools: Fix the incorrect indent introduced by 37de70
@ 2017-12-13  2:00 Yonghong Zhu
  2017-12-13  4:41 ` Gao, Liming
  0 siblings, 1 reply; 2+ messages in thread
From: Yonghong Zhu @ 2017-12-13  2:00 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao

The incorrect indent introduced by 37de70, it cause PEIM in sub FV
image can't be rebased. Then it block some platform can't boot.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 BaseTools/Source/Python/GenFds/Fv.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/GenFds/Fv.py b/BaseTools/Source/Python/GenFds/Fv.py
index 3953756..d5922c0 100644
--- a/BaseTools/Source/Python/GenFds/Fv.py
+++ b/BaseTools/Source/Python/GenFds/Fv.py
@@ -182,11 +182,11 @@ class FV (FvClassObject):
                         FileName = FfsFile.GenFfs(MacroDict, FvChildAddr, BaseAddress, IsMakefile=Flag)
 
                     if GenFdsGlobalVariable.LargeFileInFvFlags[-1]:
                         FFSGuid = GenFdsGlobalVariable.EFI_FIRMWARE_FILE_SYSTEM3_GUID;
                     #Update GenFv again
-                        GenFdsGlobalVariable.GenerateFirmwareVolume(
+                    GenFdsGlobalVariable.GenerateFirmwareVolume(
                                                 FvOutputFile,
                                                 [self.InfFileName],
                                                 AddressFile=FvInfoFileName,
                                                 FfsList=FfsFileList,
                                                 ForceRebase=self.FvForceRebase,
-- 
2.6.1.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] BaseTools: Fix the incorrect indent introduced by 37de70
  2017-12-13  2:00 [Patch] BaseTools: Fix the incorrect indent introduced by 37de70 Yonghong Zhu
@ 2017-12-13  4:41 ` Gao, Liming
  0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2017-12-13  4:41 UTC (permalink / raw)
  To: Zhu, Yonghong, edk2-devel@lists.01.org

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yonghong Zhu
> Sent: Wednesday, December 13, 2017 10:01 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch] BaseTools: Fix the incorrect indent introduced by 37de70
> 
> The incorrect indent introduced by 37de70, it cause PEIM in sub FV
> image can't be rebased. Then it block some platform can't boot.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  BaseTools/Source/Python/GenFds/Fv.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/GenFds/Fv.py b/BaseTools/Source/Python/GenFds/Fv.py
> index 3953756..d5922c0 100644
> --- a/BaseTools/Source/Python/GenFds/Fv.py
> +++ b/BaseTools/Source/Python/GenFds/Fv.py
> @@ -182,11 +182,11 @@ class FV (FvClassObject):
>                          FileName = FfsFile.GenFfs(MacroDict, FvChildAddr, BaseAddress, IsMakefile=Flag)
> 
>                      if GenFdsGlobalVariable.LargeFileInFvFlags[-1]:
>                          FFSGuid = GenFdsGlobalVariable.EFI_FIRMWARE_FILE_SYSTEM3_GUID;
>                      #Update GenFv again
> -                        GenFdsGlobalVariable.GenerateFirmwareVolume(
> +                    GenFdsGlobalVariable.GenerateFirmwareVolume(
>                                                  FvOutputFile,
>                                                  [self.InfFileName],
>                                                  AddressFile=FvInfoFileName,
>                                                  FfsList=FfsFileList,
>                                                  ForceRebase=self.FvForceRebase,
> --
> 2.6.1.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-13  4:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-13  2:00 [Patch] BaseTools: Fix the incorrect indent introduced by 37de70 Yonghong Zhu
2017-12-13  4:41 ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox