* [PATCH 1/2] MdePkg MemoryOverwriteControl.h: Correct typo 'bi' to 'bit'
2017-12-18 6:23 [PATCH 0/2] Minor refinement about TCG MOR Star Zeng
@ 2017-12-18 6:23 ` Star Zeng
2017-12-18 6:23 ` [PATCH 2/2] SecurityPkg TcgMor: Remove wrong comments Star Zeng
2017-12-19 1:27 ` [PATCH 0/2] Minor refinement about TCG MOR Yao, Jiewen
2 siblings, 0 replies; 4+ messages in thread
From: Star Zeng @ 2017-12-18 6:23 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Jiewen Yao, Chao Zhang, Liming Gao
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdePkg/Include/Guid/MemoryOverwriteControl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Include/Guid/MemoryOverwriteControl.h b/MdePkg/Include/Guid/MemoryOverwriteControl.h
index 09abeada1c13..2903c83f7236 100644
--- a/MdePkg/Include/Guid/MemoryOverwriteControl.h
+++ b/MdePkg/Include/Guid/MemoryOverwriteControl.h
@@ -36,7 +36,7 @@
#define MEMORY_OVERWRITE_REQUEST_VARIABLE_NAME L"MemoryOverwriteRequestControl"
///
-/// 0 = Firmware MUST clear the MOR bi
+/// 0 = Firmware MUST clear the MOR bit
/// 1 = Firmware MUST set the MOR bit
///
#define MOR_CLEAR_MEMORY_BIT_MASK 0x01
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] SecurityPkg TcgMor: Remove wrong comments
2017-12-18 6:23 [PATCH 0/2] Minor refinement about TCG MOR Star Zeng
2017-12-18 6:23 ` [PATCH 1/2] MdePkg MemoryOverwriteControl.h: Correct typo 'bi' to 'bit' Star Zeng
@ 2017-12-18 6:23 ` Star Zeng
2017-12-19 1:27 ` [PATCH 0/2] Minor refinement about TCG MOR Yao, Jiewen
2 siblings, 0 replies; 4+ messages in thread
From: Star Zeng @ 2017-12-18 6:23 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Jiewen Yao, Chao Zhang
and free the HandleBuffer after used.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
index e691a084d0ed..4fc3330c3964 100644
--- a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
+++ b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
@@ -23,8 +23,6 @@ UINT8 mMorControl;
/**
Ready to Boot Event notification handler.
- Sequence of OS boot events is measured in this event notification handler.
-
@param[in] Event Event whose notification function is being invoked
@param[in] Context Pointer to the notification function's context
@@ -234,9 +232,6 @@ Exit:
/**
Notification function of END_OF_DXE.
- This is a notification function registered on END_OF_DXE event.
- It is to get VarCheckPcdBin.
-
@param[in] Event Event whose notification function is being invoked.
@param[in] Context Pointer to the notification function's context.
@@ -299,6 +294,8 @@ TPerResetAtEndOfDxe (
InitiateTPerReset (Ssp, BlockIo->Media->MediaId);
}
+
+ FreePool (HandleBuffer);
}
/**
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] Minor refinement about TCG MOR
2017-12-18 6:23 [PATCH 0/2] Minor refinement about TCG MOR Star Zeng
2017-12-18 6:23 ` [PATCH 1/2] MdePkg MemoryOverwriteControl.h: Correct typo 'bi' to 'bit' Star Zeng
2017-12-18 6:23 ` [PATCH 2/2] SecurityPkg TcgMor: Remove wrong comments Star Zeng
@ 2017-12-19 1:27 ` Yao, Jiewen
2 siblings, 0 replies; 4+ messages in thread
From: Yao, Jiewen @ 2017-12-19 1:27 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Zhang, Chao B, Gao, Liming
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Zeng, Star
> Sent: Monday, December 18, 2017 2:23 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH 0/2] Minor refinement about TCG MOR
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
>
> Star Zeng (2):
> MdePkg MemoryOverwriteControl.h: Correct typo 'bi' to 'bit'
> SecurityPkg TcgMor: Remove wrong comments
>
> MdePkg/Include/Guid/MemoryOverwriteControl.h | 2 +-
> SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 7 ++-----
> 2 files changed, 3 insertions(+), 6 deletions(-)
>
> --
> 2.7.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread