From: Jiaxin Wu <jiaxin.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Fu Siyuan <siyuan.fu@intel.com>, Wang Fan <fan.wang@intel.com>,
Ye Ting <ting.ye@intel.com>, Wu Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch 2/3] NetworkPkg/TcpDxe: Remove the redundant code.
Date: Fri, 22 Dec 2017 15:07:18 +0800 [thread overview]
Message-ID: <1513926438-4160-3-git-send-email-jiaxin.wu@intel.com> (raw)
In-Reply-To: <1513926438-4160-1-git-send-email-jiaxin.wu@intel.com>
The function SockGroup() is not used by any other code. So,
it can be deleted.
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Wang Fan <fan.wang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
NetworkPkg/TcpDxe/SockInterface.c | 46 ---------------------------------------
NetworkPkg/TcpDxe/Socket.h | 21 +-----------------
2 files changed, 1 insertion(+), 66 deletions(-)
diff --git a/NetworkPkg/TcpDxe/SockInterface.c b/NetworkPkg/TcpDxe/SockInterface.c
index 0248cdf..0dfc0a7 100644
--- a/NetworkPkg/TcpDxe/SockInterface.c
+++ b/NetworkPkg/TcpDxe/SockInterface.c
@@ -1078,56 +1078,10 @@ SockGetMode (
{
return Sock->ProtoHandler (Sock, SOCK_MODE, Mode);
}
/**
- Configure the low level protocol to join a multicast group for
- this socket's connection.
-
- @param[in] Sock Pointer to the socket of the connection to join the
- specific multicast group.
- @param[in] GroupInfo Pointer to the multicast group info.
-
- @retval EFI_SUCCESS The configuration completed successfully.
- @retval EFI_ACCESS_DENIED Failed to get the lock to access the socket.
- @retval EFI_NOT_STARTED The socket is not configured.
-
-**/
-EFI_STATUS
-SockGroup (
- IN SOCKET *Sock,
- IN VOID *GroupInfo
- )
-{
- EFI_STATUS Status;
-
- Status = EfiAcquireLockOrFail (&(Sock->Lock));
-
- if (EFI_ERROR (Status)) {
-
- DEBUG (
- (EFI_D_ERROR,
- "SockGroup: Get the access for socket failed with %r",
- Status)
- );
-
- return EFI_ACCESS_DENIED;
- }
-
- if (SOCK_IS_UNCONFIGURED (Sock)) {
- Status = EFI_NOT_STARTED;
- goto Exit;
- }
-
- Status = Sock->ProtoHandler (Sock, SOCK_GROUP, GroupInfo);
-
-Exit:
- EfiReleaseLock (&(Sock->Lock));
- return Status;
-}
-
-/**
Add or remove route information in IP route table associated
with this socket.
@param[in] Sock Pointer to the socket associated with the IP route
table to operate on.
diff --git a/NetworkPkg/TcpDxe/Socket.h b/NetworkPkg/TcpDxe/Socket.h
index f7f4a7a..26c5f4e 100644
--- a/NetworkPkg/TcpDxe/Socket.h
+++ b/NetworkPkg/TcpDxe/Socket.h
@@ -1,9 +1,9 @@
/** @file
Common head file for TCP socket.
- Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php.
@@ -898,29 +898,10 @@ SockGetMode (
IN SOCKET *Sock,
IN OUT VOID *Mode
);
/**
- Configure the low level protocol to join a multicast group for
- this socket's connection.
-
- @param[in] Sock Pointer to the socket of the connection to join the
- specific multicast group.
- @param[in] GroupInfo Pointer to the multicast group information.
-
- @retval EFI_SUCCESS The configuration completed successfully.
- @retval EFI_ACCESS_DENIED Failed to get the lock to access the socket.
- @retval EFI_NOT_STARTED The socket is not configured.
-
-**/
-EFI_STATUS
-SockGroup (
- IN SOCKET *Sock,
- IN VOID *GroupInfo
- );
-
-/**
Add or remove route information in IP route table associated
with this socket.
@param[in] Sock Pointer to the socket associated with the IP route
table to operate on.
--
1.9.5.msysgit.1
next prev parent reply other threads:[~2017-12-22 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 7:07 [Patch 0/3] NetworkPkg/TcpDxe: Fix some issues in TcpDxe driver Jiaxin Wu
2017-12-22 7:07 ` [Patch 1/3] NetworkPkg/TcpDxe: Check FragmentBuffer for NULL before use Jiaxin Wu
2017-12-22 7:18 ` Fu, Siyuan
2017-12-22 7:07 ` Jiaxin Wu [this message]
2017-12-22 7:18 ` [Patch 2/3] NetworkPkg/TcpDxe: Remove the redundant code Fu, Siyuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513926438-4160-3-git-send-email-jiaxin.wu@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox