From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4101321CB87A5 for ; Mon, 25 Dec 2017 22:30:27 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Dec 2017 22:35:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,458,1508828400"; d="scan'208";a="190005806" Received: from jiaxinwu-mobl2.ccr.corp.intel.com ([10.239.196.165]) by fmsmga006.fm.intel.com with ESMTP; 25 Dec 2017 22:35:20 -0800 From: Jiaxin Wu To: edk2-devel@lists.01.org Cc: Wang Fan , Ye Ting , Fu Siyuan , Wu Jiaxin Date: Tue, 26 Dec 2017 14:35:13 +0800 Message-Id: <1514270114-5776-2-git-send-email-jiaxin.wu@intel.com> X-Mailer: git-send-email 1.9.5.msysgit.1 In-Reply-To: <1514270114-5776-1-git-send-email-jiaxin.wu@intel.com> References: <1514270114-5776-1-git-send-email-jiaxin.wu@intel.com> Subject: [Patch 1/2] NetworkPkg/HttpDxe: Fix the memory leak issue in HttpRequest(). X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Dec 2017 06:30:27 -0000 Cc: Wang Fan Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/HttpDxe/HttpImpl.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/NetworkPkg/HttpDxe/HttpImpl.c b/NetworkPkg/HttpDxe/HttpImpl.c index 57fa39f..fe1c3b7 100644 --- a/NetworkPkg/HttpDxe/HttpImpl.c +++ b/NetworkPkg/HttpDxe/HttpImpl.c @@ -470,10 +470,12 @@ EfiHttpRequest ( Wrap->TcpWrap.Method = Request->Method; FreePool (HostName); + HttpUrlFreeParser (UrlParser); + // // Queue the HTTP token and return. // return EFI_SUCCESS; } else { @@ -654,10 +656,14 @@ EfiHttpRequest ( DispatchDpc (); if (HostName != NULL) { FreePool (HostName); } + + if (UrlParser != NULL) { + HttpUrlFreeParser (UrlParser); + } return EFI_SUCCESS; Error5: // @@ -697,11 +703,11 @@ Error1: FreePool (HostName); } if (Wrap != NULL) { FreePool (Wrap); } - if (UrlParser!= NULL) { + if (UrlParser != NULL) { HttpUrlFreeParser (UrlParser); } return Status; -- 1.9.5.msysgit.1