public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch 0/2] IScsiDxe: Remove unnecessary close for ExitBootServiceEvent.
@ 2018-01-02  5:58 Jiaxin Wu
  2018-01-02  5:58 ` [Patch 1/2] MdeModulePkg/IScsiDxe: " Jiaxin Wu
  2018-01-02  5:58 ` [Patch 2/2] NetworkPkg/IScsiDxe: " Jiaxin Wu
  0 siblings, 2 replies; 3+ messages in thread
From: Jiaxin Wu @ 2018-01-02  5:58 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ye Ting, Fu Siyuan, Wu Jiaxin

The close for ExitBootServiceEvent in IScsiOnExitBootService callback
function is unnecessary since it will be closed in ISCSI driver stop()
function, which is invoked when the transition from BS to RT.

This issue is recorded at
https://bugzilla.tianocore.org/show_bug.cgi?id=742.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>

Jiaxin Wu (2):
  MdeModulePkg/IScsiDxe: Remove unnecessary close for
    ExitBootServiceEvent.
  NetworkPkg/IScsiDxe: Remove unnecessary close for
    ExitBootServiceEvent.

 MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c | 3 +--
 NetworkPkg/IScsiDxe/IScsiMisc.c                     | 5 ++---
 2 files changed, 3 insertions(+), 5 deletions(-)

-- 
1.9.5.msysgit.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Patch 1/2] MdeModulePkg/IScsiDxe: Remove unnecessary close for ExitBootServiceEvent.
  2018-01-02  5:58 [Patch 0/2] IScsiDxe: Remove unnecessary close for ExitBootServiceEvent Jiaxin Wu
@ 2018-01-02  5:58 ` Jiaxin Wu
  2018-01-02  5:58 ` [Patch 2/2] NetworkPkg/IScsiDxe: " Jiaxin Wu
  1 sibling, 0 replies; 3+ messages in thread
From: Jiaxin Wu @ 2018-01-02  5:58 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ye Ting, Fu Siyuan, Wu Jiaxin

The close for ExitBootServiceEvent in IScsiOnExitBootService callback
function is unnecessary since it will be closed in ISCSI driver stop()
function, which is invoked when the transition from BS to RT.

This issue is recorded at
https://bugzilla.tianocore.org/show_bug.cgi?id=742.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
index ae202c3..166fb4d 100644
--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
@@ -1,9 +1,9 @@
 /** @file
   Miscellaneous routines for iSCSI driver.
 
-Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php
 
@@ -870,11 +870,10 @@ IScsiOnExitBootService (
   )
 {
   ISCSI_DRIVER_DATA *Private;
 
   Private = (ISCSI_DRIVER_DATA *) Context;
-  gBS->CloseEvent (Private->ExitBootServiceEvent);
 
   IScsiSessionAbort (&Private->Session);
 }
 
 /**
-- 
1.9.5.msysgit.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Patch 2/2] NetworkPkg/IScsiDxe: Remove unnecessary close for ExitBootServiceEvent.
  2018-01-02  5:58 [Patch 0/2] IScsiDxe: Remove unnecessary close for ExitBootServiceEvent Jiaxin Wu
  2018-01-02  5:58 ` [Patch 1/2] MdeModulePkg/IScsiDxe: " Jiaxin Wu
@ 2018-01-02  5:58 ` Jiaxin Wu
  1 sibling, 0 replies; 3+ messages in thread
From: Jiaxin Wu @ 2018-01-02  5:58 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ye Ting, Fu Siyuan, Wu Jiaxin

The close for ExitBootServiceEvent in IScsiOnExitBootService callback
function is unnecessary since it will be closed in ISCSI driver stop()
function, which is invoked when the transition from BS to RT.

This issue is recorded at
https://bugzilla.tianocore.org/show_bug.cgi?id=742.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 NetworkPkg/IScsiDxe/IScsiMisc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c
index 9e4164c..cfa8b29 100644
--- a/NetworkPkg/IScsiDxe/IScsiMisc.c
+++ b/NetworkPkg/IScsiDxe/IScsiMisc.c
@@ -1,9 +1,9 @@
 /** @file
   Miscellaneous routines for iSCSI driver.
 
-Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php
 
@@ -2483,12 +2483,11 @@ IScsiOnExitBootService (
   )
 {
   ISCSI_DRIVER_DATA *Private;
 
   Private = (ISCSI_DRIVER_DATA *) Context;
-  gBS->CloseEvent (Private->ExitBootServiceEvent);
-
+  
   if (Private->Session != NULL) {
     IScsiSessionAbort (Private->Session);
   }
 }
 
-- 
1.9.5.msysgit.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-01-02  5:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-02  5:58 [Patch 0/2] IScsiDxe: Remove unnecessary close for ExitBootServiceEvent Jiaxin Wu
2018-01-02  5:58 ` [Patch 1/2] MdeModulePkg/IScsiDxe: " Jiaxin Wu
2018-01-02  5:58 ` [Patch 2/2] NetworkPkg/IScsiDxe: " Jiaxin Wu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox