public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Wang Fan <fan.wang@intel.com>
To: edk2-devel@lists.01.org
Cc: Fu Siyuan <siyuan.fu@intel.com>, Jiaxin Wu <jiaxin.wu@intel.com>,
	Hao Wu <hao.a.wu@intel.com>
Subject: [Patch] MdeModulePkg/DxeNetLib: Add array range check in NetIp6IsNetEqual().
Date: Thu, 11 Jan 2018 10:38:43 +0800	[thread overview]
Message-ID: <1515638323-13024-1-git-send-email-fan.wang@intel.com> (raw)

* The library API use array elements without any index range check, this
  patch is to fix this issue to avoid null pointer reference.

Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wang Fan <fan.wang@intel.com>
---
 MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
index cbce28f..34e11a8 100644
--- a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
+++ b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
@@ -840,10 +840,14 @@ NetIp6IsNetEqual (
   }
 
   if (Bit > 0) {
     Mask = (UINT8) (0xFF << (8 - Bit));
 
+    ASSERT (Byte < 16);
+    if (Byte >= 16) {
+      return FALSE;
+    }
     if ((Ip1->Addr[Byte] & Mask) != (Ip2->Addr[Byte] & Mask)) {
       return FALSE;
     }
   }
 
-- 
1.9.5.msysgit.1



             reply	other threads:[~2018-01-11  2:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11  2:38 Wang Fan [this message]
2018-01-11  5:39 ` [Patch] MdeModulePkg/DxeNetLib: Add array range check in NetIp6IsNetEqual() Wu, Hao A
2018-01-11  7:47 ` Wu, Jiaxin
2018-01-11  8:06   ` Wang, Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515638323-13024-1-git-send-email-fan.wang@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox