From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.1.81; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10081.outbound.protection.outlook.com [40.107.1.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8A0472222C226 for ; Fri, 26 Jan 2018 08:59:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xHvdM6InDcL6ntVyqLEagKNK9c492Ya8N+t1VlfxUIo=; b=QW32DVmnn06JAmI/az3U/rkvvmddEiuapMFAUoZmpwxElgtitWfOelojurZRMiBx1Sk0NPzKxjnfvHdAK+vFJroLC1I4Rvk0L0jKFgkoBkPhTMLGCJaUsZ/YbEn6cIoA9HlkFH/ikCQUOdeo59ZA7q3VH8M/NFKo/l1pBlrDKW0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=thomas.abraham@arm.com; Received: from a74716-lin.blr.arm.com (217.140.105.40) by DB6PR08MB2919.eurprd08.prod.outlook.com (2603:10a6:6:25::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Fri, 26 Jan 2018 17:05:22 +0000 From: Thomas Abraham To: edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org Date: Fri, 26 Jan 2018 22:34:59 +0530 Message-Id: <1516986299-1616-1-git-send-email-thomas.abraham@arm.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [217.140.105.40] X-ClientProxiedBy: PN1PR01CA0106.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::22) To DB6PR08MB2919.eurprd08.prod.outlook.com (2603:10a6:6:25::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b6dea9f5-b544-410f-d812-08d564defccc X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR08MB2919; X-Microsoft-Exchange-Diagnostics: 1; DB6PR08MB2919; 3:FL1Tc7q8vd4gPYs0xIO0mADcgtgI/rqDsZmQyt+aCwByTMC57wmSuY5RLIYjn1rd1vIz+zh8D2+cBSd7EINNpROLClEhWJJalwhCFQ40Y7OqqgTHtOuwKm7VNYW7vFpg6zoJ4H8h9V2FpS3WSOR3wZc5OXMnPAFs9GQLHFBlyKwJ5UfkC3VzFh2oXsVZO7npQOZlmDR1hV+xSGGhkGh3B0/O2iy+b+aZFTUrob2RT6BfO/UKyfXyfIanmne91MvN; 25:lz7LA26WVt4hY1YXVViw0JoQNdG+V3MIP+jw540vz1vd267n+9IBrRNgXLH8Z3KMxK9Nsg2mgr/Li+reXKUyicEs6TUgjUZA7jZqACG5oiwgnp4cAyejl7SQW9lPd7Nu3bP2TBunZ/n21zUPkXnfppK5yCmYiAmj1eFRcqBgZWn73xf07OJnCimBRFsPH8XfeHB/cJXRHCp2doH0k6SUJO3vGBEZ7xSWxlo/+3XW9A5Lx2LxTpddFuptJZZT7GHzS7Hh682j5zT5/+zOJk0PZZTsnF8v1WEBOpoggd6Q4J9SLwGmaQLokJUmuFI3yqM1Jg0BkxVc8/UOoT4kCaYEyw==; 31:D4O94vtsXLcMnpJUFGBfut3IybrsML0dEf1v+VTeBj+HgdHIiaPU8F3L+DkQllZFkQ7qnDhArEkMtIhLxN+6W3QrGmfn/XjB9dLIn6dQX7LWW5G3r8vVwQDdD29QAKJKGtqFbkerIwilkuYtKS2YQDVjS0+YTtqg2VzGndM3Nx5NO77ZV/hhccnBqyqqDW8Y4weogbk7MelATtTX2nCyap06pwU242n3cdxIbgtwjy0= X-MS-TrafficTypeDiagnostic: DB6PR08MB2919: X-Microsoft-Exchange-Diagnostics: 1; DB6PR08MB2919; 20:bCyhmt/MX1gjLH26Tgh7v9innxk87/jDFulqzDAhdsYb9v3g+nz01hE9cxckv6mF74//6hjKI3N1bycRCLJHozVypOWkYPlKD10kKrGqOzFY5kdQBYXGH1seZGUj5Pq/NWXYxWzW8Bwh0mr6Fd1YJl4RrkOu0YvY1nfYn/EEoVfcJ9BJ7iQramHWJHr5Bta0Co8Li07vC9riF7QbXY70bzBVUPUcf+ApslSvKP/6LiPXmbiSx/QFaMowzosl8pVlOgcj3zm0uoA5gWvXtc7ABOBb6Wvtx8X1vJA5Kf7FvGXjBgzbzCXNO20xi8kdokceRWfmgK1wuZUaLxNycBDJ/MYrqrMqbWvI7Ey+PkISolWBHsgjo2f84brPsZOPI9wmFVY6xnU4rLeTorg+I86Dsdp2Yg7ZtZnI3LCI/hADJzjG2KgLgM/hxE9CoNJc5H25E66fNllmgZ9MItvH+b8R4O0P8k1OwBF4pD/FfO7pbNWfjtYjahj/dcprtnd3y3FW; 4:EhJs/t65daNZr04Mk9Xn4mwIjOqgO55xFEPBgtHNJeJimvJhq06iDymZ2UD4DVZXIgMD91gSrFxO7Hd8YNbp3tiuSBTJKU9E67H/TWc8iuz3abWn6dpfqJyC37v+2R3NQOBUIH1aOHyyjb/CBZ3Nb4kMrvoUbHz7efekANAeYQoqbnPQFWTurXWBOSlKxbmjgvy+r0pi/X/ss64tiVWZSVbjXOYEF3pkefxpbR0bouX3QAqEqP4zX1NhC6fiJk7ueqkipDdP8HJ8ZX/5bWmKa0GYqqeXeuGZaMRgBzcV9gTlb4TLt9aViGbCFIwhPP7a X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231074)(2400081)(944501161)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041288)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB6PR08MB2919; BCL:0; PCL:0; RULEID:; SRVR:DB6PR08MB2919; X-Forefront-PRVS: 05641FD966 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(376002)(39380400002)(366004)(39860400002)(189003)(199004)(40434004)(8936002)(5890100001)(6666003)(8746002)(386003)(6486002)(50226002)(6916009)(59450400001)(68736007)(106356001)(36756003)(2351001)(81156014)(8676002)(316002)(48376002)(478600001)(2361001)(81166006)(97736004)(105586002)(7736002)(305945005)(86362001)(50466002)(186003)(2906002)(26005)(5660300001)(51416003)(7696005)(6116002)(3846002)(47776003)(52116002)(25786009)(66066001)(4326008)(53936002)(16526019); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR08MB2919; H:a74716-lin.blr.arm.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR08MB2919; 23:GpGVwmG2KyQxxD92/PG0rg3wE4hyzrnhZkkofHoAz?= =?us-ascii?Q?vVm7kDFP6Y/CoONW6miI0eRXvW9ZTYipyMpN4bK9gg8NG+Jb8C2VYYy2mVWh?= =?us-ascii?Q?JWzUz9OxmizvAu1kioDQxk+ulCbGLBlO8YZcoZgkuE7wDGMhFLRHjg3Jlu85?= =?us-ascii?Q?V4rezT3MOBZZ3LQbww2J79pN6Hxt00Z2SYrlpLgAX0k2BUAp+9maVv0l5V99?= =?us-ascii?Q?4uw6mX0r0Uui02mglZSEm8vApX854FH7k0Ma2KTDEXpTXJZRp/Gv4ax/R3fR?= =?us-ascii?Q?+tq32lPSky+vtL84fNXTtGDAa+tHRdd3dpXUzUCNfG0WjJSIBhPtoVBUPROA?= =?us-ascii?Q?ZN4plvPeM5V9erg/lWPLn3ZjXMSVDmKy9GYo0Fm35qBzVX/0DYS3XPA/qVOO?= =?us-ascii?Q?q4l/WPVMBJS55aO/fcRFrzRDRbikNzL6k5GtQPXfsXypA5YDmB8hZOucY7Zs?= =?us-ascii?Q?EcNx5/eeRMAdvaVj3zFgurlr5gv7JJwxsLEKqAmoSNTi1Dsh7/gfmi9PsN93?= =?us-ascii?Q?JO+pxPkGFsx9ZKCF1aizgU07lUly/chmR+1fiJ7iPvHZl6atGKUcj2eglGyV?= =?us-ascii?Q?dDyzsqwOUWEYeeN4qPA2+JVhzVvQ+FgFuaFV0uxX98qfmxv5bOYSIY/bKHVl?= =?us-ascii?Q?QC3lt+UP7jHQmRNNe2jerxTzR4QCMFRTUWL0Dq6fna2uHqDZnQ4Jp33Mpt+c?= =?us-ascii?Q?SgWdfsvpBc/RDpV/0qtUnrh/ou9v2rpj8PGLidDTvpi+w0gaVYp99auczFh/?= =?us-ascii?Q?jbNfw7UMA/AS+9p5ReR+zJvxBD/b80a2usDSJ1P0U8LFEJfxaaFTx6wzaZ/Z?= =?us-ascii?Q?9PUvusCeP9u7KRefdmh1XLlBgsWftcMItW47MEcOCet3sfCoT2wLn0NMNvzO?= =?us-ascii?Q?M0VxhGvASlkipa3AM2qqCqIGLFc39e/mg2WrboLAwMrh0938wtD90pZtDeCb?= =?us-ascii?Q?BBcgbonsh/Smna5SZXgQSt+Y1JquhEoJ5cTJWi6SgxjKPvcRkuXjPOzKM0uq?= =?us-ascii?Q?KJJ3wzUzOotLukyAV4RkSzbKdhXlQeH2QfvuCGgp5U2OHksIKcku2LT9N7l0?= =?us-ascii?Q?90OBDkjg/KpNAdWX5NKbKc5FXmD9ienDDWXHH61DcGb9WUAjwhmZcva+C1yT?= =?us-ascii?Q?xJG+mlvu8wmxV0x3bztCWXQSKfLvBPW?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR08MB2919; 6:AyVdZ5/YvtPLnLzAVyzWlypcNZGl9jKQiIT85efwZhSIXdHBpwZ+ExEp/jph+F5nJerw2m319jS21O9tdvw5RkEEzYnXWl+FnHL80YY47mPmRbAX7mH++o3jom3WPVd5NVnkuZsUBQsQk1IhINMhb9KEzAejJNFBcB8rgE3fh/K+AHUaNnIkGdKN33j/JUBuu9UgVwPTd5lWkGFm91tktsAMBxx9bTqHe6aAjEBi5sdvjnSuxInP+GQ6sEYKxd9ms8dWNdhZwPP36Rf1hbESr8U5lntuKWS0VMgWyqQDezJM1ybstTyKWhmyBqZKP1VNqzLS2BWk+f6JAHUuBI0TqwqZhLnfHN4HdM7dQ0RummI=; 5:zhGZRfqqXQ9LHJCZvvSUca+gT0VUh+bOOO47yHV+GPmAIpGVmLhtujcCKwvfSNp8sLbfVXUyyAe/FlX/EOJefCH2OB31YvhTXB+6Mn9Vb9GAh6Gpb9+AATdBtCoGIt4gdUA1jZtpkb4anKuj4c4UIZmDmRmiiMZkkWFrYZlu8u0=; 24:gdT+W4dU3Z9YX7kCpMDeIcL3GY6DowP9cWhb7Koo0GMQVtMELd/ZFVIzgv6Oz3LomBcVTIs76CBaWx5CkRisY2FCysRvKDq/2Zw+v0Hz/PU=; 7:FLX05T6uWKt9SrvPDIk9A7xmlqenlP7A3tqTxRjunCV1c00WWS4RcerO4g3y0ehYqlJa9ODR/E2fYlh6oe2bqoDpEK5p2oC1kLpqXVPbindsGSyzk4FkDq+nStrYjkKgGdMg8cIdTDJ62Vq5c+0WA9eSXpegIEWqKMbKCeJxW8GdXcy/ZUg1jFXRe85qa/fDLEDcTD+rzwkTx/42VSZZ+ib+Mxg+AmNdTDiDml4w/kyqGI0peKunoNCdI992SKt1 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2018 17:05:22.1937 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6dea9f5-b544-410f-d812-08d564defccc X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2919 Subject: [PATCH] Platform/ARM/VExpress: refine the check for DVI support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 16:59:56 -0000 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable The base models could have different values for the revision ID field in the System ID register. Base models do not have support for DVI and so the revision ID field should also be masked out when checking for the presence of DVI support. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Abraham --- .../VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | = 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111L= cdArmVExpress.c b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/P= L111LcdArmVExpress.c index 3f3ceb3..89ba130 100644 --- a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVE= xpress.c +++ b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVE= xpress.c @@ -264,7 +264,7 @@ LcdPlatformSetMode ( SysId =3D MmioRead32 (ARM_VE_SYS_ID_REG); if (SysId !=3D ARM_RTSM_SYS_ID) { // Take out the FVP GIC variant to reduce the permutations. - SysId &=3D ~ARM_FVP_SYS_ID_VARIANT_MASK; + SysId &=3D ~(ARM_FVP_SYS_ID_VARIANT_MASK | ARM_FVP_SYS_ID_REV_MASK); if (SysId !=3D ARM_FVP_BASE_BOARD_SYS_ID) { // Set the DVI into the new mode Status =3D ArmPlatformSysConfigSet (SYS_CFG_DVIMODE, mResolutions[Mo= deNumber].Mode); -- 2.7.4 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.