public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Liming Gao <liming.gao@intel.com>
To: edk2-devel@lists.01.org
Subject: [Patch] BaseTools CommonLib: Remove the unnecessary print message in PcdValueCommon
Date: Wed, 31 Jan 2018 17:03:37 +0800	[thread overview]
Message-ID: <1517389417-25112-1-git-send-email-liming.gao@intel.com> (raw)

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Source/C/Common/PcdValueCommon.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/BaseTools/Source/C/Common/PcdValueCommon.c b/BaseTools/Source/C/Common/PcdValueCommon.c
index 92328da..210f87b 100644
--- a/BaseTools/Source/C/Common/PcdValueCommon.c
+++ b/BaseTools/Source/C/Common/PcdValueCommon.c
@@ -330,9 +330,7 @@ Returns:
     break;
   case PcdDataTypePointer:
     Value = &PcdList[Index].Value[1];
-    printf ("Value = %s\n", PcdList[Index].Value);
     for (*Size = 0, Byte = (UINT8) strtoul(Value, &End, 16); Value != End; Byte = (UINT8) strtoul(Value, &End, 16), *Size = *Size + 1) {
-      printf("%x\n", Byte);
       Value = End + 1;
     }
     Buffer = malloc(*Size + 1);
@@ -401,7 +399,6 @@ Returns:
     PcdList[Index].Value = malloc(Size * 5 + 3);
     PcdList[Index].Value[0] = '{';
     for (ValueIndex = 0; ValueIndex < Size; ValueIndex++) {
-      printf("Value[%d] = %02x\n", ValueIndex, Value[ValueIndex]);
       sprintf(&PcdList[Index].Value[1 + ValueIndex * 5], "0x%02x,", Value[ValueIndex]);
     }
     PcdList[Index].Value[1 + Size * 5 - 1] = '}';
@@ -724,15 +721,11 @@ Returns:
   if (*InputFileName == NULL) {
     fprintf (stderr, "Missing option.  Input files is not specified\n");
     exit (EXIT_FAILURE);
-  } else {
-    printf ("Input file name is %s\n", *InputFileName);
   }
 
   if (*OutputFileName == NULL) {
     fprintf (stderr, "Missing option.  Output file is not specified\n");
     exit (EXIT_FAILURE);
-  } else {
-    printf ("Output file name is %s\n", *OutputFileName);
   }
 }
 
@@ -761,7 +754,6 @@ Returns:
   UINT8   *FileBuffer;
   UINT32  FileSize;
 
-  printf ("PCD tool start.\n");
   InputFileName = NULL;
   OutputFileName = NULL;
 
@@ -790,7 +782,5 @@ Returns:
   //
   WriteOutputFile (OutputFileName);
 
-  printf ("PCD tool done.\n");
-
   exit (EXIT_SUCCESS);
 }
-- 
2.8.0.windows.1



             reply	other threads:[~2018-01-31  8:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31  9:03 Liming Gao [this message]
2018-01-31 10:39 ` [Patch] BaseTools CommonLib: Remove the unnecessary print message in PcdValueCommon Zhu, Yonghong
2018-02-01  8:18   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517389417-25112-1-git-send-email-liming.gao@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox