From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CC3112238B585 for ; Wed, 31 Jan 2018 07:55:19 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2018 08:00:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,440,1511856000"; d="scan'208";a="200132457" Received: from shwdeopenpsi168.ccr.corp.intel.com ([10.239.158.129]) by fmsmga005.fm.intel.com with ESMTP; 31 Jan 2018 08:00:55 -0800 From: Yonghong Zhu To: edk2-devel@lists.01.org Cc: Liming Gao , Michael Kinney , Kevin W Shaw Date: Thu, 1 Feb 2018 00:00:46 +0800 Message-Id: <1517414448-4012-3-git-send-email-yonghong.zhu@intel.com> X-Mailer: git-send-email 2.6.1.windows.1 In-Reply-To: <1517414448-4012-1-git-send-email-yonghong.zhu@intel.com> References: <1517414448-4012-1-git-send-email-yonghong.zhu@intel.com> Subject: [Patch] DSC spec: Add flexible PCD value format into spec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 15:55:20 -0000 Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 3_edk_ii_dsc_file_format/310_pcd_sections.md | 160 +++++++++++++-------- .../33_platform_dsc_definition.md | 74 +++++++--- 2 files changed, 157 insertions(+), 77 deletions(-) diff --git a/3_edk_ii_dsc_file_format/310_pcd_sections.md b/3_edk_ii_dsc_file_format/310_pcd_sections.md index 2af42cc..18a243d 100644 --- a/3_edk_ii_dsc_file_format/310_pcd_sections.md +++ b/3_edk_ii_dsc_file_format/310_pcd_sections.md @@ -98,13 +98,11 @@ is permissible to list multiple architectures in a single method section as in: It is permissible to list a PCD in a common architecture section and also list it in an architecturally modified section. In this case, the value in the architectural section overrides the value specified in the common section. The PCD values must match the datum type declared for a given PCD in the DEC -file. While a PCD of datum type `BOOLEAN` is permitted to have a `1` or a `0` -(instead of TRUE or FALSE) in the value field, a PCD of type UINT* cannot use -`TRUE` or `FALSE` for values. +file. PCDs with a data type of `VOID`* can optionally provide the maximum size of the value. If not provided, the maximum length will be calculated as the largest of the size of the data in the DSC file, the size of the data in the INF file or the size of the data in the DEC file that declares the PCD. @@ -220,21 +218,24 @@ fields that are separated by the pipe character, "|". ::= [ ]* ::= ::= ::= {} {} {} ::= [ ] - ::= if (pcddatumtype == "BOOLEAN"): {} {} - elif (pcddatumtype == "UINT8"): {} - {} elif (pcddatumtype == "UINT16"): - {} {} elif (pcddatumtype == - "UINT32"): {} {} elif - (pcddatumtype == "UINT64"): {} {} + ::= if (pcddatumtype == "BOOLEAN"): + {} {} + elif (pcddatumtype == "UINT8"): + {} {} + elif (pcddatumtype == "UINT16"): + {} {} + elif (pcddatumtype == "UINT32"): + {} {} + elif (pcddatumtype == "UINT64"): + {} {} else: - [] + [] ::= "VOID*" {} {} - ::= {} {} {} - {} {} + ::= {} {} {} ``` #### Parameters **_Expression_** @@ -325,21 +326,24 @@ of the DSC file. ::= [ ]* ::= ::= ::= {} {} {} ::= [ ] - ::= if (pcddatumtype == "BOOLEAN"): {} {} - elif (pcddatumtype == "UINT8"): {} - {} elif (pcddatumtype == "UINT16"): - {} {} elif (pcddatumtype == - "UINT32"): {} {} elif - (pcddatumtype == "UINT64"): {} {} + ::= if (pcddatumtype == "BOOLEAN"): + {} {} + elif (pcddatumtype == "UINT8"): + {} {} + elif (pcddatumtype == "UINT16"): + {} {} + elif (pcddatumtype == "UINT32"): + {} {} + elif (pcddatumtype == "UINT64"): + {} {} else: - [] + [] ::= {} {} - ::= {} {} {} - {} {} + ::= {} {} {} ``` #### Parameters **_Expression_** @@ -458,41 +462,58 @@ sections of the DSC file. ::= "." ["." ] ::= [ ]* ::= ::= ::= [ ] - ::= if (pcddatumtype == "BOOLEAN"): {} {} - elif (pcddatumtype == "UINT8"): {} - {} elif (pcddatumtype == "UINT16"): - {} {} elif (pcddatumtype == - "UINT32"): {} {} elif - (pcddatumtype == "UINT64"): {} - {} else: - [] + ::= if (pcddatumtype == "BOOLEAN"): + {} {} + elif (pcddatumtype == "UINT8"): + {} {} + elif (pcddatumtype == "UINT16"): + {} {} + elif (pcddatumtype == "UINT32"): + {} {} + elif (pcddatumtype == "UINT64"): + {} {} + else: + [] ::= "VOID*" [ ] ::= {} {} - ::= {} {} {} {} - {} + ::= {} {} {} ::= [ ] ::= {} {"*"} - ::= if (pcddatumtype == "BOOLEAN"): {} {} - elif (pcddatumtype == "UINT8"): {} - {} elif (pcddatumtype == "UINT16"): - {} {} elif (pcddatumtype == - "UINT32"): {} {} elif - (pcddatumtype == "UINT64"): {} - {} else: - + ::= if (pcddatumtype == "BOOLEAN"): + {} {} + elif (pcddatumtype == "UINT8"): + {} {} + elif (pcddatumtype == "UINT16"): + {} {} + elif (pcddatumtype == "UINT32"): + {} {} + elif(pcddatumtype == "UINT64"): + {} {} + else: + ::= [ ] ::= ::= {} {} ::= [] ::= ::= [ ] ::= - ::= {} {} {} {} - {} {} + ::= if (pcddatumtype == "BOOLEAN"): + {} {} + elif (pcddatumtype == "UINT8"): + {} {} + elif (pcddatumtype == "UINT16"): + {} {} + elif (pcddatumtype == "UINT32"): + {} {} + elif (pcddatumtype == "UINT64"): + {} {} + else: + ::= [ ]* ::= {"NV"} {"BS"} {"RT"} {"RO"} ``` #### Parameters @@ -618,41 +639,58 @@ sections of the DSC file. ::= "." ["." ] ::= [ ]* ::= ::= ::= [ ] - ::= if (pcddatumtype == "BOOLEAN"): {} {} - elif (pcddatumtype == "UINT8"): {} - {} elif (pcddatumtype == "UINT16"): - {} {} elif (pcddatumtype == - "UINT32"): {} {} elif - (pcddatumtype == "UINT64"): {} - {} else: - [] + ::= if (pcddatumtype == "BOOLEAN"): + {} {} + elif (pcddatumtype == "UINT8"): + {} {} + elif (pcddatumtype == "UINT16"): + {} {} + elif (pcddatumtype == "UINT32"): + {} {} + elif (pcddatumtype == "UINT64"): + {} {} + else: + [] ::= "VOID*" [ ] ::= {} {} - ::= {} {} {} {} - {} + ::= {} {} {} ::= [ ] ::= {} {"*"} - ::= if (pcddatumtype == "BOOLEAN"): {} {} - elif (pcddatumtype == "UINT8"): {} - {} elif (pcddatumtype == "UINT16"): - {} {} elif (pcddatumtype == - "UINT32"): {} {} elif - (pcddatumtype == "UINT64"): {} - {} else: - + ::= if (pcddatumtype == "BOOLEAN"): + {} {} + elif (pcddatumtype == "UINT8"): + {} {} + elif (pcddatumtype == "UINT16"): + {} {} + elif (pcddatumtype == "UINT32"): + {} {} + elif (pcddatumtype == "UINT64"): + {} {} + else: + ::= [ ] ::= ::= {} {} ::= [] ::= ::= [ ] ::= - ::= {} {} {} {} - {} {} + ::= if (pcddatumtype == "BOOLEAN"): + {} {} + elif (pcddatumtype == "UINT8"): + {} {} + elif (pcddatumtype == "UINT16"): + {} {} + elif (pcddatumtype == "UINT32"): + {} {} + elif(pcddatumtype == "UINT64"): + {} {} + else: + ::= [ ]* ::= {"NV"} {"BS"} {"RT"} {"RO"} ``` #### Parameters diff --git a/3_edk_ii_dsc_file_format/33_platform_dsc_definition.md b/3_edk_ii_dsc_file_format/33_platform_dsc_definition.md index bfe730c..618f681 100644 --- a/3_edk_ii_dsc_file_format/33_platform_dsc_definition.md +++ b/3_edk_ii_dsc_file_format/33_platform_dsc_definition.md @@ -112,15 +112,16 @@ The following are common definitions used by multiple section types. ::= (0-9) ::= (a-zA-Z_) ::= [ ]* ::= # A valid C variable name. ::= (0x21 - 0x7E) - ::= [{0x21} {(0x23 - 0x5B)} {(0x5D - 0x7E)} - {}]* + ::= [{0x21} {(0x23 - 0x26)} {(0x28 - 0x5B)} + {(0x5D - 0x7E)} {}]* ::= 0x22 + ::= 0x27 ::= "\" {"n"} {"t"} {"f"} {"r"} {"b"} {"0"} {"\"} - {} + {} {} ::= {} {} ::= * ::= + ::= 0x09 ::= 0x20 @@ -138,15 +139,16 @@ The following are common definitions used by multiple section types. ::= [ * * ]* ::= ::= ::= {} {} ::= * - ::= ["L"] + ::= * + ::= {} {} ::= [{} {}]+ ::= "#" [] + ::= "#" + - ::= "L" + ::= "L" {} {} ::= (a-fA-F0-9) ::= {"0x"} {"0X"} [] ::= {"0x"} {"0X"} + ::= "0x" [0]* ::= ? ? ? @@ -184,11 +186,12 @@ The following are common definitions used by multiple section types. ::= (\x1 - \xFFFFFFFFFFFFFFFF) ::= (1-18446744073709551615) ::= {} {} ::= {"TRUE"} {"true"} {"True"} {"0x1"} {"0x01"} {"1"} ::= {"FALSE"} {"false"} {"False"} {"0x0"} {"0x00"} {"0"} - ::= {} {} + ::= {} {} + ::= {} {"{""}"} ::= (A-Z)(A-Z0-9_)* ::= "$(" ")" ::= "." ::= ::= @@ -210,14 +213,45 @@ The following are common definitions used by multiple section types. ::= (0-255) ::= (0-65535) ::= (0-4294967295) ::= (0-18446744073709551615) - ::= {} {} - ::= {} {} - ::= {} {} - ::= {} {} + ::= {} {} {} + {} {} + ::= {} {} {} + {} {} + ::= {} {} {} + {} {} + ::= {} {} {} + {} {} + ::= {} {"{""}"} + ::= {} + {"{" [ ]*"}"} + ::= {} + {"{" [ ]*"}"} + ::= {} + {"{" [ ]*"}"} + ::= {} {} {} + ::= "{"[] + [ [] ]*"}" + ::= {} {} {} + ::= {} {} {} {} + {} {} + ::= "GUID(" ")" + ::= { } + {} {} + ::= "DEVICE_PATH(" ")" + ::= A double quoted string that follow the device path + as string format defined in UEFI Specification 2.6 + Section 9.6 + ::= {} {} {} {} + ::= "UINT8(" ")" + ::= "UINT16(" ")" + ::= "UINT32(" ")" + ::= "UINT64(" ")" + ::= "LABEL(" ")" + ::= "OFFSET_OF(" ")" ::= {"BASE"} {"SEC"} {"PEI_CORE"} {"PEIM"} {"DXE_CORE"} {"DXE_DRIVER"} {"SMM_CORE"} {"DXE_RUNTIME_DRIVER"} {"DXE_SAL_DRIVER"} {"DXE_SMM_DRIVER"} {"UEFI_DRIVER"} {"UEFI_APPLICATION"} {"USER_DEFINED"} @@ -244,10 +278,18 @@ The following are common definitions used by multiple section types. {"SMM_CORE"} {"DXE_SMM_DRIVER"} {"UEFI_DRIVER"} {"UEFI_APPLICATION"} ``` ********** +**Note:** When using CString, UnicodeString or byte array format as +UINT8/UINT16/UINT32/UINT64 values, please make sure they fit in the +target type's size, otherwise tool would report failure. +********** +**Note:** LABEL() macro in byte arrays to tag the byte offset of a +location in a byte array. OFFSET_OF() macro in byte arrays that returns +the byte offset of a LABEL() declared in a byte array. +********** **Note:** When using the characters "|" or "||" in an expression, the expression must be encapsulated in open "(" and close ")" parenthesis. ********** **Note:** Comments may appear anywhere within a DSC file, provided they follow the rules that a comment may not be enclosed within Section headers, and that @@ -265,16 +307,16 @@ chain tag names that are being built. Refer to the EDK II Expression Syntax Specification for additional information. **_UnicodeString_** When the `` element (these characters are string literals as -defined by the C99 specification: L"string", not actual Unicode characters) is -included in a value, the build tools may be required to expand the ASCII string -between the quotation marks into a valid UCS-2 character string. The build -tools parser must treat all content between the field separators (excluding -white space characters around the field separators) as ASCII literal content -when generating the AutoGen.c and AutoGen.h files. +defined by the C99 specification: L"string"/L'string', not actual Unicode +characters) is included in a value, the build tools may be required to expand +the ASCII string between the quotation marks into a valid UCS-2 character string. +The build tools parser must treat all content between the field separators +(excluding white space characters around the field separators) as ASCII literal +content when generating the AutoGen.c and AutoGen.h files. **_Comments_** Strings that appear in comments may be ignored by the build tools. An ASCII string matching the format of the ASCII string defined by `` -- 2.6.1.windows.1