public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Meenakshi <meenakshi.aggarwal@nxp.com>
To: ruiyu.ni@intel.com, jaben.carsey@intel.com,
	edk2-devel@lists.01.org, lersek@redhat.com
Subject: [RFC] ShellPkg/Ping: fix loss of first packet
Date: Fri, 16 Feb 2018 14:15:11 +0530	[thread overview]
Message-ID: <1518770711-6331-1-git-send-email-meenakshi.aggarwal@nxp.com> (raw)

From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>

Issue:
Reply for first ping packet was getting dropped.

Cause:
Sometimes reply message comes even before trasmit
function returns, hence missing 1st reply

Fix:
Prepare the TxList before calling Transmit function.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
---
 ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
index bec9535..46ba701 100644
--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
@@ -784,14 +784,17 @@ PingSendEchoRequest (
   }
 
   ASSERT(Private->ProtocolPointers.Transmit != NULL);
+
+  InsertTailList (&Private->TxList, &TxInfo->Link);
+
   Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo->Token);
 
   if (EFI_ERROR (Status)) {
+    RemoveEntryList (&TxInfo->Link);
     PingDestroyTxInfo (TxInfo, Private->IpChoice);
     return Status;
   }
 
-  InsertTailList (&Private->TxList, &TxInfo->Link);
   Private->TxCount++;
 
   return EFI_SUCCESS;
-- 
1.9.1



             reply	other threads:[~2018-02-16  8:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16  8:45 Meenakshi [this message]
2018-02-16 15:20 ` [RFC] ShellPkg/Ping: fix loss of first packet Carsey, Jaben
2018-02-20  6:18   ` Meenakshi Aggarwal
2018-02-22  8:32     ` Ni, Ruiyu
2018-02-23  9:57       ` Meenakshi Aggarwal
2018-02-23 10:17         ` Laszlo Ersek
2018-02-23 10:26           ` Meenakshi Aggarwal
2018-02-23 12:01             ` Laszlo Ersek
2018-02-23 16:35               ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518770711-6331-1-git-send-email-meenakshi.aggarwal@nxp.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox