* [Patch] BaseTools: Add *B Flag for the field that from command line
@ 2018-02-23 5:07 Yonghong Zhu
2018-02-23 9:44 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Yonghong Zhu @ 2018-02-23 5:07 UTC (permalink / raw)
To: edk2-devel
For structure PCD, the field value may override in the command line,
so in the report when we print the field info we add *B Flag for those
field.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
BaseTools/Source/Python/build/BuildReport.py | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
index 53d0039..2114499 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -1234,18 +1234,14 @@ class PcdReport(object):
self.PrintPcdDefault(File, Pcd, IsStructure, DscMatch, DscDefaultValue, InfMatch, InfDefaultValue, DecMatch, DecDefaultValue)
def PrintStructureInfo(self, File, Struct):
NewInfo = collections.OrderedDict()
for Key, Value in Struct.items():
- if Key not in NewInfo:
- NewInfo[Key] = Value[0]
+ if Value[1] and 'build command options' in Value[1]:
+ FileWrite(File, ' *B %-*s = %s' % (self.MaxLen + 4, '.' + Key, Value[0]))
else:
- del NewInfo[Key]
- NewInfo[Key] = Value[0]
- if NewInfo:
- for item in NewInfo:
- FileWrite(File, ' %-*s = %s' % (self.MaxLen + 4, '.' + item, NewInfo[item]))
+ FileWrite(File, ' %-*s = %s' % (self.MaxLen + 4, '.' + Key, Value[0]))
def StrtoHex(self, value):
try:
value = hex(int(value))
return value
--
2.6.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] BaseTools: Add *B Flag for the field that from command line
2018-02-23 5:07 [Patch] BaseTools: Add *B Flag for the field that from command line Yonghong Zhu
@ 2018-02-23 9:44 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2018-02-23 9:44 UTC (permalink / raw)
To: Zhu, Yonghong, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Friday, February 23, 2018 1:07 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Add *B Flag for the field that from
>command line
>
>For structure PCD, the field value may override in the command line,
>so in the report when we print the field info we add *B Flag for those
>field.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index 53d0039..2114499 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -1234,18 +1234,14 @@ class PcdReport(object):
> self.PrintPcdDefault(File, Pcd, IsStructure, DscMatch,
>DscDefaultValue, InfMatch, InfDefaultValue, DecMatch, DecDefaultValue)
>
> def PrintStructureInfo(self, File, Struct):
> NewInfo = collections.OrderedDict()
> for Key, Value in Struct.items():
>- if Key not in NewInfo:
>- NewInfo[Key] = Value[0]
>+ if Value[1] and 'build command options' in Value[1]:
>+ FileWrite(File, ' *B %-*s = %s' % (self.MaxLen + 4, '.' + Key,
>Value[0]))
> else:
>- del NewInfo[Key]
>- NewInfo[Key] = Value[0]
>- if NewInfo:
>- for item in NewInfo:
>- FileWrite(File, ' %-*s = %s' % (self.MaxLen + 4, '.' + item,
>NewInfo[item]))
>+ FileWrite(File, ' %-*s = %s' % (self.MaxLen + 4, '.' + Key, Value[0]))
>
> def StrtoHex(self, value):
> try:
> value = hex(int(value))
> return value
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-23 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-23 5:07 [Patch] BaseTools: Add *B Flag for the field that from command line Yonghong Zhu
2018-02-23 9:44 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox