public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Heyi Guo <heyi.guo@linaro.org>
To: edk2-devel@lists.01.org
Cc: Heyi Guo <heyi.guo@linaro.org>, Ruiyu Ni <ruiyu.ni@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: [RFC v3 0/3] Add translation support to generic PciHostBridge
Date: Fri, 23 Feb 2018 16:53:25 +0800	[thread overview]
Message-ID: <1519376008-110662-1-git-send-email-heyi.guo@linaro.org> (raw)

Please note: this is still *RFC* version, so we have not gone thru all the code
in EDK2 for applying the change of PciSegmentLib definition.

v3:
1. Keep definition of Translation consistent in EDKII code: Translation = device
address - host address.
2. Patch 2/2 is split into 2 patches (2/3 and 3/3).
3. Refine comments and commit messages to make the code easier to understand.


v2:
Changs are made according to the discussion on the mailing list, including:

1. PciRootBridgeIo->Configuration should return CPU view address, as well as
PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view
address - CPU view address.

2. Add translation offset to PCI_ROOT_BRIDGE_APERTURE structure definition.

3. PciHostBridge driver internally used Base Address is still based on PCI view
address, and translation offset = CPU view - PCI view, which follows the
definition in ACPI, and not the same as that in UEFI spec.

This is still RFC version, so we have not gone thru all the code in EDK2 for
applying the change of PciSegmentLib definition.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>


Heyi Guo (3):
  MdeModulePkg/PciHostBridgeDxe: Add support for address translation
  MdeModulePkg/PciBus: convert host address to device address
  MdeModulePkg/PciBus: return CPU address for GetBarAttributes

 MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c             |  12 ++-
 .../Bus/Pci/PciHostBridgeDxe/PciHostBridge.c       |  74 +++++++++++---
 .../Bus/Pci/PciHostBridgeDxe/PciHostResource.h     |   2 +
 .../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c     | 112 ++++++++++++++++++---
 MdeModulePkg/Include/Library/PciHostBridgeLib.h    |   8 ++
 5 files changed, 177 insertions(+), 31 deletions(-)

-- 
2.7.4



             reply	other threads:[~2018-02-23  8:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23  8:53 Heyi Guo [this message]
2018-02-23  8:53 ` [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation Heyi Guo
2018-02-23 15:05   ` Laszlo Ersek
2018-02-23 15:17     ` Ard Biesheuvel
2018-02-23 15:26       ` Laszlo Ersek
2018-02-24  1:10     ` Guo Heyi
2018-02-24  1:51     ` Guo Heyi
2018-02-24  3:11       ` Ni, Ruiyu
2018-02-24  3:59         ` Guo Heyi
2018-02-24  8:30           ` Ni, Ruiyu
2018-02-24  9:15             ` Guo Heyi
2018-02-24  8:14         ` Ard Biesheuvel
2018-02-27  2:19     ` Guo Heyi
2018-02-23  8:53 ` [RFC v3 2/3] MdeModulePkg/PciBus: convert host address to device address Heyi Guo
2018-02-23  8:53 ` [RFC v3 3/3] MdeModulePkg/PciBus: return CPU address for GetBarAttributes Heyi Guo
2018-02-23 15:08   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519376008-110662-1-git-send-email-heyi.guo@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox