[Patch] BaseTools: Add more error message when PcdValue is wrong

[Patch] BaseTools: Add more error message when PcdValue is wrong

[Liming Gao]

For structure PCD, its field name is wrong and cause build failure. Its
build error message will output to let user aware what's wrong.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Feng Bob C <bob.c.feng@intel.com>
---
 BaseTools/Source/Python/Workspace/DscBuildData.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index 0c0603f..9909750 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -1964,6 +1964,8 @@ class DscBuildData(PlatformBuildClassObject):
                             message_itmes = Message.split(":")
                             Index = 0
                             if "PcdValueInit.c" not in Message:
+                                if not MessageGroup:
+                                    MessageGroup.append(Message)
                                 break
                             else:
                                 for item in message_itmes:
-- 
2.8.0.windows.1

Re: [Patch] BaseTools: Add more error message when PcdValue is wrong

[Zhu, Yonghong]

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
Sent: Monday, February 26, 2018 3:15 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] BaseTools: Add more error message when PcdValue is wrong

For structure PCD, its field name is wrong and cause build failure. Its build error message will output to let user aware what's wrong.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Feng Bob C <bob.c.feng@intel.com>
---
 BaseTools/Source/Python/Workspace/DscBuildData.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index 0c0603f..9909750 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -1964,6 +1964,8 @@ class DscBuildData(PlatformBuildClassObject):
                             message_itmes = Message.split(":")
                             Index = 0
                             if "PcdValueInit.c" not in Message:
+                                if not MessageGroup:
+                                    MessageGroup.append(Message)
                                 break
                             else:
                                 for item in message_itmes:
--
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel