From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::243; helo=mail-pl0-x243.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x243.google.com (mail-pl0-x243.google.com [IPv6:2607:f8b0:400e:c01::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5DC48209574EF for ; Mon, 26 Feb 2018 18:04:44 -0800 (PST) Received: by mail-pl0-x243.google.com with SMTP id s13so10466564plq.6 for ; Mon, 26 Feb 2018 18:10:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KY/TY1vQXahnUmVIDRxMzVNKvNFaI0EiawWm+wlL7A4=; b=HXr2a70ixIhw+KlLpKzPw0sFe2nspI4bvqBiicCzM8F/K+dAhA7WYTlJvgsZCW++6X B3MTTQO0CtZNiem8eOMewrltysUUH+uf8d4IzdcGoeLs4jdH/reVAvMH1G4kCK9RVMyZ ixs0zOEocgfLGnCBe73M1ZvU4zMEc73fU3NRo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KY/TY1vQXahnUmVIDRxMzVNKvNFaI0EiawWm+wlL7A4=; b=N9HB8U1kZrtXNqa+hFwHg73zes88XxHHmMDYd+sVD6Jz+G1qwo+GHYOzlJkTGvMicI UZQUgqds7O7oi5WLnnATWd4N+50ueXpQ7U6qio/MM9Hc5+bjojvjUYhyjNEe2SwcfGOo QgoXwfXhqGqNLkgnskWzM1+V1RL8eUdjUlw+x4gjBx3lHi2+s3meEwUzKPNtnsLXshVc t9ZGN5roHtEgUDmHp11T8CfqmGVumWkzvPuemBM87kPOFcrigzd6/IUmNHiDr6oaDXjM Ba2DaunQJtBzeIM6layyL4p9H9hidzTKvwUA1faGIkxv/1aoDmRH4QbSavKfLdme3+rt RlOg== X-Gm-Message-State: APf1xPAFCVpuT16O7ML+DfY7e01SncYLlVZri/wX+WwiVDyoPXAtSJDg Auly1Oz0nDAykJ8Mey1d0mJyGX7t5QU= X-Google-Smtp-Source: AH8x226hKCs+q46G4iZc1HPF9yN+P40jjFLWsTAB4Wo1uGOFpehTw5LqttV8e6VSM6Rui/r9tih5QA== X-Received: by 2002:a17:902:8f95:: with SMTP id z21-v6mr12618954plo.132.1519697449738; Mon, 26 Feb 2018 18:10:49 -0800 (PST) Received: from localhost.localdomain ([104.237.91.49]) by smtp.gmail.com with ESMTPSA id a138sm21289210pfd.47.2018.02.26.18.10.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 26 Feb 2018 18:10:49 -0800 (PST) From: Heyi Guo To: edk2-devel@lists.01.org Cc: Heyi Guo , Ruiyu Ni , Ard Biesheuvel , Star Zeng , Eric Dong , Laszlo Ersek , Michael D Kinney Date: Tue, 27 Feb 2018 10:09:49 +0800 Message-Id: <1519697389-3525-4-git-send-email-heyi.guo@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519697389-3525-1-git-send-email-heyi.guo@linaro.org> References: <1519697389-3525-1-git-send-email-heyi.guo@linaro.org> Subject: [RFC v4 3/3] MdeModulePkg/PciBus: return CPU address for GetBarAttributes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 02:04:44 -0000 According to UEFI spec 2.7, PciIo->GetBarAttributes should return host address (CPU view ddress) rather than device address (PCI view address), and device address = host address + address translation offset, so we subtract translation from device address before returning. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Cc: Ruiyu Ni Cc: Ard Biesheuvel Cc: Star Zeng Cc: Eric Dong Cc: Laszlo Ersek Cc: Michael D Kinney --- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c index fef3eceb7f62..62179eb44bbd 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c @@ -1972,6 +1972,10 @@ PciIoGetBarAttributes ( return EFI_UNSUPPORTED; } } + + // According to UEFI spec 2.7, we need return host address for + // PciIo->GetBarAttributes, and host address = device address - translation. + Descriptor->AddrRangeMin -= Descriptor->AddrTranslationOffset; } return EFI_SUCCESS; -- 2.7.4