From: Jordan Justen <jordan.l.justen@intel.com>
To: Liming Gao <liming.gao@intel.com>, edk2-devel@lists.01.org
Cc: Andrew Fish <afish@apple.com>
Subject: Re: [Patch] EmulatorPkg: Undefine CR3 macro in Host.h
Date: Mon, 26 Feb 2018 21:36:19 -0800 [thread overview]
Message-ID: <151970977944.13332.6827215629756406360@jljusten-skl> (raw)
In-Reply-To: <1519366938-4152-1-git-send-email-liming.gao@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
On 2018-02-22 22:22:18, Liming Gao wrote:
> CR3 has been used as structure field name in BaseLib IA32_TASK_STATE_SEGMENT.
> Undefine CR3 to make sure there is no conflict to it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> ---
> EmulatorPkg/Unix/Host/Host.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmulatorPkg/Unix/Host/Host.h b/EmulatorPkg/Unix/Host/Host.h
> index 9d6d36e..f7db46c 100644
> --- a/EmulatorPkg/Unix/Host/Host.h
> +++ b/EmulatorPkg/Unix/Host/Host.h
> @@ -82,7 +82,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> #undef NTOHS
> #undef HTONS
> #undef B0
> -
> +#undef CR3
>
> #include <PiPei.h>
> #include <Uefi.h>
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-02-27 5:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 6:22 [Patch] EmulatorPkg: Undefine CR3 macro in Host.h Liming Gao
2018-02-27 5:36 ` Jordan Justen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151970977944.13332.6827215629756406360@jljusten-skl \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox