public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] EmulatorPkg: Undefine CR3 macro in Host.h
@ 2018-02-23  6:22 Liming Gao
  2018-02-27  5:36 ` Jordan Justen
  0 siblings, 1 reply; 2+ messages in thread
From: Liming Gao @ 2018-02-23  6:22 UTC (permalink / raw)
  To: edk2-devel; +Cc: Andrew Fish

CR3 has been used as structure field name in BaseLib IA32_TASK_STATE_SEGMENT.
Undefine CR3 to make sure there is no conflict to it.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Andrew Fish <afish@apple.com>
---
 EmulatorPkg/Unix/Host/Host.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/EmulatorPkg/Unix/Host/Host.h b/EmulatorPkg/Unix/Host/Host.h
index 9d6d36e..f7db46c 100644
--- a/EmulatorPkg/Unix/Host/Host.h
+++ b/EmulatorPkg/Unix/Host/Host.h
@@ -82,7 +82,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #undef NTOHS
 #undef HTONS
 #undef B0
-
+#undef CR3

 #include <PiPei.h>
 #include <Uefi.h>
--
2.8.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] EmulatorPkg: Undefine CR3 macro in Host.h
  2018-02-23  6:22 [Patch] EmulatorPkg: Undefine CR3 macro in Host.h Liming Gao
@ 2018-02-27  5:36 ` Jordan Justen
  0 siblings, 0 replies; 2+ messages in thread
From: Jordan Justen @ 2018-02-27  5:36 UTC (permalink / raw)
  To: Liming Gao, edk2-devel; +Cc: Andrew Fish

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

On 2018-02-22 22:22:18, Liming Gao wrote:
> CR3 has been used as structure field name in BaseLib IA32_TASK_STATE_SEGMENT.
> Undefine CR3 to make sure there is no conflict to it.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> ---
>  EmulatorPkg/Unix/Host/Host.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/Unix/Host/Host.h b/EmulatorPkg/Unix/Host/Host.h
> index 9d6d36e..f7db46c 100644
> --- a/EmulatorPkg/Unix/Host/Host.h
> +++ b/EmulatorPkg/Unix/Host/Host.h
> @@ -82,7 +82,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>  #undef NTOHS
>  #undef HTONS
>  #undef B0
> -
> +#undef CR3
> 
>  #include <PiPei.h>
>  #include <Uefi.h>
> --
> 2.8.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-27  5:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-23  6:22 [Patch] EmulatorPkg: Undefine CR3 macro in Host.h Liming Gao
2018-02-27  5:36 ` Jordan Justen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox