public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] edksetup.sh: Update help section regarding positional
@ 2018-03-10 16:11 Arvind Prasanna
  2018-03-14 11:25 ` Leif Lindholm
  0 siblings, 1 reply; 6+ messages in thread
From: Arvind Prasanna @ 2018-03-10 16:11 UTC (permalink / raw)
  To: edk2-devel

It is possible to source edksetup.sh from another script. If the
calling/sourcing script has any positional parameters set, those are
incorrectly accounted for in edksetup.sh while sourcing it resulting in
the the help section always being shown. This patch updates the help
section advising the user about these set positional parameters so they
can be unset prior to sourcing edksetup.sh.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
---
 edksetup.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/edksetup.sh b/edksetup.sh
index 93d6525..a3d5560 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -42,6 +42,8 @@ function HelpMsg()
   echo Please note: This script must be \'sourced\' so the environment can be changed.
   echo ". $SCRIPTNAME"
   echo "source $SCRIPTNAME"
+  echo "If this script is being sourced from another script, please ensure that the"
+  echo "sourcing/calling script has no set postional parameters."
 }
 
 function SetWorkspace()
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread
[parent not found: <1520669933-8602-1-git-send-email-arvindprasanna@gmail.com>]

end of thread, other threads:[~2018-03-16  6:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-10 16:11 [PATCH] edksetup.sh: Update help section regarding positional Arvind Prasanna
2018-03-14 11:25 ` Leif Lindholm
2018-03-16  6:18   ` Arvind Prasanna
     [not found] <1520669933-8602-1-git-send-email-arvindprasanna@gmail.com>
     [not found] ` <CAK-=9LqFN3c_ZOnFO=fAnnk6wqKxmbF+LXhek2x6tkXNB37e-g@mail.gmail.com>
2018-03-12 14:55   ` Gao, Liming
2018-03-12 17:17     ` Arvind Prasanna
2018-03-13  5:41       ` Arvind Prasanna

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox