From: Heyi Guo <heyi.guo@linaro.org>
To: edk2-devel@lists.01.org
Cc: Heyi Guo <heyi.guo@linaro.org>, Yi Li <phoenix.liyi@huawei.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: [PATCH 1/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload
Date: Mon, 12 Mar 2018 14:53:31 +0800 [thread overview]
Message-ID: <1520837611-94728-2-git-send-email-heyi.guo@linaro.org> (raw)
In-Reply-To: <1520837611-94728-1-git-send-email-heyi.guo@linaro.org>
Resetting timer compare register has a side effect of clearing GIC
pending status, if timer interrupt is level sensitive, so a "DSB SY"
is needed to make sure this change effect is synchronized.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
Signed-off-by: Yi Li <phoenix.liyi@huawei.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
---
ArmPkg/Drivers/TimerDxe/TimerDxe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmPkg/Drivers/TimerDxe/TimerDxe.c b/ArmPkg/Drivers/TimerDxe/TimerDxe.c
index 33d7c922221f..b732a2ac1b64 100644
--- a/ArmPkg/Drivers/TimerDxe/TimerDxe.c
+++ b/ArmPkg/Drivers/TimerDxe/TimerDxe.c
@@ -337,6 +337,7 @@ TimerInterruptHandler (
// Set next compare value
ArmGenericTimerSetCompareVal (CompareValue);
+ ArmDataSynchronizationBarrier ();
ArmGenericTimerEnableTimer ();
}
--
2.7.4
next prev parent reply other threads:[~2018-03-12 6:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 6:53 [PATCH 0/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload Heyi Guo
2018-03-12 6:53 ` Heyi Guo [this message]
2018-03-12 9:46 ` [PATCH 1/1] " Marc Zyngier
2018-03-12 10:26 ` Guo Heyi
2018-03-12 10:38 ` Guo Heyi
2018-03-12 10:38 ` Ard Biesheuvel
2018-03-12 10:48 ` Marc Zyngier
2018-03-13 0:34 ` Guo Heyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520837611-94728-2-git-send-email-heyi.guo@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox