From: Heyi Guo <heyi.guo@linaro.org>
To: edk2-devel@lists.01.org
Cc: Heyi Guo <heyi.guo@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: [PATCH v2 0/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload
Date: Tue, 13 Mar 2018 08:31:29 +0800 [thread overview]
Message-ID: <1520901090-96694-1-git-send-email-heyi.guo@linaro.org> (raw)
After rebasing to edk2 commit 5e3719a, we found D05 would hang after printing a
lot of "Spurious interrupt" messages. The issue would gone away if we restored
the removal of "enable interrupt source":
gInterrupt->EnableInterruptSource (gInterrupt, Source);
It can also be fixed if we add a "ISB" after reloading timer compare value, and
we agree that it makes sense to do that.
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Heyi Guo (1):
ArmPkg/TimerDxe: Add ISB for timer compare value reload
ArmPkg/Drivers/TimerDxe/TimerDxe.c | 1 +
1 file changed, 1 insertion(+)
--
2.7.4
next reply other threads:[~2018-03-13 0:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 0:31 Heyi Guo [this message]
2018-03-13 0:31 ` [PATCH v2 1/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload Heyi Guo
2018-03-13 9:33 ` Marc Zyngier
2018-03-14 0:25 ` Guo Heyi
2018-03-14 7:45 ` Marc Zyngier
2018-03-14 14:50 ` Ard Biesheuvel
2018-03-15 7:11 ` Guo Heyi
2018-03-15 7:30 ` Ard Biesheuvel
2018-03-15 9:40 ` Marc Zyngier
2018-03-15 9:52 ` Ard Biesheuvel
2018-03-15 10:02 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520901090-96694-1-git-send-email-heyi.guo@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox