From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400d:c0d::244; helo=mail-qt0-x244.google.com; envelope-from=arvindprasanna@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-qt0-x244.google.com (mail-qt0-x244.google.com [IPv6:2607:f8b0:400d:c0d::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5C39A21F6A6D3 for ; Mon, 12 Mar 2018 22:31:54 -0700 (PDT) Received: by mail-qt0-x244.google.com with SMTP id g60so21427478qtd.11 for ; Mon, 12 Mar 2018 22:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jkROYlngbp/3+BE0+H3RXKRZRSSEn/gv8TDu1R3/5zA=; b=DbtRyWxxoQueaYJU3/IjvQ+HK8OXbzK+l7xxPVlvQTdw4WTI3n+QKhR+Uh3vLtWiwP ovFf8V8q3TUrTNcLhtmAplYwGhYixnSxYdxIY0khnu4lg5atUGSVhG0LuFqJa5pOd5KK R7vAWrmvL9HkbUOWXiXZNqTMVtPKlMasCzxZ6RL1Qfc1ottclkwluoMVcORZ/ExT2RG3 nD2MTR79fnvsxZt5aUeq+ldmClB1br3hvcNYdqQUyDGTHCGJMytTjJLcFAvPOhIJAeAq 5CrF1K/81NnYXtacjJmvabBpxEyKzR/NowTr9ZHCJJWyiUOVsMBl1PaWdCumtoOwF0hG 4diQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jkROYlngbp/3+BE0+H3RXKRZRSSEn/gv8TDu1R3/5zA=; b=Fk0X1+mUip04EOt+5epj0C1vsUOehDmc5r7NEL8zeaI20aK92tkWrRMq9FL33ovwab mlkBWUNA8j67obTSbLGEhIPUDH8JuNFOpWc/DOLRKDg/FQm21qXsSM3bV+vESAIeu3ty 8ww2M8a/GTvlUrPpEMcp9wiLNce+St6cL7S7f891ah1JR7POsJ+xfslTR0h6oUDV+UyL 3VYqG+HYGexbmO6yDChor7bYfw04d/drfVTcZQBK2umjGpQKqELG73YR6fuSzlvxHdYf 3QYn4kWkgMdXKGEykuS5ytw6QIn4oIlsL178oGAH+OaFU0v67VZEkYFIOBlxqXDf0Nlq dfnA== X-Gm-Message-State: AElRT7GPZY/H38EJBOmZWN7pF7znhhljOdky6RSabqDcNOxgCPN+Hlee t37dA+M/AyHlFPxDeMOm9Mw= X-Google-Smtp-Source: AG47ELtrhe+m6CyVNmd8GrQnc3VCPjAqwvjRXp8bvtvfd/zAdVPpbsF/etUEm717hx3N0XURrr3YYA== X-Received: by 10.200.57.228 with SMTP id v91mr15771170qte.77.1520919494485; Mon, 12 Mar 2018 22:38:14 -0700 (PDT) Received: from clonetrooper.netronome.com (c-67-171-64-245.hsd1.pa.comcast.net. [67.171.64.245]) by smtp.gmail.com with ESMTPSA id m66sm6475099qkl.43.2018.03.12.22.38.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Mar 2018 22:38:13 -0700 (PDT) From: Arvind Prasanna To: Cc: liming.gao@intel.com, yonghong.zhu@intel.com, edk2-devel@lists.01.org, Arvind Prasanna Date: Tue, 13 Mar 2018 01:38:06 -0400 Message-Id: <1520919486-9859-1-git-send-email-arvindprasanna@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: Subject: [PATCH v2] edksetup.sh: Update help section regarding positional parameters X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 05:31:54 -0000 It is possible to source edksetup.sh from another script. If the calling/sourcing script has any positional parameters set, those are incorrectly accounted for in edksetup.sh while sourcing it resulting in the the help section always being shown. This patch updates the help section advising the user about these set positional parameters so they can be unset prior to sourcing edksetup.sh. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Arvind Prasanna Changes in v2: - Fixed a typo. - Minor rewording. --- edksetup.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/edksetup.sh b/edksetup.sh index 93d6525..e85fbf2 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -42,6 +42,8 @@ function HelpMsg() echo Please note: This script must be \'sourced\' so the environment can be changed. echo ". $SCRIPTNAME" echo "source $SCRIPTNAME" + echo "If this script is being sourced from another script, please ensure that the" + echo "sourcing script has no set positional parameters." } function SetWorkspace() -- 2.7.4