public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Arvind Prasanna <arvindprasanna@gmail.com>
Cc: liming.gao@intel.com, edk2-devel@lists.01.org,
	Arvind Prasanna <arvindprasanna@gmail.com>
Subject: [PATCH v3] edksetup.sh: Update help section regarding positional parameters
Date: Tue, 13 Mar 2018 14:51:14 -0400	[thread overview]
Message-ID: <1520967075-17917-1-git-send-email-arvindprasanna@gmail.com> (raw)
In-Reply-To: <CAK-=9LrMQ9A9wDGi9VCiy5WUv3yWUCz5gBBaSNAvOXug2yz1tw@mail.gmail.com>

It is possible to source edksetup.sh from another script. If the
sourcing script has any set positional parameters that are not supported
by edksetup.sh, the help section is always shown. This patch updates
the help section informing the user about these possible unsupported set
positional parameters, so that, they can be unset prior to sourcing
edksetup.sh.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>

Changes in v3:
- Modify the help section to cover only unsupported positional parameters.
- Adapt commit message to the change in the above line

Changes in v2:
- Fixed a typo.
- Minor rewording.
---
 edksetup.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/edksetup.sh b/edksetup.sh
index 93d6525..6a590df 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -42,6 +42,8 @@ function HelpMsg()
   echo Please note: This script must be \'sourced\' so the environment can be changed.
   echo ". $SCRIPTNAME"
   echo "source $SCRIPTNAME"
+  echo "If this script is being sourced from another script, the sourcing script"
+  echo "should have no set positional parameters unsupported by this script."
 }
 
 function SetWorkspace()
-- 
2.7.4



      parent reply	other threads:[~2018-03-13 18:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1520669933-8602-1-git-send-email-arvindprasanna@gmail.com>
     [not found] ` <CAK-=9LqFN3c_ZOnFO=fAnnk6wqKxmbF+LXhek2x6tkXNB37e-g@mail.gmail.com>
2018-03-12 14:55   ` [PATCH] edksetup.sh: Update help section regarding positional Gao, Liming
2018-03-12 17:17     ` Arvind Prasanna
2018-03-13  5:38       ` [PATCH v2] edksetup.sh: Update help section regarding positional parameters Arvind Prasanna
2018-03-13  5:44         ` Arvind Prasanna
2018-03-13 13:44           ` Gao, Liming
2018-03-13 16:09             ` Arvind Prasanna
2018-03-13  5:41       ` [PATCH] edksetup.sh: Update help section regarding positional Arvind Prasanna
2018-03-13 18:51       ` Arvind Prasanna [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520967075-17917-1-git-send-email-arvindprasanna@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox