From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400d:c09::234; helo=mail-qk0-x234.google.com; envelope-from=arvindprasanna@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-qk0-x234.google.com (mail-qk0-x234.google.com [IPv6:2607:f8b0:400d:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C2C412264D22E for ; Tue, 13 Mar 2018 11:45:01 -0700 (PDT) Received: by mail-qk0-x234.google.com with SMTP id g184so742453qkd.10 for ; Tue, 13 Mar 2018 11:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7wLMZ2WBa8AMqFPtW+RJWHnoVi45sUIe4QvBb0XJPWQ=; b=JeByIvHx+u+SBVGx5EHcI4GckP8bxnEIX0n4t5KBrllj/lLMt6Tu9iHYJR+QScZljw 8TImCpzd2YQd1l5XgN2JRkWa1fJYM0AaBrgG5S7a3potSjN8xKx13Tdk52nVqKOec65z sjLaxWE1yxOLGnQuG96LWFMpm8HMxV7zwnVLDQS4L6h9jWBi8ybGsLtI2PhIZgVEySki I4yfWnaHeCTfzDpsUrZa9h7eJ64lOy0SkpxL8WWYiPqJgJt0hrWb6/9+fUdLpvnOaHtt u+Z0L8tkLGxzptG94a8rzNCTOOHSIghiUVKdPemwdKydbMC9VJKALf8ESNjxhXPT+81f DYMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7wLMZ2WBa8AMqFPtW+RJWHnoVi45sUIe4QvBb0XJPWQ=; b=ZympEuMSKNHK01Z9+an11jkg+ocV26wk+5EWgKRi1DEe5ouYf1iLUgD58WWRrMcGUn OJK/L9Ufhdq5vARfE7+yXIhktxoGvznPGfNOaw/cpGWvaruU7PZ8Qw++yNEtf/Ac/mJl jmjw/4AGkuQsCjWuTy73XXtvo/YPk4nWt9J1p5YBeSbRCUmbbPZHGQhX4wcX3l0RlS80 CJ/R7Y0N7U+NjcX16tx0sUOb96ORvWeQTGkJonzN3v4p+zbBVDbGta064YXNX7tjQ61X V9KruSOW/CE13F4+2qq2pH3IbnHX4RsJQKcoHVA4Q4Xdyej/xlyyULTMNqOVMoS5yCte AeeA== X-Gm-Message-State: AElRT7FfBrK1Tc7xVwYf/SeHPH8uuixKPLL2jEM7MzNuOimytuX8Afsp GRLHd4KCqfZz5hao5piBvlA= X-Google-Smtp-Source: AG47ELtBr/24OiN1/EIoSD/xrFPflZReiN0F4gVszakYy1Gim4LFP0Dd6ss7W8GAoBgDB+++zNn80w== X-Received: by 10.55.111.66 with SMTP id k63mr2590533qkc.25.1520967082783; Tue, 13 Mar 2018 11:51:22 -0700 (PDT) Received: from clonetrooper.netronome.com ([209.195.169.218]) by smtp.gmail.com with ESMTPSA id v84sm279483qkv.15.2018.03.13.11.51.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 13 Mar 2018 11:51:21 -0700 (PDT) From: Arvind Prasanna To: Cc: liming.gao@intel.com, edk2-devel@lists.01.org, Arvind Prasanna Date: Tue, 13 Mar 2018 14:51:14 -0400 Message-Id: <1520967075-17917-1-git-send-email-arvindprasanna@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: Subject: [PATCH v3] edksetup.sh: Update help section regarding positional parameters X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 18:45:02 -0000 It is possible to source edksetup.sh from another script. If the sourcing script has any set positional parameters that are not supported by edksetup.sh, the help section is always shown. This patch updates the help section informing the user about these possible unsupported set positional parameters, so that, they can be unset prior to sourcing edksetup.sh. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Arvind Prasanna Changes in v3: - Modify the help section to cover only unsupported positional parameters. - Adapt commit message to the change in the above line Changes in v2: - Fixed a typo. - Minor rewording. --- edksetup.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/edksetup.sh b/edksetup.sh index 93d6525..6a590df 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -42,6 +42,8 @@ function HelpMsg() echo Please note: This script must be \'sourced\' so the environment can be changed. echo ". $SCRIPTNAME" echo "source $SCRIPTNAME" + echo "If this script is being sourced from another script, the sourcing script" + echo "should have no set positional parameters unsupported by this script." } function SetWorkspace() -- 2.7.4