From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <heyi.guo@linaro.org>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
client-ip=2607:f8b0:400e:c01::244; helo=mail-pl0-x244.google.com;
envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org
Received: from mail-pl0-x244.google.com (mail-pl0-x244.google.com
[IPv6:2607:f8b0:400e:c01::244])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by ml01.01.org (Postfix) with ESMTPS id BD91620956064
for <edk2-devel@lists.01.org>; Wed, 14 Mar 2018 20:54:44 -0700 (PDT)
Received: by mail-pl0-x244.google.com with SMTP id ay1-v6so3017941plb.7
for <edk2-devel@lists.01.org>; Wed, 14 Mar 2018 21:01:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
h=from:to:cc:subject:date:message-id:in-reply-to:references;
bh=rhviWW23udxmj5gdM/D8sUe3FXKlLK7DSnq5kj3vWis=;
b=PL3G5DfS9e/gJenyArbVHrbmpGJRWiE5OsHXJH8Rm5FShzfnz7hGaoQhlr0YO8EUKq
dHKr82sbEhUtPtRfQ0RE9epSBgk9WxpS9E3OBGzbxh6UQq+U7rbq0DTMj8pH/brOUK4A
adapIuXc9emKwpOAOCKHxmkZ5sYOAFos4MaQA=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=rhviWW23udxmj5gdM/D8sUe3FXKlLK7DSnq5kj3vWis=;
b=WpwozYfb2tmKZYk1v00m7JilAdCHmZ7bmpgIT2LTCj+9ikNcdoqzU6PYtwvvODyS0B
ki6DXer7Uu7UtqeC+BlKadfpx4SNVpSGgtwGW89ab2Z+JMFKxSKrzDZdFzSpMR0DaqhO
usKLo8avel6+RcUV64R1c1bEy8hnn9iX2GSgofeV/sLjFp4E6AbzorvXwxWfozzxWILN
Bwy2QDvjDY/Z1S3nWA/1Gm3ACwgqvGn8ytr8LwJ9i2+dLhsT00ZljOhsLGnlJ+917SEM
Rtf6DlovObApvimC2aWlOH6yHEW2XRVUhvSCDJBu/CIaFr1G/h5VIBa5DNfxvIoOTNh+
Ddpw==
X-Gm-Message-State: AElRT7GEzBNSofGpTw4X6q2WGkH9nJRjrmpqgW14hqVARk79mrL7ikJf
rwEOOqlLFqowh7Ks/K6qCG/DhWEHaKI=
X-Google-Smtp-Source: AG47ELuvg61///CC0s+4vnbtL/mNwYSvsvPAHKfKkEB6ML7Hmtc8iKqgMaHlGjF32I8d/xGeWeY9og==
X-Received: by 2002:a17:902:f81:: with SMTP id
1-v6mr6420289plz.265.1521086466451;
Wed, 14 Mar 2018 21:01:06 -0700 (PDT)
Received: from localhost.localdomain ([45.56.152.100])
by smtp.gmail.com with ESMTPSA id e4sm8107785pfa.166.2018.03.14.21.01.04
(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Wed, 14 Mar 2018 21:01:05 -0700 (PDT)
From: Heyi Guo <heyi.guo@linaro.org>
To: edk2-devel@lists.01.org
Cc: Heyi Guo <heyi.guo@linaro.org>, Yi Li <phoenix.liyi@huawei.com>,
Ruiyu Ni <ruiyu.ni@intel.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Date: Thu, 15 Mar 2018 12:00:24 +0800
Message-Id: <1521086424-113954-7-git-send-email-heyi.guo@linaro.org>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1521086424-113954-1-git-send-email-heyi.guo@linaro.org>
References: <1521086424-113954-1-git-send-email-heyi.guo@linaro.org>
Subject: [PATCH v6 6/6] MdeModulePkg/PciBus: return CPU address for GetBarAttributes
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: EDK II Development <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
<mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
<mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Mar 2018 03:54:45 -0000
According to UEFI spec 2.7, PciIo->GetBarAttributes should return host
address (CPU view ddress) rather than device address (PCI view
address), and
device address = host address + address translation offset,
so we subtract translation from device address before returning.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
Signed-off-by: Yi Li <phoenix.liyi@huawei.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
index fef3eceb7f62..62179eb44bbd 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
@@ -1972,6 +1972,10 @@ PciIoGetBarAttributes (
return EFI_UNSUPPORTED;
}
}
+
+ // According to UEFI spec 2.7, we need return host address for
+ // PciIo->GetBarAttributes, and host address = device address - translation.
+ Descriptor->AddrRangeMin -= Descriptor->AddrTranslationOffset;
}
return EFI_SUCCESS;
--
2.7.4