From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c00::244; helo=mail-pf0-x244.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3616C21E08283 for ; Wed, 14 Mar 2018 22:59:03 -0700 (PDT) Received: by mail-pf0-x244.google.com with SMTP id q13so2465507pff.0 for ; Wed, 14 Mar 2018 23:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iYcOSp5Oiml897XHxDqe3TJg8iUlUm8UnBiyS9ZiZ4Y=; b=Jril/SOaGN/OGTpSZU4sIEceRce+60NFA45H0HiajbPMvspc0Pnf3z9CQzXymROkJt FVNHtk3kx2Q3llB8t+qWqmboXWPnzqDZWnWxB6iE7aMpZmyPx9kMSWuXu7/23YFe6w+q jertah/9Tk4+yxwuRUcIDzsvHfRamjYD0iCUo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iYcOSp5Oiml897XHxDqe3TJg8iUlUm8UnBiyS9ZiZ4Y=; b=jwoSy8VdCfj+bajbSvx5jzSpxChmGedz5YppmUIbhr4ZI6fmgkAcl0b6xeRE4L/zqd eRY9OdlC6s7AKz/izPGsPg8XdBeL2p643YUzpj+6KxPE8YuyV9vf0n9Wq70h5CA4R5rn oSa0cenu/UAcRWdUrPVB1hBddiMRef1fQxNDKd6pvxHSFgd96fPTxeAz/EOJAlGemwn9 dATKagui6ryPiVkIG2VsM6PV8f0pxSSZZDQQl17vtPcOQJvTltyrtMNRZiyDjfQqu+WI ZaAo7EfP7DRWi0+jv/0bQPz+iI0MecvnLbjSbeA92uM7HyOWlEl4S6OcS0T3Q/tAktNi uYOg== X-Gm-Message-State: AElRT7E25Rt5Ud+c7/Kq/11GYDKLRjs1lJGR8FVfpssrq9/u9Yz4iHUz WpnGHoqF8SGVhOty3zARXQHujptI+2k= X-Google-Smtp-Source: AG47ELsiMkV7R9gkwr+pbSgm6pxfUhJwHFkjp7ucwkG1knTwrh7M0P0Omn9hnPKMN4n+khuHTZhRNw== X-Received: by 10.99.96.79 with SMTP id u76mr520462pgb.199.1521093926487; Wed, 14 Mar 2018 23:05:26 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.100]) by smtp.gmail.com with ESMTPSA id 70sm7436192pgb.86.2018.03.14.23.05.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 14 Mar 2018 23:05:26 -0700 (PDT) From: Heyi Guo To: edk2-devel@lists.01.org Cc: Heyi Guo , Yi Li , Ruiyu Ni , Ard Biesheuvel , Star Zeng , Eric Dong , Laszlo Ersek , Michael D Kinney Date: Thu, 15 Mar 2018 14:04:03 +0800 Message-Id: <1521093843-48615-7-git-send-email-heyi.guo@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521093843-48615-1-git-send-email-heyi.guo@linaro.org> References: <1521093843-48615-1-git-send-email-heyi.guo@linaro.org> Subject: [PATCH v7 6/6] MdeModulePkg/PciBus: return CPU address for GetBarAttributes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 05:59:03 -0000 According to UEFI spec 2.7, PciIo->GetBarAttributes should return host address (CPU view ddress) rather than device address (PCI view address), and device address = host address + address translation offset, so we subtract translation from device address before returning. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Signed-off-by: Yi Li Reviewed-by: Ni Ruiyu Cc: Ruiyu Ni Cc: Ard Biesheuvel Cc: Star Zeng Cc: Eric Dong Cc: Laszlo Ersek Cc: Michael D Kinney --- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c index fef3eceb7f62..62179eb44bbd 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c @@ -1972,6 +1972,10 @@ PciIoGetBarAttributes ( return EFI_UNSUPPORTED; } } + + // According to UEFI spec 2.7, we need return host address for + // PciIo->GetBarAttributes, and host address = device address - translation. + Descriptor->AddrRangeMin -= Descriptor->AddrTranslationOffset; } return EFI_SUCCESS; -- 2.7.4