From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::233; helo=mail-pl0-x233.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x233.google.com (mail-pl0-x233.google.com [IPv6:2607:f8b0:400e:c01::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D68A62202E48B for ; Thu, 15 Mar 2018 00:11:44 -0700 (PDT) Received: by mail-pl0-x233.google.com with SMTP id w15-v6so3235180plq.9 for ; Thu, 15 Mar 2018 00:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=yzN+E7QCsnxIR7TKvr2EOcemtWKYwI6S9XDUUxUig1M=; b=F5yrcqkdfNhoNCl6o6IBGLgbFeWaH581g73VrNfDUF5I8+KQBpVbJkB45NjCRGLeD0 /JiSUZ85lOh6WD16KsM+am14d12U1yXdkY2jnJGxIXa105PkfuAp6uVm7ptbUK/SDF4R TPPB1dgR41RrCbMuFo7QmK/TPweO7WlB5jKKA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yzN+E7QCsnxIR7TKvr2EOcemtWKYwI6S9XDUUxUig1M=; b=dB7/tX8s0D9ffzziFAMs0LbNJ41njb3WyBWwGkZR9D5OoEbRebRcc2uDS3a4BrgaJv CLxKE4vF2qZ2thrm5A2fEgfU7WzAVQ9QK/6YhSPri4f6YNAyoKW1rosoNQAsGuXeMPb1 oWKr7qtg6cUFzy1bzzCwAwhnqs05xNJ9yz9maR6YXmr5cp52drxkqFQZ24rKHi+rFFEm epbXhL7NnpK4koJH3m74bhR7WKQuszW9VczzxCrY210F8+JNW9B1I3X4zje2pZlCRhUd /TddJ4lSsQQ0DI7T9ugGxp6f4UOS+tAV7pyYN32/vY8mqDc4VjP+17xszvEGaFVdxAeE ZW9Q== X-Gm-Message-State: AElRT7Ghic5bakYam2OmMSZ0RZh+cKTMSjUxa0cq0UivVRVYB1X+CcjZ EfQLzuv9JW5n4LiKgqVZZREytzWz5PM= X-Google-Smtp-Source: AG47ELsseqoI22envQveUFDbR7aVAPyO+uyUd9e98tepgAE4Tbbrk+OcwozuLIMr6kqF/q5HuRXsEg== X-Received: by 2002:a17:902:ab89:: with SMTP id f9-v6mr6900366plr.369.1521098288001; Thu, 15 Mar 2018 00:18:08 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.100]) by smtp.gmail.com with ESMTPSA id i186sm9026113pfg.25.2018.03.15.00.18.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Mar 2018 00:18:07 -0700 (PDT) From: Heyi Guo To: edk2-devel@lists.01.org Cc: Heyi Guo , Leif Lindholm , Ard Biesheuvel , Marc Zyngier Date: Thu, 15 Mar 2018 15:17:42 +0800 Message-Id: <1521098263-52823-1-git-send-email-heyi.guo@linaro.org> X-Mailer: git-send-email 2.7.4 Subject: [PATCH v3 0/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 07:11:45 -0000 After rebasing to edk2 commit 5e3719a, we found D05 would hang after printing a lot of "Spurious interrupt" messages. The issue would gone away if we restored the removal of "enable interrupt source": gInterrupt->EnableInterruptSource (gInterrupt, Source); It can also be fixed if we add a "ISB" after reloading timer compare value, and we agree that it makes sense to do that. v3: - Implement 1 comment from Marc. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Marc Zyngier Heyi Guo (1): ArmPkg/TimerDxe: Add ISB for timer compare value reload ArmPkg/Drivers/TimerDxe/TimerDxe.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4