[Patch] BaseTools: Fix bug for VOID* DynamicDefault Pcd use Flexible format

[Patch] BaseTools: Fix bug for VOID* DynamicDefault Pcd use Flexible format

[Yonghong Zhu]

From: Yunhua Feng <yunhuax.feng@intel.com>

define a flexible pcd format in Dyanmic/DynamicExDefault section,
it cause build error.
[PcdsDynamicExDefault.common.DEFAULT]
  pcdToken.Name|{GUID("11111111-2222-42eb-b5eb-fef31d207cb4")}

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 BaseTools/Source/Python/Common/Misc.py | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools/Source/Python/Common/Misc.py
index 2086b4c..7d44fdc 100644
--- a/BaseTools/Source/Python/Common/Misc.py
+++ b/BaseTools/Source/Python/Common/Misc.py
@@ -1718,18 +1718,10 @@ def AnalyzeDscPcd(Setting, PcdType, DataType=''):
             Type = FieldList[1]
         else:
             Type = DataType
         if len(FieldList) > 2:
             Size = FieldList[2]
-        else:
-            if Type == 'VOID*':
-                if Value.startswith("L"):
-                    Size = str((len(Value)- 3 + 1) * 2)
-                elif Value.startswith("{"):
-                    Size = str(len(Value.split(",")))
-                else:
-                    Size = str(len(Value) -2 + 1 )
         if DataType == "":
             IsValid = (len(FieldList) <= 1)
         else:
             IsValid = (len(FieldList) <= 3)
 
-- 
2.6.1.windows.1

Re: [Patch] BaseTools: Fix bug for VOID* DynamicDefault Pcd use Flexible format

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yonghong Zhu
> Sent: Saturday, March 17, 2018 3:38 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, YunhuaX <yunhuax.feng@intel.com>
> Subject: [edk2] [Patch] BaseTools: Fix bug for VOID* DynamicDefault Pcd use Flexible format
> 
> From: Yunhua Feng <yunhuax.feng@intel.com>
> 
> define a flexible pcd format in Dyanmic/DynamicExDefault section,
> it cause build error.
> [PcdsDynamicExDefault.common.DEFAULT]
>   pcdToken.Name|{GUID("11111111-2222-42eb-b5eb-fef31d207cb4")}
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  BaseTools/Source/Python/Common/Misc.py | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools/Source/Python/Common/Misc.py
> index 2086b4c..7d44fdc 100644
> --- a/BaseTools/Source/Python/Common/Misc.py
> +++ b/BaseTools/Source/Python/Common/Misc.py
> @@ -1718,18 +1718,10 @@ def AnalyzeDscPcd(Setting, PcdType, DataType=''):
>              Type = FieldList[1]
>          else:
>              Type = DataType
>          if len(FieldList) > 2:
>              Size = FieldList[2]
> -        else:
> -            if Type == 'VOID*':
> -                if Value.startswith("L"):
> -                    Size = str((len(Value)- 3 + 1) * 2)
> -                elif Value.startswith("{"):
> -                    Size = str(len(Value.split(",")))
> -                else:
> -                    Size = str(len(Value) -2 + 1 )
>          if DataType == "":
>              IsValid = (len(FieldList) <= 1)
>          else:
>              IsValid = (len(FieldList) <= 3)
> 
> --
> 2.6.1.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel