[PATCH edk2-non-osi 0/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer

[PATCH edk2-non-osi 0/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer

[Heyi Guo]

The code in SM750 driver treated the address returned from
PciIo->GetBarAttributes() as device address; this should be fixed
after edk2 commit dc080d3 since GetBarAttributes() returns host
address from then on.

Binary files can be fetched from:
https://github.com/iwishguo/edk2-non-osi/tree/patch-sm750-fix

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>

Heyi Guo (1):
  Hisilicon/D0x/Sm750: Fix GOP framebuffer base

 Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 18432 bytes
 Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 18464 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

-- 
2.7.4

[PATCH edk2-non-osi 1/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer base

[Heyi Guo]

The code in SM750 driver treated the address returned from
PciIo->GetBarAttributes() as device address; this should be fixed
after edk2 commit dc080d3 since GetBarAttributes() returns host
address from then on.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
Signed-off-by: Yi Li <phoenix.liyi@huawei.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 18432 bytes
 Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 18464 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
index 16c91e2b18ef..3c7aae7dc6f6 100644
Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ
diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
index b8de0259c785..7d4fe1b3228f 100644
Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ
-- 
2.7.4

Re: [PATCH edk2-non-osi 1/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer base

[Ard Biesheuvel]

On 22 March 2018 at 19:02, Heyi Guo <heyi.guo@linaro.org> wrote:
> The code in SM750 driver treated the address returned from
> PciIo->GetBarAttributes() as device address; this should be fixed
> after edk2 commit dc080d3 since GetBarAttributes() returns host
> address from then on.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> Signed-off-by: Yi Li <phoenix.liyi@huawei.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 18432 bytes
>  Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 18464 bytes

Hi Heyi,

If this is a PCI device, why do we have separate binaries for D03 and D05?


>  2 files changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
> index 16c91e2b18ef..3c7aae7dc6f6 100644
> Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ
> diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
> index b8de0259c785..7d4fe1b3228f 100644
> Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ
> --
> 2.7.4
>

Re: [PATCH edk2-non-osi 1/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer base

[Guo Heyi]

On Fri, Mar 23, 2018 at 05:25:54PM +0800, Ard Biesheuvel wrote:
> On 22 March 2018 at 19:02, Heyi Guo <heyi.guo@linaro.org> wrote:
> > The code in SM750 driver treated the address returned from
> > PciIo->GetBarAttributes() as device address; this should be fixed
> > after edk2 commit dc080d3 since GetBarAttributes() returns host
> > address from then on.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> > Signed-off-by: Yi Li <phoenix.liyi@huawei.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >  Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 18432 bytes
> >  Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 18464 bytes
> 
> Hi Heyi,
> 
> If this is a PCI device, why do we have separate binaries for D03 and D05?

That's a good question :) It should be a unified PCIe driver; I will check if
there is any platform specific code included and then try to merge them
together.

Thanks and regards,

Heyi

> 
> 
> >  2 files changed, 0 insertions(+), 0 deletions(-)
> >
> > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
> > index 16c91e2b18ef..3c7aae7dc6f6 100644
> > Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ
> > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
> > index b8de0259c785..7d4fe1b3228f 100644
> > Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ
> > --
> > 2.7.4
> >