From: Heyi Guo <heyi.guo@linaro.org>
To: edk2-devel@lists.01.org
Cc: Heyi Guo <heyi.guo@linaro.org>, Yi Li <phoenix.liyi@huawei.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base
Date: Mon, 26 Mar 2018 16:25:35 +0800 [thread overview]
Message-ID: <1522052735-68033-2-git-send-email-heyi.guo@linaro.org> (raw)
In-Reply-To: <1522052735-68033-1-git-send-email-heyi.guo@linaro.org>
Sm750Dxe is a generic PCIe device driver for SM750 VGA device, so it
is not necessary to maintain two different binary images for D03 and
D05 respectively.
The main difference between D03 and D05 is the implementation of
SerialPortLib, which causes BaseDebugLibSerialPort to be different. So
we switch to null DebugLib for release build and get a unified
Sm750Dxe binary.
The code in SM750 driver treated the address returned from
PciIo->GetBarAttributes() as device address; this should be fixed
after edk2 commit dc080d3 since GetBarAttributes() returns host
address from then on.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
Signed-off-by: Yi Li <phoenix.liyi@huawei.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf | 32 --------------------
Platform/Hisilicon/{D05 => }/Drivers/Sm750Dxe/UefiSmi.inf | 0
Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 0 bytes
Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 0 bytes
Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 0 -> 17760 bytes
5 files changed, 32 deletions(-)
diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf
deleted file mode 100644
index a2618331440f..000000000000
--- a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf
+++ /dev/null
@@ -1,32 +0,0 @@
-#/** @file
-#
-# Copyright (c) 2016, Hisilicon Limited. All rights reserved.
-# Copyright (c) 2016, Linaro Limited. All rights reserved.
-#
-# This program and the accompanying materials
-# are licensed and made available under the terms and conditions of the BSD License
-# which accompanies this distribution. The full text of the license may be found at
-# http://opensource.org/licenses/bsd-license.php
-#
-# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-#
-#**/
-
-
-[Defines]
- INF_VERSION = 0x00010005
- BASE_NAME = SmiGraphicsOutput
- FILE_GUID = BFB7B510-B09B-11DB-96E3-005056C00008
- MODULE_TYPE = UEFI_DRIVER
- VERSION_STRING = 1.0
-
- PCI_VENDOR_ID = 0x126F
- PCI_DEVICE_ID = 0x0750
- PCI_CLASS_CODE = 0x030000
- PCI_REVISION = 0xA1
- COMPRESS = TRUE
-
-[Binaries]
- PE32|SmiGraphicsOutput.efi|*
-
diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf
similarity index 100%
rename from Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf
rename to Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf
diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
deleted file mode 100644
index 16c91e2b18ef..000000000000
Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ
diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
deleted file mode 100644
index b8de0259c785..000000000000
Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ
diff --git a/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
new file mode 100644
index 000000000000..3ae8ddfb647f
Binary files /dev/null and b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ
--
2.7.4
next prev parent reply other threads:[~2018-03-26 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 8:25 [PATCH edk2-non-osi v2 0/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer Heyi Guo
2018-03-26 8:25 ` Heyi Guo [this message]
2018-03-28 13:37 ` [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base Ard Biesheuvel
2018-03-29 0:06 ` Guo Heyi
2018-03-30 10:56 ` Ard Biesheuvel
2018-03-31 0:36 ` Guo Heyi
2018-04-19 13:19 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522052735-68033-2-git-send-email-heyi.guo@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox