public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Yonghong Zhu <yonghong.zhu@intel.com>
To: edk2-devel@lists.01.org
Cc: Yunhua Feng <yunhuax.feng@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: [PATCH] BaseTools: Parse DSC component !include file report error issue
Date: Wed, 18 Apr 2018 16:56:04 +0800	[thread overview]
Message-ID: <1524041764-36404-1-git-send-email-yonghong.zhu@intel.com> (raw)

From: Yunhua Feng <yunhuax.feng@intel.com>

DSC format:
[Components]
  !include TestPkg/Test.dsc

if the Test.dsc have a INF, and the INF not exist, current the error message is
not clearly.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
---
 BaseTools/Source/Python/Workspace/MetaFileParser.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/BaseTools/Source/Python/Workspace/MetaFileParser.py b/BaseTools/Source/Python/Workspace/MetaFileParser.py
index f4c1868483..f74e8edbb2 100644
--- a/BaseTools/Source/Python/Workspace/MetaFileParser.py
+++ b/BaseTools/Source/Python/Workspace/MetaFileParser.py
@@ -1616,10 +1616,16 @@ class DscParser(MetaFileParser):
         except Exception:
             print ValList
 
     def __ProcessComponent(self):
         self._ValueList[0] = ReplaceMacro(self._ValueList[0], self._Macros)
+        ModuleFile = PathClass(self._ValueList[0], GlobalData.gWorkspace, Arch=self._Arch)
+        # check the file validation
+        ErrorCode, ErrorInfo = ModuleFile.Validate('.inf')
+        if ErrorCode != 0:
+            EdkLogger.error('build', ErrorCode, File=self._FileWithError.Path, Line=self._LineIndex + 1,
+                    ExtraData=ErrorInfo)
 
     def __ProcessSourceOverridePath(self):
         self._ValueList[0] = ReplaceMacro(self._ValueList[0], self._Macros)
 
     def __ProcessBuildOption(self):
-- 
2.12.2.windows.2



                 reply	other threads:[~2018-04-18  8:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524041764-36404-1-git-send-email-yonghong.zhu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox