public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] BaseTools: Parse DSC component !include file report error issue
@ 2018-04-18  8:56 Yonghong Zhu
  0 siblings, 0 replies; only message in thread
From: Yonghong Zhu @ 2018-04-18  8:56 UTC (permalink / raw)
  To: edk2-devel; +Cc: Yunhua Feng, Liming Gao

From: Yunhua Feng <yunhuax.feng@intel.com>

DSC format:
[Components]
  !include TestPkg/Test.dsc

if the Test.dsc have a INF, and the INF not exist, current the error message is
not clearly.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
---
 BaseTools/Source/Python/Workspace/MetaFileParser.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/BaseTools/Source/Python/Workspace/MetaFileParser.py b/BaseTools/Source/Python/Workspace/MetaFileParser.py
index f4c1868483..f74e8edbb2 100644
--- a/BaseTools/Source/Python/Workspace/MetaFileParser.py
+++ b/BaseTools/Source/Python/Workspace/MetaFileParser.py
@@ -1616,10 +1616,16 @@ class DscParser(MetaFileParser):
         except Exception:
             print ValList
 
     def __ProcessComponent(self):
         self._ValueList[0] = ReplaceMacro(self._ValueList[0], self._Macros)
+        ModuleFile = PathClass(self._ValueList[0], GlobalData.gWorkspace, Arch=self._Arch)
+        # check the file validation
+        ErrorCode, ErrorInfo = ModuleFile.Validate('.inf')
+        if ErrorCode != 0:
+            EdkLogger.error('build', ErrorCode, File=self._FileWithError.Path, Line=self._LineIndex + 1,
+                    ExtraData=ErrorInfo)
 
     def __ProcessSourceOverridePath(self):
         self._ValueList[0] = ReplaceMacro(self._ValueList[0], self._Macros)
 
     def __ProcessBuildOption(self):
-- 
2.12.2.windows.2



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-04-18  8:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-18  8:56 [PATCH] BaseTools: Parse DSC component !include file report error issue Yonghong Zhu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox