public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 2/8] MdeModulePkg/UiApp: Update RouteConfig function
@ 2018-04-18 20:32 Thomas Palmer
  2018-04-18 20:32 ` [PATCH 3/8] MdeModulePkg/RamDiskDxe: " Thomas Palmer
  2018-04-18 20:32 ` [PATCH 4/8] MdeModulePkg/DriverHealthManagerDxe: " Thomas Palmer
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Palmer @ 2018-04-18 20:32 UTC (permalink / raw)
  To: edk2-devel
  Cc: joseph.shifflett, nickle.wang, star.zeng, eric.dong,
	Thomas Palmer

According to UEFI spec, the RouteConfig protocol function should populate
the Progress pointer with an address inside Configuration.  This patch
ensures that these functions are compliant when EFI_NOT_FOUND is returned.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
---
 MdeModulePkg/Application/UiApp/FrontPage.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c b/MdeModulePkg/Application/UiApp/FrontPage.c
index adee67a8ac14..2403aad9d98f 100644
--- a/MdeModulePkg/Application/UiApp/FrontPage.c
+++ b/MdeModulePkg/Application/UiApp/FrontPage.c
@@ -2,6 +2,7 @@
   FrontPage routines to handle the callbacks and browser calls
 
 Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.<BR>
+(C) Copyright 2018 Hewlett Packard Enterprise Development LP<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
@@ -152,6 +153,8 @@ FakeRouteConfig (
     return EFI_INVALID_PARAMETER;
   }
 
+  *Progress = Configuration;
+
   return EFI_NOT_FOUND;
 }
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 3/8] MdeModulePkg/RamDiskDxe: Update RouteConfig function
  2018-04-18 20:32 [PATCH 2/8] MdeModulePkg/UiApp: Update RouteConfig function Thomas Palmer
@ 2018-04-18 20:32 ` Thomas Palmer
  2018-04-18 20:32 ` [PATCH 4/8] MdeModulePkg/DriverHealthManagerDxe: " Thomas Palmer
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Palmer @ 2018-04-18 20:32 UTC (permalink / raw)
  To: edk2-devel
  Cc: joseph.shifflett, nickle.wang, star.zeng, eric.dong,
	Thomas Palmer

According to UEFI spec, the RouteConfig protocol function should populate
the Progress pointer with an address inside Configuration.  This patch
ensures that these functions are compliant when EFI_NOT_FOUND is returned.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
---
 MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c
index b562bc102582..7ebd397fe68a 100644
--- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c
+++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c
@@ -2,7 +2,7 @@
   HII Config Access protocol implementation of RamDiskDxe driver.
 
   Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
-  (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
+  (C) Copyright 2016-2018 Hewlett Packard Enterprise Development LP<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
@@ -277,6 +277,8 @@ RamDiskRouteConfig (
     return EFI_INVALID_PARAMETER;
   }
 
+  *Progress = Configuration;
+
   return EFI_NOT_FOUND;
 }
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 4/8] MdeModulePkg/DriverHealthManagerDxe: Update RouteConfig function
  2018-04-18 20:32 [PATCH 2/8] MdeModulePkg/UiApp: Update RouteConfig function Thomas Palmer
  2018-04-18 20:32 ` [PATCH 3/8] MdeModulePkg/RamDiskDxe: " Thomas Palmer
@ 2018-04-18 20:32 ` Thomas Palmer
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Palmer @ 2018-04-18 20:32 UTC (permalink / raw)
  To: edk2-devel
  Cc: joseph.shifflett, nickle.wang, star.zeng, eric.dong,
	Thomas Palmer

According to UEFI spec, the RouteConfig protocol function should populate
the Progress pointer with an address inside Configuration.  This patch
ensures that these functions are compliant when EFI_NOT_FOUND is returned.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
---
 MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.c b/MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.c
index 16b703495a2f..3f9c24036d43 100644
--- a/MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.c
+++ b/MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.c
@@ -5,6 +5,7 @@
   firmware setup (UI).
 
 Copyright (c) 2013 - 2015, Intel Corporation. All rights reserved.<BR>
+(C) Copyright 2018 Hewlett Packard Enterprise Development LP<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
@@ -123,6 +124,8 @@ DriverHealthManagerFakeRouteConfig (
     return EFI_INVALID_PARAMETER;
   }
 
+  *Progress = Configuration;
+
   return EFI_NOT_FOUND;
 }
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-18 20:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-18 20:32 [PATCH 2/8] MdeModulePkg/UiApp: Update RouteConfig function Thomas Palmer
2018-04-18 20:32 ` [PATCH 3/8] MdeModulePkg/RamDiskDxe: " Thomas Palmer
2018-04-18 20:32 ` [PATCH 4/8] MdeModulePkg/DriverHealthManagerDxe: " Thomas Palmer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox