* [Patch] BaseTools: Fix one invalid change in 6be94743 @ 2018-04-25 3:09 Yonghong Zhu 2018-04-26 6:50 ` Zhu, Yonghong 0 siblings, 1 reply; 3+ messages in thread From: Yonghong Zhu @ 2018-04-25 3:09 UTC (permalink / raw) To: edk2-devel; +Cc: Yunhua Feng, Liming Gao From: Yunhua Feng <yunhuax.feng@intel.com> Roll back one change in 6be94743, it was updated incorrect. Cc: Liming Gao <liming.gao@intel.com> Cc: Yonghong Zhu <yonghong.zhu@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com> --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index 56b5d39..ba83d5a 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -3914,11 +3914,11 @@ class ModuleAutoGen(AutoGen): # Skip the following code for modules with no source files if not self.SourceFileList: return # Skip the following code for modules without any binary files - if not self.BinaryFileList: + if self.BinaryFileList: return ### TODO: How to handles mixed source and binary modules # Find all DynamicEx and PatchableInModule PCDs used by this module and dependent libraries -- 2.6.1.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] BaseTools: Fix one invalid change in 6be94743 2018-04-25 3:09 [Patch] BaseTools: Fix one invalid change in 6be94743 Yonghong Zhu @ 2018-04-26 6:50 ` Zhu, Yonghong 2018-04-26 14:18 ` Carsey, Jaben 0 siblings, 1 reply; 3+ messages in thread From: Zhu, Yonghong @ 2018-04-26 6:50 UTC (permalink / raw) To: Zhu, Yonghong, edk2-devel@lists.01.org Cc: Feng, YunhuaX, Gao, Liming, Zhu, Yonghong Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, April 25, 2018 11:09 AM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <yunhuax.feng@intel.com>; Gao, Liming <liming.gao@intel.com> Subject: [edk2] [Patch] BaseTools: Fix one invalid change in 6be94743 From: Yunhua Feng <yunhuax.feng@intel.com> Roll back one change in 6be94743, it was updated incorrect. Cc: Liming Gao <liming.gao@intel.com> Cc: Yonghong Zhu <yonghong.zhu@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com> --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index 56b5d39..ba83d5a 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -3914,11 +3914,11 @@ class ModuleAutoGen(AutoGen): # Skip the following code for modules with no source files if not self.SourceFileList: return # Skip the following code for modules without any binary files - if not self.BinaryFileList: + if self.BinaryFileList: return ### TODO: How to handles mixed source and binary modules # Find all DynamicEx and PatchableInModule PCDs used by this module and dependent libraries -- 2.6.1.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] BaseTools: Fix one invalid change in 6be94743 2018-04-26 6:50 ` Zhu, Yonghong @ 2018-04-26 14:18 ` Carsey, Jaben 0 siblings, 0 replies; 3+ messages in thread From: Carsey, Jaben @ 2018-04-26 14:18 UTC (permalink / raw) To: Zhu, Yonghong, Zhu, Yonghong, edk2-devel@lists.01.org Cc: Feng, YunhuaX, Gao, Liming Can you also update the comment to match the code please. I think that the comment is wrong and your code is correct, but now they are opposite. The comment says skip (return in context) for no binary files, but the new code will skip for modules with binary files... -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Zhu, Yonghong > Sent: Wednesday, April 25, 2018 11:51 PM > To: Zhu, Yonghong <yonghong.zhu@intel.com>; edk2-devel@lists.01.org > Cc: Feng, YunhuaX <yunhuax.feng@intel.com>; Gao, Liming > <liming.gao@intel.com> > Subject: Re: [edk2] [Patch] BaseTools: Fix one invalid change in 6be94743 > > Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> > > Best Regards, > Zhu Yonghong > > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, April 25, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Feng, YunhuaX <yunhuax.feng@intel.com>; Gao, Liming > <liming.gao@intel.com> > Subject: [edk2] [Patch] BaseTools: Fix one invalid change in 6be94743 > > From: Yunhua Feng <yunhuax.feng@intel.com> > > Roll back one change in 6be94743, it was updated incorrect. > > Cc: Liming Gao <liming.gao@intel.com> > Cc: Yonghong Zhu <yonghong.zhu@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com> > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py > b/BaseTools/Source/Python/AutoGen/AutoGen.py > index 56b5d39..ba83d5a 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -3914,11 +3914,11 @@ class ModuleAutoGen(AutoGen): > # Skip the following code for modules with no source files > if not self.SourceFileList: > return > > # Skip the following code for modules without any binary files > - if not self.BinaryFileList: > + if self.BinaryFileList: > return > > ### TODO: How to handles mixed source and binary modules > > # Find all DynamicEx and PatchableInModule PCDs used by this module > and dependent libraries > -- > 2.6.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-26 14:18 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-04-25 3:09 [Patch] BaseTools: Fix one invalid change in 6be94743 Yonghong Zhu 2018-04-26 6:50 ` Zhu, Yonghong 2018-04-26 14:18 ` Carsey, Jaben
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox